[Matrix-SIG] Typo in multiarraymodule.c

Travis E. Oliphant Oliphant.Travis@mayo.edu
Sun, 31 Jan 1999 22:36:28 -0600

This is a multi-part message in MIME format.
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

I think I found a typo in multiarraymodule.c in the latest 1.9 release
that messes up the functionality of convolve.

Try convolve([1,2],[1,2,3],2) and convolve([1,2,3],[1,2],2).  These
should give the same result but they don't in my NumPy.

The fix is simple (change a 1 to an i) and a one-line diff is attached.



Travis Oliphant            200 First St SW          
    	                   Rochester MN 55905       
Ultrasound Research Lab	   (507) 286-5923           
Mayo Graduate School	   Oliphant.Travis@mayo.edu
Content-Type: text/plain; charset=us-ascii; name="multidiff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline; filename="multidiff"

< 	if (n1 < n2) { ret = ap1; ap1 = ap2; ap2 = ret; ret = NULL; i = n1;n1=n2;n2=i;}
> 	if (n1 < n2) { ret = ap1; ap1 = ap2; ap2 = ret; ret = NULL; i = n1;n1=n2;n2=1;}