[Patches] [ python-Patches-1623563 ] Allow __class __ assignment for classes with __slots__

[SourceForge.net]

Patches item #1623563, was opened at 2006-12-28 06:48
Message generated for change (Comment added) made by jimjjewett
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1623563&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core (C code)
Group: Python 2.6
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: TH (therve)
Assigned to: Nobody/Anonymous (nobody)
Summary: Allow __class __ assignment for classes with __slots__

Initial Comment:
I made a modification in typeobject.c to allow __class__ modification for classes with slots. It's basically a change in same_slots_added to count the offset of the slots and check if the names of the slots are the same (in the naive way). 

I don't check if slots are in a different order, that may be an improve.

The patch is against trunk, with some tests. It's my first submission on Python, so every feedback will be welcome :).

----------------------------------------------------------------------

Comment By: Jim Jewett (jimjjewett)
Date: 2007-02-08 13:41

Message:
Logged In: YES 
user_id=764593
Originator: NO

Review five other patches. 

Post the review summaries (and tracker numbers) to the python-dev mailing
list.

In that same message, ask someone with commit privileges to do the 5:1
deal, pointing at this tracker number.



----------------------------------------------------------------------

Comment By: TH (therve)
Date: 2007-02-06 08:43

Message:
Logged In: YES 
user_id=1038797
Originator: YES

Is there anything I can do to have a resolution on this ?

Thanks.

----------------------------------------------------------------------

Comment By: Jim Jewett (jimjjewett)
Date: 2006-12-30 19:26

Message:
Logged In: YES 
user_id=764593
Originator: NO

Just going through the list doesn't seem so naive to me.  If the slots are
in a different order, then you would need to move the data around -- which
borders on "maybe they ought to have written the translator themselves"

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1623563&group_id=5470