[pypy-issue] [issue841] [PATCH] Implement 'os.getlogin'

Armin Rigo tracker at bugs.pypy.org
Sat Aug 27 13:00:55 CEST 2011

Armin Rigo <armin.rigo at gmail.com> added the comment:

"""if result is None:"""

This line is wrong.  'result' is a CCHARP here, so the line should check if it's
null instead.  That's done just by saying """if not result:"""

This small error very probably makes "translate.py" choke.  That's why you also
need to write a test in pypy/translator/c/test/test_extfunc.py.  It's important
enough that it's actually enough to rewrite a test in test_extfunc instead of in

nosy: +arigo

PyPy bug tracker <tracker at bugs.pypy.org>

More information about the pypy-issue mailing list