[pypy-issue] [issue841] [PATCH] Implement 'os.getlogin'

[Mitchell Hashimoto]

Mitchell Hashimoto <mitchell.hashimoto at gmail.com> added the comment:

Armin,

I've taken your feedback into account and have attached a new patch (os-
getlogin3.patch) which has a test in test_extfunc and changes the NULL check to 
"if not result"

Note that I'm not sure how to properly test a failing case for getlogin(3), 
since it requires some fairly exceptional events to manifest, and I didn't see 
any examples for mocking/stubbing C APIs in the tests. 

Please let me know what else I can do to get this merged :)

Thanks!
Mitchell

________________________________________
PyPy bug tracker <tracker at bugs.pypy.org>
<https://bugs.pypy.org/issue841>
________________________________________