[ python-Bugs-1280924 ] PyDateTime_Check references static object

[SourceForge.net]

Bugs item #1280924, was opened at 2005-09-02 14:14
Message generated for change (Comment added) made by montanaro
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1280924&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Python Library
Group: None
>Status: Closed
>Resolution: Invalid
Priority: 5
Submitted By: Skip Montanaro (montanaro)
Assigned to: Nobody/Anonymous (nobody)
Summary: PyDateTime_Check references static object

Initial Comment:
In trying to use the C API for datetime objects, we
noticed that
PyDateTime_Check references PyDateTime_DateTimeType,
which is declared static in datetimemodule.c.  This is true
for 2.3, 2.4 and CVS.  That suggests that either
PyDateTime_Check
is supposed to only be used in the datetime module (in
which case it is incorrectly named or its definition is
in the 
wrong file) or the static and statichere declarations
need to
be removed from it.

On the assumption that PyDateTime_Check is supposed to be
publically used, I'm going to opt for the latter fix.


----------------------------------------------------------------------

>Comment By: Skip Montanaro (montanaro)
Date: 2005-09-02 14:49

Message:
Logged In: YES 
user_id=44345

After looking things over a bit I realize that in 2.4 there
are two versions
of the check macros and that the check macros in 2.3 were
probably
intended to only be used from within the module itself since
there was
no fully defined C API.  I'm going to close this, but others
feel free to
reopen in case my original thoughts were more correct than I
now think.

Skip


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1280924&group_id=5470