[issue1736] Three bugs of FCICreate (PC/_msi.c)

[Hirokazu Yamamoto]

New submission from Hirokazu Yamamoto:

I have fixed three bugs of msilib.FCICreate()

1. msilib.FCICreate("a.cab") creates ".a.cab" (extra leading dot)

In recent cab SDK's FCI-FDI.doc,

# quote start

The szCab field should contain a string which contains the name of the 
first cabinet to be created (e.g. “APP1.CAB”).  In the event of 
multiple cabinets being created, the GetNextCab function called by the 
FCIAddFile API allows subsequent cabinet names to be specified.

The szCabPath field should contain the complete path of where to create 
the cabinet (e.g. “C:\MYFILES\”).

# quote end

Currently, _msi.c separate "C:\\MYFILES\\APP1.CAB" to szCabPath "C:" 
and szCab "\\MYFILES\\APP1.CAB".

2. Probably, "long names" error check doesn't count null-terminator now.
3. Usually, multibyte character may contain "\\" as trailing-byte. 
(like "ソ" in Japanese) Not to count this as path separator, I used 
CharNext().

Thank you.

----------
components: Library (Lib)
files: _msi.patch
messages: 59228
nosy: ocean-city
severity: normal
status: open
title: Three bugs of FCICreate (PC/_msi.c)
versions: Python 2.5, Python 2.6, Python 3.0
Added file: http://bugs.python.org/file9058/_msi.patch

__________________________________
Tracker <report at bugs.python.org>
<http://bugs.python.org/issue1736>
__________________________________