[issue24348] incorrect decref in C OrderedDict

[Eric Snow]

New submission from Eric Snow:

(from msg244575 in issue16991)

crash-2.py is due to the fact that _PyDict_Pop() deletes a reference
to 'key' in _odict_popkey().

The INCREF(key) in popitem should take place before calling _odict_popkey().


Again, I don't see the point of INCREF/DECREF *inside* of _odict_popkey().

----------
assignee: eric.snow
components: Library (Lib)
files: crash-2.py
messages: 244598
nosy: eric.snow, skrah
priority: release blocker
severity: normal
stage: needs patch
status: open
title: incorrect decref in C OrderedDict
type: crash
versions: Python 3.5, Python 3.6
Added file: http://bugs.python.org/file39589/crash-2.py

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue24348>
_______________________________________