[Python-checkins] r43586 - python/trunk/Modules/posixmodule.c

"Martin v. Löwis" martin at v.loewis.de
Tue Apr 4 07:53:07 CEST 2006


Neal Norwitz wrote:
> Unless I'm reading this patch wrong, it looks like it will crash if
> only a single parameter is passed in.  With a single argument,
> operation is NULL and strlen(NULL) go boom.

This is true; I later corrected it.

> I think this patch should be reverted, unless a test case is added and
> the coded corrected.

So what should the test case do? There currently aren't any test cases
for startfile at all; "just" extending them to Unicode strings isn't
possible.

Regards,
Martin


More information about the Python-checkins mailing list