[python-committers] Promote Xiang Zhang as a core developer

[Berker Peksağ]

On Tue, Nov 15, 2016 at 11:17 AM, Victor Stinner
<victor.stinner at gmail.com> wrote:
> Hi,
>
> 2016-11-15 1:10 GMT+01:00 Berker Peksağ <berker.peksag at gmail.com>:
>> Xiang tends to fix things that are not broken,
>
> This sentence sounds strange. What do you mean? :-)
>
>> (...)  and when you point out that the thing they are
>> trying to fix is not broken, they try to start an endless discussion.
>> I also saw a couple of instances where they refused to address code
>> review comments from experienced core developers (which is a red flag
>> for me)
>
> I guess that "they" means "he", so Xiang, right?

Correct, sorry for being unclear.
https://en.wikipedia.org/wiki/Singular_they can probably do a better
job on explaining my usage of it :)

> Do you have some examples of such discussions? I'm not aware of such issue.

* http://bugs.python.org/review/27861/ (you can start reading from my
first comment)
* http://bugs.python.org/issue27740
* http://bugs.python.org/issue27414

There are more examples where Xiang refused to address reviews
comments by saying "do what you want", but I don't really have time to
dig bugs.p.o mails now (one of them was in response to Serhiy's
comments) Committing a patch takes a lot of time and I think
respecting a core developer's time is a good trait to look for (of
course I'm not saying that all review comments are correct and should
be addressed without any discussion)

I agree that we should look for people who wrote high quality patches,
but I think we also should look for people who help other members of
the community by doing *boring* tasks (e.g. review patches submitted
by other contributors, triage old issues on the tracker, update an
outdated patch by addressing review comments)

--Berker