[python-committers] Vote to promote Pablo Salingo Salgado as core developer

[Gregory P. Smith]

Quick response:

+0.5

My first reaction was "really?" given the amount of iteration required due
to lack of CPython extension module API experience demonstrated in the
os.posix_spawn PRs.  (I am not surprised to see Serhiy's negative
reaction)  But Pablo shows drive and desire to do good things and an
ability to eventually do it even if there are learning bumps along the
way.  With mentoring and PR reviews (which I'm assuming Victor is signing
up for) I believe Pablo would make a fine core developer.

So +0.5 from me.  I wouldn't give Pablo free reign to make changes yet -
mentoring required - but that is exactly how most of us start off while we
learn.  I know I started that way.

-gps




On Thu, Jun 14, 2018 at 5:06 AM Victor Stinner <vstinner at redhat.com> wrote:

> Oh, I forgot to mention that Pablo is already helping me on triagging
> buildbot failures since 1 month.See my email to python-dev for the
> context:
>
> "[Python-Dev] How to watch buildbots?"
> https://mail.python.org/pipermail/python-dev/2018-May/153754.html
>
> You can see his emails on the buildbot-status mailing list:
> https://mail.python.org/mm3/mailman3/lists/buildbot-status.python.org/
>
> Victor
>
> 2018-06-13 18:16 GMT+02:00 Victor Stinner <vstinner at redhat.com>:
> > Hi,
> >
> > I propose to promote Pablo Salingo Salgado as a core developer and so
> > open a vote during one week. If there is no strong opposition, I will
> > promote him but also continue to mentor him for a least one month.
> >
> > Pablo is contributing frequently to Python since almost one year. He
> > added os.preadv()/pwritev() to Python 3.7 and os.posix_spawn() to
> > Python 3.8. I am now waiting for his os.copy_file_range() function!
> > (Others are working on it.)
> > https://bugs.python.org/issue26826
> >
> > I am mentoring Pablo Salingo Salgado since January. I am watching his
> > hard work since last September. He made many non trivial and useful
> > contributions to Python.
> >
> > I think that he understands well how Python is developed, is
> > respectful, try to find answers alone before asking, and is eager to
> > learn. In case of doubt, he ask others before doing something, like
> > closing an issue. I trust that Pablo will respect opinions of others,
> > like not merging a PR if someone disagree.
> >
> > Pablo's merged PR:
> >
> https://github.com/python/cpython/pulls?utf8=%E2%9C%93&q=is%3Aclosed+is%3Apr+author%3Apablogsal+
> >
> > He got 22 commits merged into master between September 2017 and June
> 2018.
> >
> > If Pablo is promoted as a core developer, I propose to continue to be
> > his mentor for at least one month, and ask him before merging any PR.
> >
> > Note: Pablo already has the bug triage permission for 5 months:
> >
> https://mail.python.org/pipermail/python-committers/2018-January/005133.html
> >
> > Victor
> _______________________________________________
> python-committers mailing list
> python-committers at python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-committers/attachments/20180614/943d1edb/attachment.html>