[Python-Dev] Reindenting unicodedata.c

holger krekel pyth@devel.trillke.net
Fri, 8 Nov 2002 21:52:09 +0100

Guido van Rossum wrote:
> > [Martin v. Loewis]
> > > While working on unicodedata.c, I found that its indentation does not
> > > follow PEP 7. Is it ok to reindent it (i.e. use tabs)?
> > 
> > Probably not, but I'd be in favor of it.  unicodeobject.c too, and _sre.c,
> > and _hotshot.c, and ... the PEP 7 std is simply ignored.
> I'm in favor of reindenting too, but only if you're doing major work
> on a module.  I.e. don't just reindent a module when you're fixing a
> few lines of code; but when you're doing a major refactoring, it
> should be fine.
> CVS-wise, it's better to do the reindent as a separate checkin, so you
> know you're not changing anything else.  (Preferably just *before* you
> start doing any major surgery.)

Probably backporting patches (e.g. python2.2.3) gets harder.

Some bigger projects i know *strictly* prohibit cosmetic-only 
patches because of this very problem.  Only if you are actually
changing code can you reindent.