[Python-Dev] urllib2 patch reviewer (852995)?

Jeremy Hylton jeremy at zope.com
Mon Dec 15 10:50:47 EST 2003


On Mon, 2003-12-15 at 05:11, Michael Hudson wrote:
> John J Lee <jjl at pobox.com> writes:
> 
> > Jeremy Hylton just checked in a relatively major patch of mine to urllib2.
> > He's obviously very busy, though, so it would be nice if somebody else who
> > knows urllib2 could look at it, too.
> 
> I don't have the know-how to review the patch, but I can notice that
> test_urllib2 now seems to be creating uncollectable garbage...

Yes.  Didn't get a chance to fix that the other night.  One of the
classes has a pretty useless __del__ that might have helped before we
had gc for cycles.  The original urllib2 code is pretty old.

Jeremy





More information about the Python-Dev mailing list