[Python-Dev] a bunch of Patch reviews

["Martin v. Löwis"]

Irmen de Jong wrote:
> 1- I can't add new files to this tracker item.
>    Should I open a new patch and refer to it?

Depends on whether you want tracker admin access (i.e.
become a SF python project member). If you do,
you could attach patches to bug reports not
written by you.

> 2- As shadow passwords can only be retrieved when
>    you are root, is a unit test module even useful?

Probably not. Alternatively, introduce a "root" resource,
and make that test depend on the presence of the root resource.

> 3- Should the order of the chapters in the documentation
>    be preserved? I'd rather add spwd below pwd, but
>    this pushes the other unix modules "1 down"...

You could make it a subsection (e.g. "spwd -- shadow passwords")
Not sure whether this would be supported by the processing
tools; if not, inserting the module in the middle might be
acceptable.

In any case, what is important is that the documentation is
added - it can always be rearranged later.

Regards,
Martin