[Python-Dev] Windows buildbot test_bsddb3 problems (was RE: Buildbots for trunk are all red)

[Trent Nelson]

> Trent, thanks for working on the buildbot.  I fixed the first case you
> mentioned in r61233 wrt removing the directory before closing the
> file.  It would be great if you could submit a patch when you are able
> to fix the remaining problems.

% svn diff
Index: test_dbshelve.py
===================================================================
--- test_dbshelve.py    (revision 61233)
+++ test_dbshelve.py    (working copy)
@@ -267,8 +267,8 @@


     def tearDown(self):
+        self.do_close()
         test_support.rmtree(self.homeDir)
-        self.do_close()


 class EnvBTreeShelveTestCase(BasicEnvShelveTestCase):
Index: test_thread.py
===================================================================
--- test_thread.py      (revision 61233)
+++ test_thread.py      (working copy)
@@ -73,9 +73,9 @@
         self.d.open(self.filename, self.dbtype, self.dbopenflags|db.DB_CREATE)

     def tearDown(self):
-        test_support.rmtree(self.homeDir)
         self.d.close()
         self.env.close()
+        test_support.rmtree(self.homeDir)

     def setEnvOpts(self):
         pass


I'm getting 100% success rate with test_bsddb3 on Windows now with this patch.  Yay!


        Trent.

--
http://www.onresolve.com