[Python-Dev] Define a place for code review in Python workflow

[Georg Brandl]

Am 26.07.2010 22:18, schrieb anatoly techtonik:

> Small introduction for insiders not familiar with outsider's problem
> of maintaining patches in tracker. Please forgive the tone I write
> about things I dislike, but I am not devoting my life to earn a title
> of polite bastard (this one is obligatory disclaimer I find it still
> doesn't work for all people, so expect some irrelevant flame in
> follow-ups).

Nice!  I wish we'd all do this.  We'd have so much more time to do actual work.

> As code comments are hard to keep offtopic, the signal to noise ration
> appears to be is quite high.
> The patch upload script is designed in a way that every project can
> tune it for their needs and place into the root of source code.
> "review" project at PyPI.is uploaded from source at
> http://bitbucket.org/techtonik/pypi-rietveld - it can be tuned to
> address needs specific for Python development.
> 
> 
> What do you need to start using code review for contributed Python patches?
> Why you wouldn't recommend this practice to outsiders?

I'd welcome any patch submitted to Rietveld for review.  However, your
proposed "review.py" module does not exist as far as I know, and unless
someone writes it, it won't.

Georg

-- 
Thus spake the Lord: Thou shalt indent with four spaces. No more, no less.
Four shall be the number of spaces thou shalt indent, and the number of thy
indenting shall be four. Eight shalt thou not indent, nor either indent thou
two, excepting that thou then proceed to four. Tabs are right out.