[Python-Dev] r84430 - in python/branches/py3k: Include/unicodeobject.h Objects/unicodeobject.c

[Nick Coghlan]

On Thu, Sep 2, 2010 at 6:51 PM, Georg Brandl <g.brandl at gmx.net> wrote:
> Hi Victor,
>
> 1. This function and PyUnicode_strcat are missing documentation.
>
> 2. Are you sure they need to be public APIs?  What are they going to
>   be used for?  (I'm not sure myself, but I think we usually have a
>   short notice here when new C APIs are added.)

I believe I first saw them on Victor's branch for improved Unicode
support (especially in the context of import).

I agree that private _Py prefixes are probably a better idea here. The
public API should focus on Py_Unicode, with only a minimal collection
of Py_UNICODE interfaces.

Regarding the naming scheme, if these are what I recall them as (drop
in replacements for the 8-bit C stdlib equivalents to simplify the
relevant import.c updates), I'm fine with the current naming for
private API functions, but agree with MAL they should be made more
explicit if they're part of the published API.

Cheers,
Nick.

-- 
Nick Coghlan   |   ncoghlan at gmail.com   |   Brisbane, Australia