[Python-Dev] Rietveld or Review Board use?

[Barry Warsaw]

On Mar 04, 2011, at 05:19 PM, Victor Stinner wrote:

>Le vendredi 04 mars 2011 à 10:05 -0600, skip at pobox.com a écrit :
>> Is Rietveld or Review Board being used within the Python core development
>> community?  I looked at the dev guide but didn't see anything obvious about
>> code reviews.  I don't see how to search the Rietveld instance at
>> codereview.appspot.com looking just for Python core review requests.
>> 
>> My aim here is to provide some examples to a colleague at work.  I wanted to
>> give him some examples related to code with which I'm familiar.
>
>I used it at least twice.
>
>Issue #9425: http://codereview.appspot.com/1874048
>Issue #3080: http://codereview.appspot.com/3972045

Yep, I used Rietveld for the PEP 3147/3149 patches and it was pretty nice.
It's not completely well integrated into our workflow, but it's cool enough
that I think we should promote it more.  Will that be easier once we're
permanently on Mercurial?

-Barry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://mail.python.org/pipermail/python-dev/attachments/20110304/4aed4298/attachment.pgp>