[Python-Dev] r88758 - tracker/instances/python-dev/scripts/addpatchsets

Antoine Pitrou solipsis at pitrou.net
Sun Mar 6 19:14:40 CET 2011


On Sun, 06 Mar 2011 18:23:58 +0100
"Martin v. Löwis" <martin at v.loewis.de> wrote:
> >> -def find_bases(data, rev):
> >> +def hg_splitpatch(data):
> >> +    patches = []
> >> +    filename = None
> >> +    for line in data.splitlines(True):
> >> +        if line.startswith('diff -r'):
> >
> > Now I understand why you would like to discourage git diffs.
> > But, as I said back then, I don't think it's worthwhile to try and
> > compute the base rev. Most reviewable patches should apply cleanly
> > against the latest revision on "default", otherwise we're gonna ask the
> > poster to regenerate the patch anyway.
> 
> Would you like to contribute a patch to make that work? It's too tedious
> to work without a base revision, so for the time being, this cannot be
> supported.

Well, no. I was assuming that basing all patches on tip would make
things simpler.

Regards

Antoine.




More information about the Python-Dev mailing list