[Python-Dev] cpython: PyUnicode_FromKindAndData() raises a ValueError if the kind is unknown
Stephen J. Turnbull
stephen at xemacs.org
Mon Oct 3 20:28:39 CEST 2011
"Martin v. Löwis" writes:
> > Also, could I remind you that a better commit message is probably
> > "make PyUnicode_FromKindAndData raise a ValueError if the kind is
> > unknown".
>
> I think this is asking too much.
This distinction is important enough that it's worth asking non-native
speakers to *learn* this one idiom ("make Python do"), and all
developers to *use* it (or an equally unambiguous form, if they feel
like being original).
Whether that's a reasonable burden for individual non-natives is going
to depend on the individual, of course. But asking is not out of line.
> I believe Victor formulated this in the spirit of
Sure, one can figure that out -- but that's a lot of effort to ask of
readers of logs. In general it requires familiarity with the patch
being documented.
More information about the Python-Dev
mailing list