[Python-Dev] cpython: Optimize str%arg for number formats: %i, %d, %u, %x, %p

Antoine Pitrou solipsis at pitrou.net
Wed Feb 22 15:47:05 CET 2012


On Wed, 22 Feb 2012 13:58:45 +0100
victor.stinner <python-checkins at python.org> wrote:
>  
> +/* Copy a ASCII or latin1 char* string into a Python Unicode string.
> +   Return the length of the input string.
> +
> +   WARNING: Don't copy the terminating null character and don't check the
> +   maximum character (may write a latin1 character in an ASCII string). */

If this is a description of what the function does, it should say
"doesn't", not "don't".  Right now this comment is ambiguous (is it an
order given to the reader?).

Regards

Antoine.




More information about the Python-Dev mailing list