[Python-Dev] Windows build - fixing compile warnings before VS2010

[Brian Curtin]

On Wed, Feb 22, 2012 at 10:04, shibturn <shibturn at gmail.com> wrote:
> On 22/02/2012 3:32am, Brian Curtin wrote:
>>
>> 1. Is anyone opposed to moving up to Level 4 warnings?
>
>
> At that level I think it complains about common things like the "do {...}
> while (0)" idiom, and the unreferenced self parameter of builtin functions.
>
> Presumably you would have to disable those specific warnings and any other
> overly annoying ones?

What we did was fix what was reasonable, then disable warnings which
were unreasonable. If that's reasonable, that's how I would do it.

(just to say it one more time: reasonable)