[Python-Dev] cpython: Fix memory leak in pyexpat PyUnknownEncodingHandler

Christian Heimes christian at python.org
Sat Jun 29 21:51:19 CEST 2013

Am 29.06.2013 21:29, schrieb R. David Murray:
> I don't know if this is the commit at fault or not, but we are seeing
> segfaults in test_xml_etree on the buildbots now.

Yeah, it's my fault. Thanks!

>>      u = PyUnicode_Decode((char*) template_buffer, 256, name, "replace");
>> -    if (u == NULL || PyUnicode_READY(u))wr
>> +        Py_DECREF(u);
>>          return XML_STATUS_ERROR;
>> +    }

Py_DECREF() is wrong as u can be NULL. I have changed the code to use

More information about the Python-Dev mailing list