[Python-Dev] Appeal for reviews

[Stephen J. Turnbull]

Nikolaus Rath writes:

 > I've described the status of each bug in more detail in my reply 
 > Terry, but generally all the issues contain a testcase (i.e., so I
 > consider them confirmed), do not require a PEP, contain a patch that
 > needs review and include documentation updates. I have signed the CA,
 > and I have updated the issue status as much as I can (I don't seem to
 > have privileges to add/change keywords). 

AFAIK that can be described as:

 > All the patches are complete in the sense that I think they can be
 > committed and would improve Python.

I don't suggest you need to say more than that.  Perhaps I overlooked
such a statement in the OP?  If so, I'm sorry.

For somebody who is submitting their first round of patches I would
recommend some statement indicating that they know about the
"checklist" you described above, but by now you're well-known to the
Right People.

 > Of course, further improvements are always possible.

Your modesty is not in question. :-)  An explicit statement that "These
are ready" allows an experienced developer to give you feedback not
only about whether the patches are in fact ready, but whether your
judgment about patches is ready for commit privileges -- in Python
it's desirable that code be "Pythonic" as well as correct and clean.

 > I'm not sure about (2) -- what different kind of reviews are there?

>From the contributor point of view, I'd broadly say

 - I'm stuck (this is harder than I thought), somebody please look at
   what I've done and tell me I haven't screwed up so far, and then
   I'll go back to work.

 - I'm a little stuck, maybe I'm done, but I'm not sure.  Please look.

 - I'm done, please commit it if you agree.

Evidently you specifically listed patches for which you want an "I'm
done" review.  Part of why I wrote what I did is that I didn't
recognize that.

 > > There must be stuff of interest to you happening on twitter, etc.,
 > > during PyCon.
 > 
 > I'm not quite sure what you're getting at (maybe because I don't use
 > twitter).

Just that on the one hand, it was very obvious to me that over the
last few weeks people were very busy preparing for PyCon (and so even
less time than usual for reviewing), and on the other, if you can't be
at PyCon, there's much to hear about Python design and implementation,
and about Pythonic thinking by following the language summit and what
people are talking about during PyCon.