[Python-Dev] GH-NNNN vs #NNNN in merge commit

[Barry Warsaw]

On Jan 25, 2018, at 16:55, Mariatta Wijaya <mariatta.wijaya at gmail.com> wrote:

> My problem has been that I almost always still need to rewrite the commit message.
> Especially when someone wrote "fix a typo" or "fix several typos".
> 
> If it automatically merges, then there's no opportunity to adjust the commit message.

Right, that’s the bit that’s different here than the GitLab workflow.  In the latter, you can set the commit message when you click on “merge when CI succeeds”.

> So I suggest the option to provide the proper commit message to the mergebot.
> If not provided, I guess we'll use the GitHub PR title and description.

I think that’d be fine actually.  When I merge things I almost always just delete most of the default commit message anyway.

-Barry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Message signed with OpenPGP
URL: <http://mail.python.org/pipermail/python-dev/attachments/20180125/2f6042a0/attachment.sig>