[python-win32] pywin32 setup.py forgets win32/lib

[Christian Tismer]

Hi Mark,

Yes, I understand very well, knowing the patching dance so much more
than I'd like to...

In fact, 'win32/lib' is a folder, actually the only one which is not also a
package, and exactly this one does not show up in the install logs.

I have the impression that setuptools changed policy about 'py_modules',
if 'packages' is given, too. So I think 'win32/lib' is the only problem 
here, because
it is the only thing that is not a package.

Will try to narrow this down after I am out of my urgent pressure.

What makes me nervous is that nobody else complained so far. Maybe it 
was never
built again for a long time? There are the pre-built installers, but it 
happened to me
that a VS2010 build was needed, and that caused all the grief ...

thanks for your very quick answer -- later - Chris


On 11.11.13 00:01, Mark Hammond wrote:
> Hi Christian,
>   I'm a little reluctant to apply this patch as it stands - we rely on 
> setuptools doing the right thing for *all* "library" modules - eg, if 
> we need win32/lib/*.py, we presumably would need all other .py files 
> not listed here - eg, the entire win32com package, etc.
>
> However, if you can't narrow this down any further, please upload it 
> to sourceforge, and I'll see if I can reproduce it next time I make a 
> build.
>
> Cheers,
>
> Mark
>
> On 11/11/2013 9:34 AM, Christian Tismer wrote:
>> Hi Mark and friends,
>>
>> for a customer, I had to build pywin32 with VS2010, and when it finally
>> worked after some changes from https://wiki.python.org/moin/VS2010,
>> I still could not run
>>
>>      import win32con
>>
>> I tried to find out why, to no success. I examined some older
>> installation logs
>> on my machine, and the installation of win32/lib was in fact done
>> correctly.
>>
>> With the recent setuptools (tested with 1.2.1 and 1.3.2), the 
>> 'py_modules'
>> entry of setup.py seems to be ignored.
>>
>> After pulling hair until I became almost bald, I ended up with the
>> following
>> patch to pywin32 version 217 (218 does not work for me, missing files):
>>
>> Here is the patch if it makes sense to submit it here:
>>
>> ------------------------------------------------------------
>>  From aaea11c6b7560969255e4a1d5dd7d07fa08dae47 Mon Sep 17 00:00:00 2001
>> From: Christian Tismer <tismer at stackless.com>
>> Date: Sun, 10 Nov 2013 22:30:05 +0100
>> Subject: [PATCH] add win32/lib files.
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>>
>> This seems to be an incompatibility with recent setuptools. (tested
>> 1.1.6 and 1.3.2)
>> Should be investigated further who has a bug here…
>> ---
>>   pywin32-217/setup.py | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/pywin32-217/setup.py b/pywin32-217/setup.py
>> index f77eecf..4480d00 100644
>> --- a/pywin32-217/setup.py
>> +++ b/pywin32-217/setup.py
>> @@ -2372,6 +2372,11 @@ dist = setup(name="pywin32",
>>                   'pythonwin/pywin/Demos/app/*.py',
>>                   'pythonwin/pywin/Demos/ocx/*.py',
>>                   'pythonwin/license.txt',
>> +                # CT 20131110 BEGIN
>> +                # for some reason, the files in 'py_modules' are 
>> ignored.
>> +                # this may be a setuptools problem.
>> +                'win32/lib/*.py',
>> +                # CT 20131110 END
>>                   'win32/license.txt',
>>                   'win32/scripts/*.py',
>>                   'win32/test/*.py',
>


-- 
Christian Tismer             :^)   <mailto:tismer at stackless.com>
Software Consulting          :     Have a break! Take a ride on Python's
Karl-Liebknecht-Str. 121     :    *Starship* http://starship.python.net/
14482 Potsdam                :     PGP key -> http://pgp.uni-mainz.de
phone +49 173 24 18 776  fax +49 (30) 700143-0023
PGP 0x57F3BF04       9064 F4E1 D754 C2FF 1619  305B C09C 5A3B 57F3 BF04
       whom do you want to sponsor today?   http://www.stackless.com/