[spambayes-dev] More CVS branch/tags questions

Mark Hammond mhammond at skippinet.com.au
Tue Nov 4 17:32:33 EST 2003

I saw Skip raise this last week, but I think he was asking different

My understanding is that we are moving towards 1.0 on the release_1_0
branch.  Is that correct?

If so, I'm a little confused by this :)  If we look at an edited log from
sb_server, we see (Please see my comments/questions inline with "****", and
at the end:

RCS file: /cvsroot/spambayes/spambayes/scripts/sb_server.py,v
Working file: sb_server.py
head: 1.11
symbolic names:
        outlook-1-0-fork: 1.11
        release_1_0_a6: 1.6

**** My reading of this is that this file was branched for 1.0 at 1.6.

revision 1.11
date: 2003/10/07 00:36:30;  author: anadelonbrin;  state: Exp;  lines: +2 -3
Fix [ spambayes-Bugs-818871 ] sb_server.py calls undefined variable
revision 1.10
date: 2003/09/29 04:43:09;  author: anadelonbrin;  state: Exp;  lines:
+27 -0
revision 1.9
date: 2003/09/25 00:10:31;  author: mhammond;  state: Exp;  lines: +99 -15
Patch [ 809008 ] safe start/stop and exlusive execution on windows
revision 1.8
date: 2003/09/24 05:28:53;  author: anadelonbrin;  state: Exp;  lines: +3 -1
This should fix [ spambayes-Bugs-809769 ] TypeError when training 1.0a6
revision 1.7
date: 2003/09/19 23:38:10;  author: anadelonbrin;  state: Exp;  lines: +5 -6
Add the various interface improvements discussed on spambayes-dev.  In
an advanced 'find token' query is available, the 'find message' query is
and the review messages page is more customisable.
date: 2003/09/24 03:54:14;  author: anadelonbrin;  state: Exp;  lines: +4 -1
Stupid global variables!

Thanks to a global variable not being updated, when we recreated everything,
the userinterface kept
using the old classifier.
Since we now behave and close that one, this caused all sorts of problems.
Get rid of the damn glob
al variable, and correctly
update it, and all is well in the world again.

In addition, don't save an empty database.  I think we make assumptions
about the db being non-empty
 in some places.

This should fix [ spambayes-Bugs-809769 ] TypeError when training 1.0a6

(I can't believe it took so long for me to find this!)

*** From my reading of this, the "1.0" release is missing a number of
significant patches - all 1.7->1.11 checkings appear to *not* be on the 1.0

And very interestingly, note that 1.8 and *both* claim to fix
[809769], and on the same day.

I doubt this is the intention - I can't recall anyone deciding to fix real,
verified bugs *after* the 1.0 release.  Can anyone shed any light?



More information about the spambayes-dev mailing list