[spambayes-dev] Does this seem too brutal?
Meyer, Tony
T.A.Meyer at massey.ac.nz
Wed Sep 10 17:18:47 EDT 2003
> A couple other suggestions:
>
> * Realign the indentation of the args in the setup() call.
:) I did this too, but did the diff ignoring whitespace changes. So
+1.
> * Make sure the os.remove() calls in .run() don't bomb out
> in case any old scripts have already been deleted.
Good point.
> * ??? Return parent.run(self) in all cases. In your code if
> there are old scripts but the user chooses not to remove them,
> parent.run(self) is not called.
Sounds sensible.
> Attached is a(nother) proposed mod.
This looks good to me. Anyone have any objections to this version being
checked in?
=Tony Meyer
More information about the spambayes-dev
mailing list