[spambayes-dev] sb_filter -n broke?

[Kenny Pitt]

Skip Montanaro wrote:
>     Tony> The whole open_storage function was getting a bit messy from all
>     Tony> the fixes, so I've tidied it up a bit, and fixed this.  Could
you
>     Tony> confirm that it works for you?
> 
> Nope:
> 
[snip]

I think the fatal flaw is in the "if mode is not None" check.  Hammie.py
always passes a mode value whether useDB is true or false, so the condition
will always be true.  The appropriate fix here may be to change __init__ for
PickledClassifier to accept the mode parameter for consistency, and then
just not use it.

[From Tony Meyer in storage.py]
***************
*** 661,666 ****
          klass = PickledClassifier
      try:
!         if isinstance(data_source_name, type(())):
!             return klass(*data_source_name)
          return klass(data_source_name)
      except dbmstorage.error, e:
--- 660,665 ----
          klass = PickledClassifier
      try:
!         if mode is not None:
!             return klass(data_source_name, mode)
          return klass(data_source_name)
      except dbmstorage.error, e: