_bsddb.c ownership
Who 'owns' Modules/_bsddb.c, if anyone? The file doesn't mention whether it's a fork of pybsddb maintained separately or not. I ask because it seems to contain a number of refleaks, and I wanted to fix some of the style issues while I'm at it (and maybe even Py_ssize_t it,) but I'll happily send the patch to pybsddb instead. (Georg and I already checked in some fixes, anyway.) -- Thomas Wouters <thomas@python.org> Hi! I'm a .signature virus! copy me into your .signature file to help me spread!
Thomas Wouters wrote:
Who 'owns' Modules/_bsddb.c, if anyone?
It's a fork of pybsddb, originally contributed by Gregory Smith (*). For all practical purposes, he also "owns" it, but hasn't objected to others making changes in the past. At the time it was imported, I recall the plan was to out-phase pybsddb, and only keep the version in Python. It appears that things have developed differently. http://mail.python.org/pipermail/python-dev/2002-June/025616.html http://mail.python.org/pipermail/python-dev/2002-June/025806.html http://mail.python.org/pipermail/python-dev/2002-October/029788.html http://mail.python.org/pipermail/python-dev/2002-November/030247.html Regards, Martin (*) although I did the original import.
On 3/7/06, "Martin v. Löwis" <martin@v.loewis.de> wrote:
Thomas Wouters wrote:
Who 'owns' Modules/_bsddb.c, if anyone?
It's a fork of pybsddb, originally contributed by Gregory Smith (*). For all practical purposes, he also "owns" it, but hasn't objected to others making changes in the past.
At the time it was imported, I recall the plan was to out-phase pybsddb, and only keep the version in Python. It appears that things have developed differently.
Alright. It seems someone <wink> already made backward-incompatible changes to _bsddb.c (adding Py_ssize_t use), and various other things were fixed, too, so I just went ahead and checked in a bunch of small fixes. I'm not done yet, though. After I am done (which might be a while still, but hopefully before alpha1), I'll fix backward compatibility and send in a patch to the pybsddb project :) -- Thomas Wouters <thomas@python.org> Hi! I'm a .signature virus! copy me into your .signature file to help me spread!
On Wed, Mar 08, 2006 at 03:03:48AM +0100, Thomas Wouters wrote:
On 3/7/06, "Martin v. L??wis" <martin@v.loewis.de> wrote:
Thomas Wouters wrote:
Who 'owns' Modules/_bsddb.c, if anyone?
It's a fork of pybsddb, originally contributed by Gregory Smith (*). For all practical purposes, he also "owns" it, but hasn't objected to others making changes in the past.
At the time it was imported, I recall the plan was to out-phase pybsddb, and only keep the version in Python. It appears that things have developed differently.
Alright. It seems someone <wink> already made backward-incompatible changes to _bsddb.c (adding Py_ssize_t use), and various other things were fixed, too, so I just went ahead and checked in a bunch of small fixes. I'm not done yet, though. After I am done (which might be a while still, but hopefully before alpha1), I'll fix backward compatibility and send in a patch to the pybsddb project :)
Yeah I "own" it for whatever thats worth. The pybsddb project only continues to exist as a skeleton to provide a more up to date BerkeleyDB module for: (a) use with a new BerkeleyDB version (b) use with older versions of python The pybsddb project does not have its own copy of the code, it just pulls Modules/_bsddb.c and the Lib/bsddb/ directly from the python repository using a script. Its appreciated if people keep Modules/_bsddb.c and Lib/bsddb/ backwards compatible with the few revs of python. Otherwise I end up finding out and fixing it myself with ifdefs on the rare occasions when I attempt to make another pybsddb module release and find it doesn't work with an old version. ;) -greg
On 3/30/06, Gregory P. Smith <greg@electricrain.com> wrote:
The pybsddb project does not have its own copy of the code, it just pulls Modules/_bsddb.c and the Lib/bsddb/ directly from the python repository using a script.
Ah, excellent, that makes it a lot easier for the rest of python-dev.
Its appreciated if people keep Modules/_bsddb.c and Lib/bsddb/ backwards compatible with the few revs of python. Otherwise I end up finding out and fixing it myself with ifdefs on the rare occasions when I attempt to make another pybsddb module release and find it doesn't work with an old version. ;)
I'll see about making all the recent changes backwardly-compatible. -- Thomas Wouters <thomas@python.org> Hi! I'm a .signature virus! copy me into your .signature file to help me spread!
participants (3)
-
"Martin v. Löwis" -
Gregory P. Smith -
Thomas Wouters