Hi all, Bili put in a PR to reverse the orientation of yt's default angular momentum vector to be closer to what most people expect given conventions about right handed coordinate systems. See https://github.com/yt-project/yt/pull/2043 I'm a little nervous about merging this since it might be disruptive. Does anyone see any issues with merging? People on master branch should know what they're in for? If no one responds here or comments in the PR I'll probably merge the PR next week. -Nathan
Yeah, it might be a little disruptive in flipping OffAxisProjectionPlots and such, but ultimately, it is doing things correctly now. I'm +0.5 on this, as I know it's going to make some of my past plots require swapping the L term. :) Cameron On Thu, Dec 13, 2018 at 2:38 PM Nathan Goldbaum <nathan12343@gmail.com> wrote:
Hi all,
Bili put in a PR to reverse the orientation of yt's default angular momentum vector to be closer to what most people expect given conventions about right handed coordinate systems.
See https://github.com/yt-project/yt/pull/2043
I'm a little nervous about merging this since it might be disruptive. Does anyone see any issues with merging? People on master branch should know what they're in for?
If no one responds here or comments in the PR I'll probably merge the PR next week.
-Nathan _______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
-- Cameron Hummels NSF Postdoctoral Fellow Department of Astronomy California Institute of Technology http://chummels.org
Well, the current calculation is obviously not correct (I have never seen a calculation of angular momentum that wasn’t r x p). Is there a way to efficiently notify a lot of users who may be using master besides emailing yt-users? That seems fine to me. Dr. John ZuHone Astrophysicist, Chandra X-ray Center Center for Astrophysics | Harvard & Smithsonian Office: (617) 496 1816 | Cell: (781) 708 5004 60 Garden Street | MS 03 | Cambridge, MA 02138 john.zuhone@cfa.harvard.edu http://hea-www.cfa.harvard.edu/~jzuhone
On Dec 13, 2018, at 5:37 PM, Nathan Goldbaum <nathan12343@gmail.com> wrote:
Hi all,
Bili put in a PR to reverse the orientation of yt's default angular momentum vector to be closer to what most people expect given conventions about right handed coordinate systems.
See https://github.com/yt-project/yt/pull/2043
I'm a little nervous about merging this since it might be disruptive. Does anyone see any issues with merging? People on master branch should know what they're in for?
If no one responds here or comments in the PR I'll probably merge the PR next week.
-Nathan _______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
Good idea, I’ll send an email to yt-users. On Thu, Dec 13, 2018 at 4:47 PM John ZuHone <jzuhone@gmail.com> wrote:
Well, the current calculation is obviously not correct (I have never seen a calculation of angular momentum that wasn’t r x p).
Is there a way to efficiently notify a lot of users who may be using master besides emailing yt-users? That seems fine to me.
*Dr. John ZuHone*
*Astrophysicist, Chandra X-ray CenterCenter for Astrophysics | Harvard & Smithsonian*
Office: (617) 496 1816 | Cell: (781) 708 5004 60 Garden Street | MS 03 | Cambridge, MA 02138 john.zuhone@cfa.harvard.edu http://hea-www.cfa.harvard.edu/~jzuhone
On Dec 13, 2018, at 5:37 PM, Nathan Goldbaum <nathan12343@gmail.com> wrote:
Hi all,
Bili put in a PR to reverse the orientation of yt's default angular momentum vector to be closer to what most people expect given conventions about right handed coordinate systems.
See https://github.com/yt-project/yt/pull/2043
I'm a little nervous about merging this since it might be disruptive. Does anyone see any issues with merging? People on master branch should know what they're in for?
If no one responds here or comments in the PR I'll probably merge the PR next week.
-Nathan
_______________________________________________
yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
_______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
I think this is fine. One question, looking at the patch, I don't see how the field gets the center with which to set the angular momentum. I guess it assumes it is the origin, but that is not usually the case in our simulations, where the center of a rotating star might be at a non-zero location. I know it's beyond the scope of this patch, but we might want to warn users that it assumes a particular center? On Thu, Dec 13, 2018 at 5:38 PM Nathan Goldbaum <nathan12343@gmail.com> wrote:
Hi all,
Bili put in a PR to reverse the orientation of yt's default angular momentum vector to be closer to what most people expect given conventions about right handed coordinate systems.
See https://github.com/yt-project/yt/pull/2043
I'm a little nervous about merging this since it might be disruptive. Does anyone see any issues with merging? People on master branch should know what they're in for?
If no one responds here or comments in the PR I'll probably merge the PR next week.
-Nathan _______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
-- Michael Zingale Associate Professor Dept. of Physics & Astronomy • Stony Brook University • Stony Brook, NY 11794-3800 *phone*: 631-632-8225 *e-mail*: Michael.Zingale@stonybrook.edu *web*: http://www.astro.sunysb.edu/mzingale github: http://github.com/zingale
That comes in via the position vectors, which are influenced by the “center” field parameter. It’s not explivcit in that definition because it’s handled elsewhere. On Thu, Dec 13, 2018 at 4:48 PM Michael Zingale < michael.zingale@stonybrook.edu> wrote:
I think this is fine. One question, looking at the patch, I don't see how the field gets the center with which to set the angular momentum. I guess it assumes it is the origin, but that is not usually the case in our simulations, where the center of a rotating star might be at a non-zero location. I know it's beyond the scope of this patch, but we might want to warn users that it assumes a particular center?
On Thu, Dec 13, 2018 at 5:38 PM Nathan Goldbaum <nathan12343@gmail.com> wrote:
Hi all,
Bili put in a PR to reverse the orientation of yt's default angular momentum vector to be closer to what most people expect given conventions about right handed coordinate systems.
See https://github.com/yt-project/yt/pull/2043
I'm a little nervous about merging this since it might be disruptive. Does anyone see any issues with merging? People on master branch should know what they're in for?
If no one responds here or comments in the PR I'll probably merge the PR next week.
-Nathan _______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
-- Michael Zingale Associate Professor
Dept. of Physics & Astronomy • Stony Brook University • Stony Brook, NY 11794-3800 *phone*: 631-632-8225 *e-mail*: Michael.Zingale@stonybrook.edu *web*: http://www.astro.sunysb.edu/mzingale github: http://github.com/zingale
_______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
awesome! figured you folks had thought of it all On Thu, Dec 13, 2018 at 6:09 PM Nathan Goldbaum <nathan12343@gmail.com> wrote:
That comes in via the position vectors, which are influenced by the “center” field parameter. It’s not explivcit in that definition because it’s handled elsewhere.
On Thu, Dec 13, 2018 at 4:48 PM Michael Zingale < michael.zingale@stonybrook.edu> wrote:
I think this is fine. One question, looking at the patch, I don't see how the field gets the center with which to set the angular momentum. I guess it assumes it is the origin, but that is not usually the case in our simulations, where the center of a rotating star might be at a non-zero location. I know it's beyond the scope of this patch, but we might want to warn users that it assumes a particular center?
On Thu, Dec 13, 2018 at 5:38 PM Nathan Goldbaum <nathan12343@gmail.com> wrote:
Hi all,
Bili put in a PR to reverse the orientation of yt's default angular momentum vector to be closer to what most people expect given conventions about right handed coordinate systems.
See https://github.com/yt-project/yt/pull/2043
I'm a little nervous about merging this since it might be disruptive. Does anyone see any issues with merging? People on master branch should know what they're in for?
If no one responds here or comments in the PR I'll probably merge the PR next week.
-Nathan _______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
-- Michael Zingale Associate Professor
Dept. of Physics & Astronomy • Stony Brook University • Stony Brook, NY 11794-3800 *phone*: 631-632-8225 *e-mail*: Michael.Zingale@stonybrook.edu *web*: http://www.astro.sunysb.edu/mzingale github: http://github.com/zingale
_______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
_______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
-- Michael Zingale Associate Professor Dept. of Physics & Astronomy • Stony Brook University • Stony Brook, NY 11794-3800 *phone*: 631-632-8225 *e-mail*: Michael.Zingale@stonybrook.edu *web*: http://www.astro.sunysb.edu/mzingale github: http://github.com/zingale
If you want to be super explicit about it, you could raise a warning for a release cycle or two On Thu, Dec 13, 2018, 18:11 Michael Zingale <michael.zingale@stonybrook.edu> wrote:
awesome! figured you folks had thought of it all
On Thu, Dec 13, 2018 at 6:09 PM Nathan Goldbaum <nathan12343@gmail.com> wrote:
That comes in via the position vectors, which are influenced by the “center” field parameter. It’s not explivcit in that definition because it’s handled elsewhere.
On Thu, Dec 13, 2018 at 4:48 PM Michael Zingale < michael.zingale@stonybrook.edu> wrote:
I think this is fine. One question, looking at the patch, I don't see how the field gets the center with which to set the angular momentum. I guess it assumes it is the origin, but that is not usually the case in our simulations, where the center of a rotating star might be at a non-zero location. I know it's beyond the scope of this patch, but we might want to warn users that it assumes a particular center?
On Thu, Dec 13, 2018 at 5:38 PM Nathan Goldbaum <nathan12343@gmail.com> wrote:
Hi all,
Bili put in a PR to reverse the orientation of yt's default angular momentum vector to be closer to what most people expect given conventions about right handed coordinate systems.
See https://github.com/yt-project/yt/pull/2043
I'm a little nervous about merging this since it might be disruptive. Does anyone see any issues with merging? People on master branch should know what they're in for?
If no one responds here or comments in the PR I'll probably merge the PR next week.
-Nathan _______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
-- Michael Zingale Associate Professor
Dept. of Physics & Astronomy • Stony Brook University • Stony Brook, NY 11794-3800 *phone*: 631-632-8225 *e-mail*: Michael.Zingale@stonybrook.edu *web*: http://www.astro.sunysb.edu/mzingale github: http://github.com/zingale
_______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
_______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
-- Michael Zingale Associate Professor
Dept. of Physics & Astronomy • Stony Brook University • Stony Brook, NY 11794-3800 *phone*: 631-632-8225 *e-mail*: Michael.Zingale@stonybrook.edu *web*: http://www.astro.sunysb.edu/mzingale github: http://github.com/zingale
_______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
-- Asst. Prof. Anthony Scopatz Nuclear Engineering Program Mechanical Engineering Dept. University of South Carolina scopatz@cec.sc.edu Cell: (512) 827-8239 Book a meeting with me at https://scopatz.youcanbook.me/ Open up an issue: https://github.com/scopatz/me/issues Check my calendar <https://www.google.com/calendar/embed?src=scopatz%40gmail.com>
Yeah, seems like the right thing to do. On Thu, Dec 13, 2018 at 4:37 PM Nathan Goldbaum <nathan12343@gmail.com> wrote:
Hi all,
Bili put in a PR to reverse the orientation of yt's default angular momentum vector to be closer to what most people expect given conventions about right handed coordinate systems.
See https://github.com/yt-project/yt/pull/2043
I'm a little nervous about merging this since it might be disruptive. Does anyone see any issues with merging? People on master branch should know what they're in for?
If no one responds here or comments in the PR I'll probably merge the PR next week.
-Nathan _______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org
participants (6)
-
Anthony Scopatz -
Cameron Hummels -
John ZuHone -
Matthew Turk -
Michael Zingale -
Nathan Goldbaum