Hello everyone! I hope you're all doing well! I've been working on converting yt's test suite from nose to pytest for a while now, and I'm excited to tell everyone that it's (provisionally) done! All of the answer tests have now been converted to use pytest. All of the tests (answer and unit) run with pytest. I've also gone through and compared the results generated by nose and by pytest and compared them to one another. For the most part, the results match. There are, however, a few discrepancies (hence the aforementioned provisional completion), and I'm investigating those now (if anyone wants to help, you're more than welcome!). Here are some links to more info if you're interested: PR (I haven't pushed to this in a bit, but I will soon): https://github.com/yt-project/yt/pull/2817 The code I used to do the nose-pytest comparisons: https://github.com/jcoughlin11/comp_repo The comparison failures: https://github.com/jcoughlin11/gists A handy table showing the status of each test set: https://hackmd.io/ScakP9ELTdCxnnNEmIChMQ Also, in addition to filling everyone in on the state of the PR, I figured now was as good a time as any to invite people who are interested to begin (again) the review process, since this is a rather large set of changes. If you have any questions or comments, let me know! Thanks, and I hope you all have a nice day! Sincerely, -Jared Coughlin
Hi Jared, This is great. Thanks for putting all of this together. What would you think about setting up a time for you to walk us through this, and we can try to do a stage one collective review? I'd like to try to tie this off, and if at *all* possible, verify that we either should or should *not* aim for this before 4.0, and the sooner we can make a collective decision the better, I think. -Matt On Tue, Feb 23, 2021 at 2:41 PM Coughlin, Jared W <jcoughl3@illinois.edu> wrote:
Hello everyone! I hope you're all doing well!
I've been working on converting yt's test suite from nose to pytest for a while now, and I'm excited to tell everyone that it's (provisionally) done! All of the answer tests have now been converted to use pytest. All of the tests (answer and unit) run with pytest. I've also gone through and compared the results generated by nose and by pytest and compared them to one another. For the most part, the results match. There are, however, a few discrepancies (hence the aforementioned provisional completion), and I'm investigating those now (if anyone wants to help, you're more than welcome!). Here are some links to more info if you're interested:
PR (I haven't pushed to this in a bit, but I will soon): https://github.com/yt-project/yt/pull/2817 The code I used to do the nose-pytest comparisons: https://github.com/jcoughlin11/comp_repo The comparison failures: https://github.com/jcoughlin11/gists A handy table showing the status of each test set: https://hackmd.io/ScakP9ELTdCxnnNEmIChMQ
Also, in addition to filling everyone in on the state of the PR, I figured now was as good a time as any to invite people who are interested to begin (again) the review process, since this is a rather large set of changes.
If you have any questions or comments, let me know! Thanks, and I hope you all have a nice day!
Sincerely, -Jared Coughlin _______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org https://mail.python.org/mailman3/lists/yt-dev.python.org/ Member address: matthewturk@gmail.com
Hey there, +1 to what Matt said Also I hate to be that guy, but didn’t we agree last meeting that large projects such as this one should be reviewed and approved one small chunk at a time and merged step by step into a dedicated feature branch that would eventually get merged into master ? I for one am ecstatic about finally dropping nose but I don’t think anyone has the energy to review such a massive work in one go and do it reliably. How about we start by discussing/reviewing the content of `conftest.py` and then start migrating tests themselves in reviewable-sized PR ? Clément On Wed, Feb 24, 2021 at 12:56, Matthew Turk <matthewturk@gmail.com> wrote:
Hi Jared,
This is great. Thanks for putting all of this together.
What would you think about setting up a time for you to walk us through this, and we can try to do a stage one collective review? I'd like to try to tie this off, and if at *all* possible, verify that we either should or should *not* aim for this before 4.0, and the sooner we can make a collective decision the better, I think.
-Matt
On Tue, Feb 23, 2021 at 2:41 PM Coughlin, Jared W <jcoughl3@illinois.edu> wrote:
Hello everyone! I hope you're all doing well!
I've been working on converting yt's test suite from nose to pytest for a while now, and I'm excited to tell everyone that it's (provisionally) done! All of the answer tests have now been converted to use pytest. All of the tests (answer and unit) run with pytest. I've also gone through and compared the results generated by nose and by pytest and compared them to one another. For the most part, the results match. There are, however, a few discrepancies (hence the aforementioned provisional completion), and I'm investigating those now (if anyone wants to help, you're more than welcome!). Here are some links to more info if you're interested:
PR (I haven't pushed to this in a bit, but I will soon): https://github.com/yt-project/yt/pull/2817 The code I used to do the nose-pytest comparisons: https://github.com/jcoughlin11/comp_repo
The comparison failures: https://github.com/jcoughlin11/gists A handy table showing the status of each test set: https://hackmd.io/ScakP9ELTdCxnnNEmIChMQ
Also, in addition to filling everyone in on the state of the PR, I figured now was as good a time as any to invite people who are interested to begin (again) the review process, since this is a rather large set of changes.
If you have any questions or comments, let me know! Thanks, and I hope you all have a nice day!
Sincerely, -Jared Coughlin _______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org https://mail.python.org/mailman3/lists/yt-dev.python.org/ Member address: matthewturk@gmail.com
Also I hate to be that guy, but didn’t we agree last meeting that large projects such as this one should be reviewed and approved one small chunk at a time and merged step by step into a dedicated feature branch that would eventually get merged into master ?
Yes, we did talk about this in the last yt team meeting. I do think this discussion was specifically focused around our future dask project, but I do think the pytest work would be more thoroughly reviewed if it were split up into smaller PRs. Early on in this project we had a discussion about splitting it up and I think somewhere there is a list of proposed feature PRs relevant to the project, but I can't find it at the moment. It might also not be relevant to this work in its current state anyways. Does anybody have any ideas on splitting it up (to supplement Clement's suggestion)? Since we have already merged at least one pytest PR into main I think we probably don't need a feature branch for it, but I support splitting it up into smaller PRs targeted towards main.
I for one am ecstatic about finally dropping nose but I don’t think anyone has the energy to review such a massive work in one go and do it reliably.
I am very glad about the pytest switch (and again, thank you Jared!!!) and I want it to be successful when we get it completely into main. Thorough reviews will definitely help it be a smooth and successful transition in the project. On Thu, Feb 25, 2021 at 1:46 PM Clément Robert via yt-dev <yt-dev@python.org> wrote:
Hey there, +1 to what Matt said
Also I hate to be that guy, but didn’t we agree last meeting that large projects such as this one should be reviewed and approved one small chunk at a time and merged step by step into a dedicated feature branch that would eventually get merged into master ? I for one am ecstatic about finally dropping nose but I don’t think anyone has the energy to review such a massive work in one go and do it reliably. How about we start by discussing/reviewing the content of `conftest.py` and then start migrating tests themselves in reviewable-sized PR ?
Clément
On Wed, Feb 24, 2021 at 12:56, Matthew Turk <matthewturk@gmail.com> wrote:
Hi Jared,
This is great. Thanks for putting all of this together.
What would you think about setting up a time for you to walk us through this, and we can try to do a stage one collective review? I'd like to try to tie this off, and if at *all* possible, verify that we either should or should *not* aim for this before 4.0, and the sooner we can make a collective decision the better, I think.
-Matt
On Tue, Feb 23, 2021 at 2:41 PM Coughlin, Jared W <jcoughl3@illinois.edu> wrote:
Hello everyone! I hope you're all doing well!
I've been working on converting yt's test suite from nose to pytest for a while now, and I'm excited to tell everyone that it's (provisionally) done! All of the answer tests have now been converted to use pytest. All of the tests (answer and unit) run with pytest. I've also gone through and compared the results generated by nose and by pytest and compared them to one another. For the most part, the results match. There are, however, a few discrepancies (hence the aforementioned provisional completion), and I'm investigating those now (if anyone wants to help, you're more than welcome!). Here are some links to more info if you're interested:
PR (I haven't pushed to this in a bit, but I will soon): https://github.com/yt-project/yt/pull/2817 The code I used to do the nose-pytest comparisons: https://github.com/jcoughlin11/comp_repo The comparison failures: https://github.com/jcoughlin11/gists A handy table showing the status of each test set: https://hackmd.io/ScakP9ELTdCxnnNEmIChMQ
Also, in addition to filling everyone in on the state of the PR, I figured now was as good a time as any to invite people who are interested to begin (again) the review process, since this is a rather large set of changes.
If you have any questions or comments, let me know! Thanks, and I hope you all have a nice day!
Sincerely, -Jared Coughlin _______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org https://mail.python.org/mailman3/lists/yt-dev.python.org/ Member address: matthewturk@gmail.com
_______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org https://mail.python.org/mailman3/lists/yt-dev.python.org/ Member address: madicken.munk@gmail.com
Btw, shouldn’t the associated YTEP be reviewed and merged first ? I intended to review it in the coming days. Another random note I need to write down before I forget : Using this plugin would help building confidence the redisgned framework as well as the tests themselves https://pypi.org/project/pytest-randomly/ Cheers Clément On Thu, Feb 25, 2021 at 22:55, Madicken Munk <madicken.munk@gmail.com> wrote:
Also I hate to be that guy, but didn’t we agree last meeting that large projects such as this one should be reviewed and approved one small chunk at a time and merged step by step into a dedicated feature branch that would eventually get merged into master ?
Yes, we did talk about this in the last yt team meeting. I do think this discussion was specifically focused around our future dask project, but I do think the pytest work would be more thoroughly reviewed if it were split up into smaller PRs. Early on in this project we had a discussion about splitting it up and I think somewhere there is a list of proposed feature PRs relevant to the project, but I can't find it at the moment. It might also not be relevant to this work in its current state anyways. Does anybody have any ideas on splitting it up (to supplement Clement's suggestion)?
Since we have already merged at least one pytest PR into main I think we probably don't need a feature branch for it, but I support splitting it up into smaller PRs targeted towards main.
I for one am ecstatic about finally dropping nose but I don’t think anyone has the energy to review such a massive work in one go and do it reliably.
I am very glad about the pytest switch (and again, thank you Jared!!!) and I want it to be successful when we get it completely into main. Thorough reviews will definitely help it be a smooth and successful transition in the project.
On Thu, Feb 25, 2021 at 1:46 PM Clément Robert via yt-dev <yt-dev@python.org> wrote:
Hey there, +1 to what Matt said
Also I hate to be that guy, but didn’t we agree last meeting that large projects such as this one should be reviewed and approved one small chunk at a time and merged step by step into a dedicated feature branch that would eventually get merged into master ? I for one am ecstatic about finally dropping nose but I don’t think anyone has the energy to review such a massive work in one go and do it reliably. How about we start by discussing/reviewing the content of `conftest.py` and then start migrating tests themselves in reviewable-sized PR ?
Clément
On Wed, Feb 24, 2021 at 12:56, Matthew Turk <matthewturk@gmail.com> wrote:
Hi Jared,
This is great. Thanks for putting all of this together.
What would you think about setting up a time for you to walk us through this, and we can try to do a stage one collective review? I'd like to try to tie this off, and if at *all* possible, verify that we either should or should *not* aim for this before 4.0, and the sooner we can make a collective decision the better, I think.
-Matt
On Tue, Feb 23, 2021 at 2:41 PM Coughlin, Jared W <jcoughl3@illinois.edu> wrote:
Hello everyone! I hope you're all doing well!
I've been working on converting yt's test suite from nose to pytest for a while now, and I'm excited to tell everyone that it's (provisionally) done! All of the answer tests have now been converted to use pytest. All of the tests (answer and unit) run with pytest. I've also gone through and compared the results generated by nose and by pytest and compared them to one another. For the most part, the results match. There are, however, a few discrepancies (hence the aforementioned provisional completion), and I'm investigating those now (if anyone wants to help, you're more than welcome!). Here are some links to more info if you're interested:
PR (I haven't pushed to this in a bit, but I will soon): https://github.com/yt-project/yt/pull/2817 The code I used to do the nose-pytest comparisons: https://github.com/jcoughlin11/comp_repo
The comparison failures: https://github.com/jcoughlin11/gists A handy table showing the status of each test set: https://hackmd.io/ScakP9ELTdCxnnNEmIChMQ
Also, in addition to filling everyone in on the state of the PR, I figured now was as good a time as any to invite people who are interested to begin (again) the review process, since this is a rather large set of changes.
If you have any questions or comments, let me know! Thanks, and I hope you all have a nice day!
Sincerely, -Jared Coughlin _______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org https://mail.python.org/mailman3/lists/yt-dev.python.org/ Member address: matthewturk@gmail.com
_______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org https://mail.python.org/mailman3/lists/yt-dev.python.org/ Member address: madicken.munk@gmail.com
Btw, shouldn’t the associated YTEP be reviewed and merged first ? I intended to review it in the coming days.
This is a fantastic point. I went back to our governance documents and couldn't find any decisions about our YTEP process, so I think it should be improved. We do say that before large new features are merged, they should have an accompanying YTEP, but we don't say how long it is open, when it is merged, or if merging the YTEP should happen at a specific point in the dev cycle. I suspect we all have differing views to each of these, so I think we need to update the governance. I opened an issue about it here: https://github.com/yt-project/governance/issues/3 Please weigh in on the issue so we can come to a consensus about YTEP merging! On Fri, Feb 26, 2021 at 1:19 AM Clément Robert via yt-dev <yt-dev@python.org> wrote:
Btw, shouldn’t the associated YTEP be reviewed and merged first ? I intended to review it in the coming days.
Another random note I need to write down before I forget : Using this plugin would help building confidence the redisgned framework as well as the tests themselves https://pypi.org/project/pytest-randomly/
Cheers Clément
On Thu, Feb 25, 2021 at 22:55, Madicken Munk <madicken.munk@gmail.com> wrote:
Also I hate to be that guy, but didn’t we agree last meeting that large projects such as this one should be reviewed and approved one small chunk at a time and merged step by step into a dedicated feature branch that would eventually get merged into master ?
Yes, we did talk about this in the last yt team meeting. I do think this discussion was specifically focused around our future dask project, but I do think the pytest work would be more thoroughly reviewed if it were split up into smaller PRs. Early on in this project we had a discussion about splitting it up and I think somewhere there is a list of proposed feature PRs relevant to the project, but I can't find it at the moment. It might also not be relevant to this work in its current state anyways. Does anybody have any ideas on splitting it up (to supplement Clement's suggestion)?
Since we have already merged at least one pytest PR into main I think we probably don't need a feature branch for it, but I support splitting it up into smaller PRs targeted towards main.
I for one am ecstatic about finally dropping nose but I don’t think anyone has the energy to review such a massive work in one go and do it reliably.
I am very glad about the pytest switch (and again, thank you Jared!!!) and I want it to be successful when we get it completely into main. Thorough reviews will definitely help it be a smooth and successful transition in the project.
On Thu, Feb 25, 2021 at 1:46 PM Clément Robert via yt-dev < yt-dev@python.org> wrote:
Hey there, +1 to what Matt said
Also I hate to be that guy, but didn’t we agree last meeting that large projects such as this one should be reviewed and approved one small chunk at a time and merged step by step into a dedicated feature branch that would eventually get merged into master ? I for one am ecstatic about finally dropping nose but I don’t think anyone has the energy to review such a massive work in one go and do it reliably. How about we start by discussing/reviewing the content of `conftest.py` and then start migrating tests themselves in reviewable-sized PR ?
Clément
On Wed, Feb 24, 2021 at 12:56, Matthew Turk <matthewturk@gmail.com> wrote:
Hi Jared,
This is great. Thanks for putting all of this together.
What would you think about setting up a time for you to walk us through this, and we can try to do a stage one collective review? I'd like to try to tie this off, and if at *all* possible, verify that we either should or should *not* aim for this before 4.0, and the sooner we can make a collective decision the better, I think.
-Matt
On Tue, Feb 23, 2021 at 2:41 PM Coughlin, Jared W <jcoughl3@illinois.edu> wrote:
Hello everyone! I hope you're all doing well!
I've been working on converting yt's test suite from nose to pytest for a while now, and I'm excited to tell everyone that it's (provisionally) done! All of the answer tests have now been converted to use pytest. All of the tests (answer and unit) run with pytest. I've also gone through and compared the results generated by nose and by pytest and compared them to one another. For the most part, the results match. There are, however, a few discrepancies (hence the aforementioned provisional completion), and I'm investigating those now (if anyone wants to help, you're more than welcome!). Here are some links to more info if you're interested:
PR (I haven't pushed to this in a bit, but I will soon): https://github.com/yt-project/yt/pull/2817 The code I used to do the nose-pytest comparisons: https://github.com/jcoughlin11/comp_repo The comparison failures: https://github.com/jcoughlin11/gists A handy table showing the status of each test set: https://hackmd.io/ScakP9ELTdCxnnNEmIChMQ
Also, in addition to filling everyone in on the state of the PR, I figured now was as good a time as any to invite people who are interested to begin (again) the review process, since this is a rather large set of changes.
If you have any questions or comments, let me know! Thanks, and I hope you all have a nice day!
Sincerely, -Jared Coughlin _______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org https://mail.python.org/mailman3/lists/yt-dev.python.org/ Member address: matthewturk@gmail.com
_______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org https://mail.python.org/mailman3/lists/yt-dev.python.org/ Member address: madicken.munk@gmail.com
_______________________________________________ yt-dev mailing list -- yt-dev@python.org To unsubscribe send an email to yt-dev-leave@python.org https://mail.python.org/mailman3/lists/yt-dev.python.org/ Member address: madicken.munk@gmail.com
participants (4)
-
Clément Robert -
Coughlin, Jared W -
Madicken Munk -
Matthew Turk