[Mailman-Developers] "search for member with RE" box at top instead of bottom

[Barry A. Warsaw]

>>>>> "DM" == Dan Mick <dmick@utopia.West.Sun.COM> writes:

    DM> the point is, with a properly working, easy-to-reach search, I
    DM> *never* use the list.  Ever.

That's a good point.

    DM> But I wasn't necessarily suggesting a global change, just that
    DM> others here who have expressed dislike of the new alphabetic
    DM> interface might be interested; if you were, fine, but...

    DM> If there were a less-visually-clunky tweak to include it at
    DM> the top of the list, I think it would be better yet.  I'll
    DM> hack around a bit (it seemed like a patch job to me visually
    DM> too).

See what you think about this (against cvs)...
-Barry

-------------------- snip snip --------------------
Index: admin.py
===================================================================
RCS file: /cvsroot/mailman/mailman/Mailman/Cgi/admin.py,v
retrieving revision 2.66
diff -u -r2.66 admin.py
--- admin.py	25 Mar 2002 23:48:12 -0000	2.66
+++ admin.py	28 Mar 2002 05:47:51 -0000
@@ -502,18 +502,6 @@
             table.AddRow([Center(Header(2, _('Additional Member Tasks')))])
             table.AddCellInfo(table.GetCurrentRowIndex(), 0, colspan=2,
                               bgcolor=mm_cfg.WEB_HEADER_COLOR)
-            table.AddRow([_(
-                '''<li>Find members by
-                <a href="http://www.python.org/doc/current/lib/re-syntax.html"
-                >Python regular expression</a> (<em>regexp</em>)<br>''')])
-            table.AddCellInfo(table.GetCurrentRowIndex(), 0, colspan=2)
-            table.AddRow([Label(_('Regexp:')),
-                          TextBox('findmember',
-                                  value=cgidata.getvalue('findmember', ''),
-                                  size='75%')])
-            table.AddRow([Center(SubmitButton('findmember_btn',
-                                              _('Search...')))])
-            table.AddCellInfo(table.GetCurrentRowIndex(), 0, colspan=2)
             # Add a blank separator row
             table.AddRow(['&nbsp;', '&nbsp;'])
             # Add a section to set the moderation bit for all members
@@ -789,6 +777,16 @@
     header.AddCellInfo(header.GetCurrentRowIndex(), 0, colspan=2,
                        bgcolor=mm_cfg.WEB_HEADER_COLOR)
     container.AddItem(header)
+    # Add a "search for member" button
+    table = Table(width='100%')
+    link = Link('http://www.python.org/doc/current/lib/re-syntax.html',
+                _('regular expression')).Format()
+    table.AddRow([Label(_('Find member by %(link)s:')),
+                  TextBox('findmember',
+                          value=cgidata.getvalue('findmember', '')),
+                  SubmitButton('findmember_btn', _('Search...'))])
+    container.AddItem(table)
+    container.AddItem('<hr><p>')
     usertable = Table(width="90%", border='2')
     # If there are more members than allowed by chunksize, then we split the
     # membership up alphabetically.  Otherwise just display them all.