[Python-Dev] NOARGS_NULL

Thomas Wouters thomas at python.org
Sat Feb 24 01:27:24 CET 2007


My only objection (which is a minor one) is with the 'NOARGS_NULL' name.
Caps don't fit the normal style rules, and 'noargs_null' doesn't make much
sense to me. 'unused' strikes me as a clearer name (or 'noargs_unused' or
'args_unused' or such.) It should be fine to fix this in 2.5 as well (as
long as arguments previously ignored don't suddenly raise exceptions, but it
doesn't sound like that's happening at all.)

On 2/18/07, "Martin v. Löwis" <martin at v.loewis.de> wrote:
>
> Patch #1648268 corrects a huge load of errors in Python wrt.
> incorrect function pointers (i.e. functions called with a
> different signature then declared, through pointers).
> The rationale for this patch is that the submitter apparently
> has a platform where Python crashes in the face of these errors.
>
> I believe the patch is correct, and would like to apply it.
>
> The patch also renames many function arguments: parameters
> in a METH_NOARGS function get consistently named NOARGS_NULL
> (currently often called 'unused' or 'noargs'); the second parameter
> to getters gets consistently named 'closure' (it's called
> closure in many places already, and 'unused' in others).
>
> I would also apply this part of the change, and both to
> the trunk and Python 2.5. Objections?
>
> Regards,
> Martin
> _______________________________________________
> Python-Dev mailing list
> Python-Dev at python.org
> http://mail.python.org/mailman/listinfo/python-dev
> Unsubscribe:
> http://mail.python.org/mailman/options/python-dev/thomas%40python.org
>



-- 
Thomas Wouters <thomas at python.org>

Hi! I'm a .signature virus! copy me into your .signature file to help me
spread!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.python.org/pipermail/python-dev/attachments/20070223/44ad2f43/attachment.htm 


More information about the Python-Dev mailing list