[scikit-learn] Code review

[Joel Nothman]

I think perhaps that FAQ should be updated to say "nag if needed"!

Apologies for that delay, @olologin. Yes, it would be good if we had a
better way of organising reviewing priorities, but between github's feature
set and the distributed nature of the core dev team, we land up relying on
chance, or a developer being interested in a particular feature. Again,
nagging helps.

On 21 June 2016 at 14:17, Nelson Liu <nfliu at uw.edu> wrote:

> The review process has always been quite slow; the only thing you can do
> is ping and try to fix things on your side as quickly as possible. There
> are a lot of PRs in development at any one time, and it's difficult for the
> reviewers (let alone the contributors, as you mentioned) to keep track of
> everything that's being done. If you find that no one has looked at your
> code in awhile, I'd ping some of the core contributors. Also see:
> http://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention
>
> On Mon, Jun 20, 2016 at 9:10 PM olologin <olologin at gmail.com> wrote:
>
>> Hi guys, I know scikit-learn may not be your main project, and you all
>> are very busy at work so you don't have free time to review all pull
>> requests, I understand it.
>>
>> Is there something project leaders can do to speed-up review process?
>> Because I have bunch of pull requests which I made 5-7 months ago, and
>> they are relatively useful :), but they wasn't reviewed. Some of them
>> are quite simple for review (~10 lines in python), and still have only 1
>> vote. Maybe it's possible to increase size of team which have permission
>> to review? Or all I can do is just wait? :)
>>
>> I'm writing this letter because yesterday one guy complained about this
>> in one of my PR's (I forgot about that PR by the time)
>>
>> https://github.com/scikit-learn/scikit-learn/pull/6116#issuecomment-227044224
>> .
>> _______________________________________________
>> scikit-learn mailing list
>> scikit-learn at python.org
>> https://mail.python.org/mailman/listinfo/scikit-learn
>>
>
> _______________________________________________
> scikit-learn mailing list
> scikit-learn at python.org
> https://mail.python.org/mailman/listinfo/scikit-learn
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/scikit-learn/attachments/20160621/9c4f8181/attachment.html>