[scikit-learn] Contributing ST-DBSCAN to the clustering module

[Andreas Mueller]

Hi.

It looks like the paper proposes two unrelated improvements, right?
We don't really include algorithms that are specific for time-series 
data or spatio-temporal data.
How does the other improvement compare against hdbscan?

There is many many different clustering algorithms out there, and I 
don't think we want to implement
all of them.
It's not entirely clear to me when this algorithm improves over what we 
have already.

Btw, adding a new algorithm to scikit-learn is probably not a good idea 
for a first contribution, see
http://scikit-learn.org/dev/faq.html#how-can-i-contribute-to-scikit-learn

Andy



On 04/08/2018 09:21 AM, Manmohit Rekhi wrote:
> Hi Everyone,
>
> This is my first open source contribution and I am really excited 
> about scikit-learn
> I was reading a paper on ST-DBSCAN and found that there are no good 
> implementations
> of it online.
>
> Thought this could a good opportunity to contribute. Had a few 
> questions before I started
> 1) Is there any problem with this algorithm being in scikit-learn?
> 2) Is there someone already working on this algorithms?
> 3) Any things i need to take care of while contributing(like code 
> optimisation/libraries to be used)?
>
> link to the paper: 
> https://www.sciencedirect.com/science/article/pii/S0169023X06000218 
> <https://www.sciencedirect.com/science/article/pii/S0169023X06000218>
>
> Thanks,
> Manmohit
>
>
>
>
> _______________________________________________
> scikit-learn mailing list
> scikit-learn at python.org
> https://mail.python.org/mailman/listinfo/scikit-learn

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/scikit-learn/attachments/20180410/35fd6870/attachment.html>