Pull Request bpo-1812
Can someone please review the subject pull request? Pull request link here: https://github.com/python/cpython/pull/17385 Issue tracker link here: https://bugs.python.org/issue1812 Thank you very much! Peter Donis pdonis@peterdonis.net
For folks who wouldn't click on the links, the title of the issue is "doctest _load_testfile function -- newline handling seems incorrect", it was filed in 2008 and has many comments, plus diffs dating back to 2008. The Pull Request title is "Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method", it looks relatively straightforward and thorough. Presumably it's based on the diffs from the issue. The author of the issue and PR are the same as the OP above. This will be a doozie for whoever wants to volunteer! On Tue, Feb 11, 2020 at 5:22 PM Peter Donis <pdonis@peterdonis.net> wrote:
Can someone please review the subject pull request?
Pull request link here:
https://github.com/python/cpython/pull/17385
Issue tracker link here:
https://bugs.python.org/issue1812
Thank you very much!
Peter Donis pdonis@peterdonis.net _______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-leave@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/32BFCXWK... Code of Conduct: http://python.org/psf/codeofconduct/
-- --Guido van Rossum (python.org/~guido) *Pronouns: he/him **(why is my pronoun here?)* <http://feministing.com/2015/02/03/how-using-they-as-a-singular-pronoun-can-c...>
On Tue, Feb 11, 2020 at 9:59 PM Guido van Rossum <guido@python.org> wrote:
The Pull Request title is "Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method", it looks relatively straightforward and thorough.
I've submitted a review; the actual code change is very simple and straightforward, but it would be good for someone with more experience with `importlib` (specifically setting up or mocking out a custom `__loader__.get_data`) to take a look at the tests and make a better suggestion than mine about how to make sure we're cleaning up properly. -- Zach
Thank you, thank you! Hopefully we can pull this one over the finish line, and it won't have to linger for another decade. :-) On Tue, Feb 11, 2020 at 8:42 PM Zachary Ware <zach@python.org> wrote:
On Tue, Feb 11, 2020 at 9:59 PM Guido van Rossum <guido@python.org> wrote:
The Pull Request title is "Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method", it looks relatively straightforward and thorough.
I've submitted a review; the actual code change is very simple and straightforward, but it would be good for someone with more experience with `importlib` (specifically setting up or mocking out a custom `__loader__.get_data`) to take a look at the tests and make a better suggestion than mine about how to make sure we're cleaning up properly.
-- Zach _______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-leave@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/DSKFDCYG... Code of Conduct: http://python.org/psf/codeofconduct/
-- --Guido van Rossum (python.org/~guido) *Pronouns: he/him **(why is my pronoun here?)* <http://feministing.com/2015/02/03/how-using-they-as-a-singular-pronoun-can-c...>
Is there any update on this? I have put the setup/teardown code in a context manager as Zach recommended. The setup/teardown code covers everything that could possibly be mutated by the test. It's probably not the most elegant way to do it, but all of the tests pass which indicates that it works. Github shows all checks passed and no conflicts with the base branch. I'm not sure what more would be needed at this point to make this ready to merge.
On Fri, Mar 13, 2020 at 9:36 AM Peter Donis <peterdonis@alum.mit.edu> wrote:
Is there any update on this? I have put the setup/teardown code in a context manager as Zach recommended. The setup/teardown code covers everything that could possibly be mutated by the test. It's probably not the most elegant way to do it, but all of the tests pass which indicates that it works. Github shows all checks passed and no conflicts with the base branch. I'm not sure what more would be needed at this point to make this ready to merge.
Sorry, I've been meaning to get back to this but have been short on time :(. I'd still like for someone with better knowledge of import (and mocking thereof) to take a look, but if nobody steps forward in the next few days I'll just merge it anyway :)
participants (4)
-
Guido van Rossum -
Peter Donis -
Peter Donis -
Zachary Ware