Mailman 3 July 2004 - pypy-dev

Re: [pypy-dev] die cpythonobject, die!
by Michael Hudson 14 Jul '04

14 Jul '04

Cc:ing pypy-dev back in, assuming it's omission was just a slip... (also why I'm not snipping the quoted material). Richard Emslie <rxe(a)ukshells.co.uk> writes: > Hi Michael, > > On Wed, 14 Jul 2004, Michael Hudson wrote: > >> This surprisingly brief patch removes all uses of W_CPythonObject >> (though not all uses of W_BuiltinFunctionObject), by using the >> 'automatically faking non re-implementations' technique I've talked >> about before. >> >> > > > Second guessing here, but I reckon that within > > DescrOperation.get_and_call_args() > > there is a comment "special-case Functions to avoid infinite > recursion" that is the start of the problems. Bingo! Thanks. > The above line instead of - > > if type(descr) is Function: > > could be replace with (I think 80%) > > if hasattr(descr, "call_args"): > > and then have a special case for faking SlotWrapperType s called > fake_function() which looks something like > > > def fake_function(space, cpy_func): > W_FakeFunction = fake_type(space, cpy_func) > W_FakeFunction.__name__ = 'W_FakeFunction(%s)'%(cpy_func.__name__) > > def call_args(self, args): > try: > unwrappedargs = [space.unwrap(w_arg) for w_arg in args.args_w] > unwrappedkwds = dict([(key, space.unwrap(w_value)) > for key, w_value in args.kwds_w.items()]) > except UnwrapError, e: > raise UnwrapError('calling %s: %s' % (cpy_func, e)) > try: > assert callable(self.val), self.val > result = apply(self.val, unwrappedargs, unwrappedkwds) > except: > wrap_exception(space) > return space.wrap(result) > setattr(W_FakeFunction, "call_args", call_args) > return W_FakeFunction > > > Don't know - it's very much guess work. Hope that helps - it works > for me and might at least give you some idea how to solve. Well, I think that could work but I'd prefer a solution with less special casing. How does CPython avoid the same problem? Cheers, mwh -- -Dr. Olin Shivers, Ph.D., Cranberry-Melon School of Cucumber Science -- seen in comp.lang.scheme

2 3

Running CPython unittests on PyPy
by Seo Sanghyeon 14 Jul '04

14 Jul '04

Today I could run CPython unittests on top of PyPy. test_call is passed. :-) Some problems: 1) For some reason, test_support complains if not imported from test package. Error message is: ImportError: test_support must be imported from the test package 2) PyPy's sys.path includes appspace/ and interpreter/. And they have their own test/ subdirectory, thus breaking import from test package. 3) PyPy methods have no __doc__. CPython methods always have __doc__, even if it is None. This confuses unittest: try: self.__testMethodName = methodName testMethod = getattr(self, methodName) self.__testMethodDoc = testMethod.__doc__ except AttributeError: raise ValueError # ... testMethod.__doc__ never raises AttributeError in CPython. So this error is wrongly reported as missing test method, not test method docstring. I just wanted to run CPython unittests on PyPy, without fixing these glitches. Here are workarounds: 1) mv appspace/test appspace/xtest 2) mv interpreter/test interpreter/xtest 3) cp /usr/lib/python2.3/unittest.py appspace 4) Patch unittest.py: --- unittest.py.orig 2004-07-14 21:19:19.000000000 +0900 +++ unittest.py 2004-07-14 21:19:29.000000000 +0900 @@ -169,7 +169,7 @@ try: self.__testMethodName = methodName testMethod = getattr(self, methodName) - self.__testMethodDoc = testMethod.__doc__ + self.__testMethodDoc = None # testMethod.__doc__ except AttributeError: raise ValueError, "no such test method in %s: %s" % \ (self.__class__, methodName) 5) Copy CPython Lib/test to work directory. 6) pypy test/test_call.py You will see "Ran 27 tests in 22.790s". CPython reports "Ran 27 tests in 0.008s". That gives 3500x slow performance. Well, that was expected. Happy hacking,

2 1

die cpythonobject, die!
by Michael Hudson 14 Jul '04

14 Jul '04

This surprisingly brief patch removes all uses of W_CPythonObject (though not all uses of W_BuiltinFunctionObject), by using the 'automatically faking non re-implementations' technique I've talked about before. Trying to finish the job -- i.e. removing use of W_BuiltinFunctionObject wrappers for slot wrappers -- gave me infinite recursions and a headache. Thoughts? Cheers, mwh -- Good? Bad? Strap him into the IETF-approved witch-dunking apparatus immediately! -- NTK now, 21/07/2000

1 0

Unbound method must be called with instance as first argument
by Seo Sanghyeon 13 Jul '04

13 Jul '04

Consider following testcase: class C: pass class D(C): pass def m(self): return self C.m = m D.m = C.m print C().m() print D().m() CPython runs it okay, but PyPy baffles and raises TypeError, with message ${SUBJ}. Changing 5th line to "D.m = m" and it runs fine. The point is, "D.m = C.m" should transform C.m from unbound method of class C to unbound method of class D... This breaks mailbox.py, among other things. Read how PortableUnixMailbox is implemented there. Regards,

4 6

Squeak is written in itself
by Martijn Faassen 13 Jul '04

13 Jul '04

Hi there, I just ran into this. Quite possibly you are all fully aware of this already, but sounds similar to PyPy in some of its approaches. I haven't read the full article yet: http://www.cosc.canterbury.ac.nz/~wolfgang/cosc205/squeak.html Has a horribly hard to read background image, ugh.. Regards, Martijn

2 1

New style classes
by Richard Emslie 12 Jul '04

12 Jul '04

Hi PyPy ers, I was wondering why we use old style classes everywhere in the pypy code base - esp since pypy only supports new style classes (!). Would anyone have a huge objection to making ObjSpace a new style class? (Needed for the trace object space) Also in CPython you can class A(object): pass class B(object): pass a = A() a.__class__ = B but in PyPy we get "AttributeError: read-only attribute". Is this just a TODO, or is it a feature? ;-) Cheers, Richard

3 2

Re: [pypy-dev] src/pypy/module/test/test_sysmodule.py
by Laura Creighton 06 Jul '04

06 Jul '04

In a message of Tue, 06 Jul 2004 09:52:50 +0200, Christian Tismer writes: >Laura Creighton wrote: > >> def test_sys_in_modules(self): >> import sys >> modules = sys.modules >> self.failUnless('sys' in modules, "An entry for sys " >> "is not in sys.modules.") > >I see the problem, although it's perfectly fine Python. > >... > >> My poor program converts them to: >> >> >> def test_sys_in_modules(self): >> import sys >> modules = sys.modules >> assert 'sys' in modules, "An entry for sys " >> "is not in sys.modules." >> >> I propose we consider src/pypy/module/test/test_sysmodule.py broken, an >d we fix that >> file, rather than make my program wrap them in parentheses. >> >> Any objections? > >Maybe the test is inconvenient to parse, but by no means >broken. The simplest fix would probably be to emit a "\" >continuation at the line end, and everything is fine. > >ciao - chris Astonishing the legal python usage I had never known about, and, as far as I know, I have never seen. I've always typed the '+' sign in the above .... :-) Ok, I think I will be enclosing them in parens rather than pasting on backslashes, but this can be done.... Laura, bemused

1 0

Re: [pypy-dev] src/pypy/translator/test and src/pypy/tool/test
by Laura Creighton 06 Jul '04

06 Jul '04

In a message of Tue, 06 Jul 2004 09:59:11 +0200, holger krekel writes: >[Laura Creighton Tue, Jul 06, 2004 at 05:39:20AM +0200] >> Where is the std/path that tool/udir.py wants? The only std I can find > is >> pypy/objspace/std/ but there is not file named path.py there ... > >well, src/std/path/ should exist and be a directory. >you are not in some branch ("svn info" will tell), right? >And this is an unmodified pypy-src tree? Sorry for asking >these questions but as it works apparently for everybody >else i am kind of out of luck of guessing anything more sensible. > >cheers, > > holger I didn't have an src/std/path. And when I did svn up, it didn't make one. It turned out deep in Pyrex I had a working copy locked, which made the checkout stop, but silently. It only started complaining about the locks when I removed the Pyrex dir -- all of them actually -- and made it regenerate afresh. Then after svn cleanup, down came std, and everything started working again. Sorry for the confusion --- now if I can duplicate this state to send off to the svn people. Because I really thought I had everything, and it was the import that was wrong .... Laura

2 1

Re: [pypy-dev] src/pypy/translator/test and src/pypy/tool/test
by Laura Creighton 06 Jul '04

06 Jul '04

In a message of Tue, 06 Jul 2004 01:01:38 +0200, holger krekel writes: >[Laura Creighton Tue, Jul 06, 2004 at 12:54:23AM +0200] >> In a message of Tue, 06 Jul 2004 00:00:22 +0200, holger krekel writes: >> >[Laura Creighton Mon, Jul 05, 2004 at 11:33:52PM +0200] >> >> These tests are failing because they are looking for std/path >> >> >> >> i.e. >> >> >> >> Traceback (most recent call last): >> >> File "test_sourcegen.py", line 4, in ? >> >> from pypy.tool.udir import udir >> >> File "/home/lac/src/pypy/trunk/src/pypy/tool/udir.py", line 3, in >? >> >> from std.path import local >> >> ImportError: No module named std.path >> >> >> >> what should they be saying instead? >> > >> >i am not sure i can follow. Do you mean >> > >> > python test_sourcegen.py >> > >> >is failing for you? If not, please post the cmdline you are using >> >and if you working on a plain trunk or modified version ... >> >> Yes, it is failing. > >in an unmodified trunk? svn-up'ped at src/ (not just within pypy/)? svn'd all the way up a trunk, even. Try running tool/udir.py and tool/newtest.py yourself ... doesn't it fail for you? Where is the std/path that tool/udir.py wants? The only std I can find is pypy/objspace/std/ but there is not file named path.py there ... Laura

2 1

src/pypy/module/test/test_sysmodule.py
by Laura Creighton 06 Jul '04

06 Jul '04

Over here we have somebody who likes to write unittests like this: def test_sys_in_modules(self): import sys modules = sys.modules self.failUnless('sys' in modules, "An entry for sys " "is not in sys.modules.") sys2 = sys.modules['sys'] self.failUnless(sys is sys2, "import sys is not sys.modules[sys].") def test_builtin_in_modules(self): import sys modules = sys.modules self.failUnless('__builtin__' in modules, "An entry for __builtin__ " "is not in sys.modules.") import __builtin__ builtin2 = sys.modules['__builtin__'] self.failUnless(__builtin__ is builtin2, "import __builtin__ " "is not sys.modules[__builtin__].") see the fail messages that are two strings, not separated by anything, on 2 separate lines. My poor program converts them to: def test_sys_in_modules(self): import sys modules = sys.modules assert 'sys' in modules, "An entry for sys " "is not in sys.modules." I propose we consider src/pypy/module/test/test_sysmodule.py broken, and we fix that file, rather than make my program wrap them in parentheses. Any objections? Laura

2 1