Mailman 3 December 2003 - Mailman-coders

[ mailman-Bugs-851970 ] crash running archiver: StringIO: expected read buffer, list
by SourceForge.net 01 Dec '03

01 Dec '03

Bugs item #851970, was opened at 2003-12-01 20:32 Message generated for change (Settings changed) made by mbp You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=851970&group_i… Category: Pipermail Group: 2.1 (stable) >Status: Closed >Resolution: Invalid Priority: 5 Submitted By: Martin Pool (mbp) Assigned to: Nobody/Anonymous (nobody) Summary: crash running archiver: StringIO: expected read buffer, list Initial Comment: Hi, I'm trying to import some messages into an archive using the arch command in 2.1.3. This mostly works, except that a few messages that seem otherwise well-formed are causing an exception: mailman@dp:private$ python -i /usr/local/mailman/bin/arch distcc /tmp/crash2 #00000 <1066876904.6827.10.camel(a)lisa.thedoh.com> Pickling archive state into /var/mailman/archives/private/distcc/pipermail.pck Traceback (most recent call last): File "/usr/local/mailman/bin/arch", line 187, in ? main() File "/usr/local/mailman/bin/arch", line 175, in main archiver.processUnixMailbox(fp, start, end) File "/usr/local/mailman/Mailman/Archiver/pipermail.py", line 558, in processUnixMailbox a = self._makeArticle(m, self.sequence) File "/usr/local/mailman/Mailman/Archiver/HyperArch.py", line 626, in _makeArticle mlist=self.maillist) File "/usr/local/mailman/Mailman/Archiver/HyperArch.py", line 255, in __init__ self.__super_init(message, sequence, keepHeaders) File "/usr/local/mailman/Mailman/Archiver/pipermail.py", line 216, in __init__ s = StringIO(message.get_payload()) TypeError: expected read buffer, list found The problem seems to be that cStringIO (unlike plain StringIO) cannot take a list as a read buffer. It will only accept a string. I'm using Python 2.2.2 (#1, Jan 30 2003, 21:26:22) [GCC 2.96 20000731 (Red Hat Linux 7.3 2.96-112)] on linux2 But cStringIO's behaviour seems to be the same even on Python 2.3.2. The doc string for pythonlib/email/Message.py's get_payload() function says """Return a reference to the payload. The payload will either be a list object or a string. If you mutate the list object, you modify the message's payload in place. Optional i returns that index into the payload. I think this has to be a bug, because if it returns a list it will certainly break cStringIO. ---------------------------------------------------------------------- >Comment By: Martin Pool (mbp) Date: 2003-12-01 21:13 Message: Logged In: YES user_id=521 My mistake, turning the Scrubber back on fixed it. ---------------------------------------------------------------------- Comment By: Martin Pool (mbp) Date: 2003-12-01 20:51 Message: Logged In: YES user_id=521 I think this was my error. We had ARCHIVE_SCRUBBER=0 while we were using MHonArc, but I see that has to be left on the default for Pipermail to work. ---------------------------------------------------------------------- Comment By: Martin Pool (mbp) Date: 2003-12-01 20:43 Message: Logged In: YES user_id=521 Not only is get_payload() returning a list, but it's not even a list of strings. So it's no wonder that StringIO is having trouble. For the sample message I quoted, get_payload() returns a 2-element list where the elements are instances of Mailman.Message.Message. I wonder if I have an old/buggy pythonlib/email library for some reason, or if some old cruft on redhat is causing the problem? All of the relevant code seems reasonably close to python 2.3. And anyhow, the mailman docs say that only python 2.1 is required. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=851970&group_i…

1 0

[ mailman-Bugs-851970 ] crash running archiver: StringIO: expected read buffer, list
by SourceForge.net 01 Dec '03

01 Dec '03

Bugs item #851970, was opened at 2003-12-01 20:32 Message generated for change (Comment added) made by mbp You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=851970&group_i… Category: Pipermail Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Martin Pool (mbp) Assigned to: Nobody/Anonymous (nobody) Summary: crash running archiver: StringIO: expected read buffer, list Initial Comment: Hi, I'm trying to import some messages into an archive using the arch command in 2.1.3. This mostly works, except that a few messages that seem otherwise well-formed are causing an exception: mailman@dp:private$ python -i /usr/local/mailman/bin/arch distcc /tmp/crash2 #00000 <1066876904.6827.10.camel(a)lisa.thedoh.com> Pickling archive state into /var/mailman/archives/private/distcc/pipermail.pck Traceback (most recent call last): File "/usr/local/mailman/bin/arch", line 187, in ? main() File "/usr/local/mailman/bin/arch", line 175, in main archiver.processUnixMailbox(fp, start, end) File "/usr/local/mailman/Mailman/Archiver/pipermail.py", line 558, in processUnixMailbox a = self._makeArticle(m, self.sequence) File "/usr/local/mailman/Mailman/Archiver/HyperArch.py", line 626, in _makeArticle mlist=self.maillist) File "/usr/local/mailman/Mailman/Archiver/HyperArch.py", line 255, in __init__ self.__super_init(message, sequence, keepHeaders) File "/usr/local/mailman/Mailman/Archiver/pipermail.py", line 216, in __init__ s = StringIO(message.get_payload()) TypeError: expected read buffer, list found The problem seems to be that cStringIO (unlike plain StringIO) cannot take a list as a read buffer. It will only accept a string. I'm using Python 2.2.2 (#1, Jan 30 2003, 21:26:22) [GCC 2.96 20000731 (Red Hat Linux 7.3 2.96-112)] on linux2 But cStringIO's behaviour seems to be the same even on Python 2.3.2. The doc string for pythonlib/email/Message.py's get_payload() function says """Return a reference to the payload. The payload will either be a list object or a string. If you mutate the list object, you modify the message's payload in place. Optional i returns that index into the payload. I think this has to be a bug, because if it returns a list it will certainly break cStringIO. ---------------------------------------------------------------------- >Comment By: Martin Pool (mbp) Date: 2003-12-01 20:51 Message: Logged In: YES user_id=521 I think this was my error. We had ARCHIVE_SCRUBBER=0 while we were using MHonArc, but I see that has to be left on the default for Pipermail to work. ---------------------------------------------------------------------- Comment By: Martin Pool (mbp) Date: 2003-12-01 20:43 Message: Logged In: YES user_id=521 Not only is get_payload() returning a list, but it's not even a list of strings. So it's no wonder that StringIO is having trouble. For the sample message I quoted, get_payload() returns a 2-element list where the elements are instances of Mailman.Message.Message. I wonder if I have an old/buggy pythonlib/email library for some reason, or if some old cruft on redhat is causing the problem? All of the relevant code seems reasonably close to python 2.3. And anyhow, the mailman docs say that only python 2.1 is required. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=851970&group_i…

1 0

[ mailman-Bugs-851970 ] crash running archiver: StringIO: expected read buffer, list
by SourceForge.net 01 Dec '03

01 Dec '03

Bugs item #851970, was opened at 2003-12-01 20:32 Message generated for change (Comment added) made by mbp You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=851970&group_i… Category: Pipermail Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Martin Pool (mbp) Assigned to: Nobody/Anonymous (nobody) Summary: crash running archiver: StringIO: expected read buffer, list Initial Comment: Hi, I'm trying to import some messages into an archive using the arch command in 2.1.3. This mostly works, except that a few messages that seem otherwise well-formed are causing an exception: mailman@dp:private$ python -i /usr/local/mailman/bin/arch distcc /tmp/crash2 #00000 <1066876904.6827.10.camel(a)lisa.thedoh.com> Pickling archive state into /var/mailman/archives/private/distcc/pipermail.pck Traceback (most recent call last): File "/usr/local/mailman/bin/arch", line 187, in ? main() File "/usr/local/mailman/bin/arch", line 175, in main archiver.processUnixMailbox(fp, start, end) File "/usr/local/mailman/Mailman/Archiver/pipermail.py", line 558, in processUnixMailbox a = self._makeArticle(m, self.sequence) File "/usr/local/mailman/Mailman/Archiver/HyperArch.py", line 626, in _makeArticle mlist=self.maillist) File "/usr/local/mailman/Mailman/Archiver/HyperArch.py", line 255, in __init__ self.__super_init(message, sequence, keepHeaders) File "/usr/local/mailman/Mailman/Archiver/pipermail.py", line 216, in __init__ s = StringIO(message.get_payload()) TypeError: expected read buffer, list found The problem seems to be that cStringIO (unlike plain StringIO) cannot take a list as a read buffer. It will only accept a string. I'm using Python 2.2.2 (#1, Jan 30 2003, 21:26:22) [GCC 2.96 20000731 (Red Hat Linux 7.3 2.96-112)] on linux2 But cStringIO's behaviour seems to be the same even on Python 2.3.2. The doc string for pythonlib/email/Message.py's get_payload() function says """Return a reference to the payload. The payload will either be a list object or a string. If you mutate the list object, you modify the message's payload in place. Optional i returns that index into the payload. I think this has to be a bug, because if it returns a list it will certainly break cStringIO. ---------------------------------------------------------------------- >Comment By: Martin Pool (mbp) Date: 2003-12-01 20:43 Message: Logged In: YES user_id=521 Not only is get_payload() returning a list, but it's not even a list of strings. So it's no wonder that StringIO is having trouble. For the sample message I quoted, get_payload() returns a 2-element list where the elements are instances of Mailman.Message.Message. I wonder if I have an old/buggy pythonlib/email library for some reason, or if some old cruft on redhat is causing the problem? All of the relevant code seems reasonably close to python 2.3. And anyhow, the mailman docs say that only python 2.1 is required. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=851970&group_i…

1 0

[ mailman-Bugs-851970 ] crash running archiver: StringIO: expected read buffer, list
by SourceForge.net 01 Dec '03

01 Dec '03

Bugs item #851970, was opened at 2003-12-01 20:32 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=851970&group_i… Category: Pipermail Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Martin Pool (mbp) Assigned to: Nobody/Anonymous (nobody) Summary: crash running archiver: StringIO: expected read buffer, list Initial Comment: Hi, I'm trying to import some messages into an archive using the arch command in 2.1.3. This mostly works, except that a few messages that seem otherwise well-formed are causing an exception: mailman@dp:private$ python -i /usr/local/mailman/bin/arch distcc /tmp/crash2 #00000 <1066876904.6827.10.camel(a)lisa.thedoh.com> Pickling archive state into /var/mailman/archives/private/distcc/pipermail.pck Traceback (most recent call last): File "/usr/local/mailman/bin/arch", line 187, in ? main() File "/usr/local/mailman/bin/arch", line 175, in main archiver.processUnixMailbox(fp, start, end) File "/usr/local/mailman/Mailman/Archiver/pipermail.py", line 558, in processUnixMailbox a = self._makeArticle(m, self.sequence) File "/usr/local/mailman/Mailman/Archiver/HyperArch.py", line 626, in _makeArticle mlist=self.maillist) File "/usr/local/mailman/Mailman/Archiver/HyperArch.py", line 255, in __init__ self.__super_init(message, sequence, keepHeaders) File "/usr/local/mailman/Mailman/Archiver/pipermail.py", line 216, in __init__ s = StringIO(message.get_payload()) TypeError: expected read buffer, list found The problem seems to be that cStringIO (unlike plain StringIO) cannot take a list as a read buffer. It will only accept a string. I'm using Python 2.2.2 (#1, Jan 30 2003, 21:26:22) [GCC 2.96 20000731 (Red Hat Linux 7.3 2.96-112)] on linux2 But cStringIO's behaviour seems to be the same even on Python 2.3.2. The doc string for pythonlib/email/Message.py's get_payload() function says """Return a reference to the payload. The payload will either be a list object or a string. If you mutate the list object, you modify the message's payload in place. Optional i returns that index into the payload. I think this has to be a bug, because if it returns a list it will certainly break cStringIO. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=851970&group_i…

1 0

[ mailman-Bugs-834486 ] Uncatched ValueError in Scrubber
by SourceForge.net 30 Nov '03

30 Nov '03

Bugs item #834486, was opened at 2003-11-02 06:22 Message generated for change (Comment added) made by bwarsaw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=834486&group_i… Category: None >Group: 2.1 (stable) >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Simone Piunno (pioppo) Assigned to: Nobody/Anonymous (nobody) Summary: Uncatched ValueError in Scrubber Initial Comment: Mailman 2.1.2, python 2.2 Nov 01 20:40:04 2003 (10542) Uncaught runner exception: Empty module name Nov 01 20:40:04 2003 (10542) Traceback (most recent call last): File "/usr/local/mailman/Mailman/Queue/Runner.py", line 105, in _oneloop self._onefile(msg, msgdata) File "/usr/local/mailman/Mailman/Queue/Runner.py", line 155, in _onefile keepqueued = self._dispose(mlist, msg, msgdata) File "/usr/local/mailman/Mailman/Queue/IncomingRunner.py", line 130, in _dispose more = self._dopipeline(mlist, msg, msgdata, pipeline) File "/usr/local/mailman/Mailman/Queue/IncomingRunner.py", line 153, in _dopipeline sys.modules[modname].process(mlist, msg, msgdata) File "/usr/local/mailman/Mailman/Handlers/ToDigest.py", line 89, in process send_digests(mlist, mboxfp) File "/usr/local/mailman/Mailman/Handlers/ToDigest.py", line 130, in send_digests send_i18n_digests(mlist, mboxfp) File "/usr/local/mailman/Mailman/Handlers/ToDigest.py", line 303, in send_i18n_digests msg = scrubber(mlist, msg) File "/usr/local/mailman/Mailman/Handlers/Scrubber.py", line 308, in process t = t.encode(charset, 'replace') File "/usr/lib/python2.2/encodings/__init__.py", line 51, in search_function mod = __import__(modname,globals(),locals(),'*') ValueError: Empty module name This is still uncorrected in v2_1-branch Attached a proposed fix. ---------------------------------------------------------------------- >Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-11-30 20:43 Message: Logged In: YES user_id=12800 Thanks, applied! ---------------------------------------------------------------------- Comment By: jared mauch (jaredmauch) Date: 2003-11-12 10:26 Message: Logged In: YES user_id=131445 I'm also seeing this error. This patch solved my problem. Thanks! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=834486&group_i…

1 0

[ mailman-Bugs-816410 ] subscription request webpage has inconsistant wording
by SourceForge.net 30 Nov '03

30 Nov '03

Bugs item #816410, was opened at 2003-10-02 04:01 Message generated for change (Settings changed) made by bwarsaw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=816410&group_i… Category: Web/CGI >Group: 2.1 (stable) >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: JC Dill (jcdill) Assigned to: Nobody/Anonymous (nobody) Summary: subscription request webpage has inconsistant wording Initial Comment: In the text of the page it says: Or hit /Cancel and discard/ to cancel this subscription request. But the button itself says "Cancel subscription request" rather than "Cancel and discard". ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=816410&group_i…

1 0

[ mailman-Bugs-835012 ] incorrect permissions on archive index file
by SourceForge.net 30 Nov '03

30 Nov '03

Bugs item #835012, was opened at 2003-11-03 08:14 Message generated for change (Settings changed) made by bwarsaw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=835012&group_i… Category: security/privacy Group: 2.1 (stable) >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Rohan Carly (rohanc) Assigned to: Nobody/Anonymous (nobody) Summary: incorrect permissions on archive index file Initial Comment: The index file for list archives is created with the wrong file permissions. I'm referring to: mailman/archives/private/ --listname-- / index.html All my lists have index.html set to "rw-rw-rw-" which seems too permissive. I think this can be corrected by modifiying the Archiver.InitVars method inside the file: mailman/Mailman/Archiver/Archiver.py . I just added: os.umask(omask) before the line that reads: fp = open(indexfile, 'w') I run Mailman 2.1.3. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=835012&group_i…

1 0

[ mailman-Bugs-833384 ] wrong moderator password shouldn't silently discard message
by SourceForge.net 30 Nov '03

30 Nov '03

Bugs item #833384, was opened at 2003-10-30 17:05 Message generated for change (Comment added) made by bwarsaw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=833384&group_i… Category: None Group: 2.1 (stable) >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Ken Olum (kdolum) Assigned to: Nobody/Anonymous (nobody) Summary: wrong moderator password shouldn't silently discard message Initial Comment: If you reply to the approval required message and give an approved: line, but mistype the password, the pending message is silently discarded. I think that's a scary misfeature. I think in this case it should reject your confirmation mail with an error saying that the password is wrong, since obviously you're attempting to get the message approved. Otherwise, you never know that the message has been discarded except that you don't see it appear on the list, and then it is too late to recover it. It would also be nice for the site password to be usable for message approval. (Now you see how I discovered the problem above.) ---------------------------------------------------------------------- >Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-11-30 19:54 Message: Logged In: YES user_id=12800 Fixed for 2.1.4 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=833384&group_i…

1 0

[ mailman-Bugs-849036 ] fully remove product and version information
by SourceForge.net 30 Nov '03

30 Nov '03

Bugs item #849036, was opened at 2003-11-25 10:40 Message generated for change (Comment added) made by bwarsaw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=849036&group_i… Category: security/privacy Group: 2.1 (stable) >Status: Closed >Resolution: Wont Fix Priority: 5 Submitted By: Florian Effenberger (floeff) Assigned to: Nobody/Anonymous (nobody) Summary: fully remove product and version information Initial Comment: I would like to see an option in the configuration files to fully remove product and version information from the CGIs and the mail headers. It is part of my security concept to NOT show anything like that to outside users. ---------------------------------------------------------------------- >Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-11-30 19:37 Message: Logged In: YES user_id=12800 You'll have to hack the source to do this. I don't plan on making this a configuration variable. ---------------------------------------------------------------------- Comment By: Florian Effenberger (floeff) Date: 2003-11-25 14:17 Message: Logged In: YES user_id=240337 Ah, sorry, the comment from 2003-11-25 20:15 was meant for another bug, please ignore it. The feature request is still valid, though. ---------------------------------------------------------------------- Comment By: Florian Effenberger (floeff) Date: 2003-11-25 14:15 Message: Logged In: YES user_id=240337 No problem, it was just a suggestion :) I know views may vary on this. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=849036&group_i…

1 0

[ mailman-Bugs-784700 ] 'make install' after 'make' modifies source tree
by SourceForge.net 30 Nov '03

30 Nov '03

Bugs item #784700, was opened at 2003-08-07 07:15 Message generated for change (Comment added) made by bwarsaw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=784700&group_i… Category: configuring/installing Group: 2.1 (stable) >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Thomas Arendsen Hein (thomas_ah) Assigned to: Nobody/Anonymous (nobody) Summary: 'make install' after 'make' modifies source tree Initial Comment: With mailman 2.1.2 './configure' and 'make' run fine, but then I switched to the mailman user account to do 'make install'. It tried to unpack misc/email-2.5.1.tar.gz, misc/JapaneseCodecs-1.4.9.tar.gz and misc/KoreanCodecs-2.0.5.tar.gz, but this failed because the mailman user doesn't have write permission in the source tree. I think 'make install' shouldn't need to write to the source tree after 'make' was done. Either this has to be done during 'make' or to the /tmp directory. ---------------------------------------------------------------------- >Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-11-30 19:13 Message: Logged In: YES user_id=12800 Fixed by addition of a make variable PKGDIR ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=784700&group_i…

1 0