Mailman 3 March 2013 - Mailman-coders

[Bug 967951] [NEW] The LMTP runner should reject messages with duplicate Message-IDs
by Barry Warsaw 06 Mar '15

06 Mar '15

Public bug reported: Subject says it all. Mailman 3 requires unique Message-IDs for posts. ** Affects: mailman Importance: Undecided Status: New ** Tags: easy mailman3 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/967951 Title: The LMTP runner should reject messages with duplicate Message-IDs To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/967951/+subscriptions

6 8

[Bug 1158721] [NEW] Emails without a text/plain part crash the Approved rule
by Aurélien Bompard 30 Dec '14

30 Dec '14

Public bug reported: If an email has no plain text part, the Approved rule will crash with the following message: AttributeError: 'NoneType' object has no attribute 'get_payload' The attached patch fixes the bug and adds a unit test for it. It's been generated from the current bzr branch. ** Affects: mailman Importance: Undecided Status: New ** Patch added: "mailman-notextpart.patch" https://bugs.launchpad.net/bugs/1158721/+attachment/3590081/+files/mailman-… -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1158721 Title: Emails without a text/plain part crash the Approved rule To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1158721/+subscriptions

2 5

[Bug 1130957] [NEW] Unicode errors in mailman3
by Aurélien Bompard 30 Dec '14

30 Dec '14

Public bug reported: This is with mailman3. I'm getting the following unicode errors: Feb 20 23:07:43 2013 (13496) Uncaught runner exception: Expected unicode, found <type 'str'>: 'foobar(a)example.com' Feb 20 23:07:43 2013 (13496) Traceback (most recent call last): File "/srv/dev/mailman/mailman/src/mailman/core/runner.py", line 145, in _one_iteration self._process_one_file(msg, msgdata) File "/srv/dev/mailman/mailman/src/mailman/core/runner.py", line 228, in _process_one_file keepqueued = self._dispose(mlist, msg, msgdata) File "/srv/dev/mailman/mailman/src/mailman/runners/outgoing.py", line 93, in _dispose self._func(mlist, msg, msgdata) File "/srv/dev/mailman/mailman/src/mailman/mta/deliver.py", line 93, in deliver refused = agent.deliver(mlist, msg, msgdata) File "/srv/dev/mailman/mailman/src/mailman/mta/base.py", line 167, in deliver member = mlist.members.get_member(recipient) File "/srv/dev/mailman/mailman/src/mailman/database/transaction.py", line 78, in wrapper return function(args[0], config.db.store, *args[1:], **kws) File "/srv/dev/mailman/mailman/src/mailman/model/roster.py", line 111, in get_member Address.email == address, File "/srv/dev/mailman/venv/lib/python2.7/site-packages/storm-0.19-py2.7-linux-x86_64.egg/storm/expr.py", line 412, in __eq__ other = getattr(self, "variable_factory", Variable)(value=other) File "/srv/dev/mailman/venv/lib/python2.7/site-packages/storm-0.19-py2.7-linux-x86_64.egg/storm/variables.py", line 396, in parse_set % (type(value), value)) TypeError: Expected unicode, found <type 'str'>: 'foobar(a)example.com' Feb 20 23:07:43 2013 (13496) SHUNTING: 1361401663.441109+267302c50d71d512974fe5caa7aa0214eab699f6 ----------------- Feb 20 22:20:45 2013 (13337) Uncaught runner exception: decoding Unicode is not supported Feb 20 22:20:45 2013 (13337) Traceback (most recent call last): File "/srv/dev/mailman/mailman/src/mailman/core/runner.py", line 145, in _one_iteration self._process_one_file(msg, msgdata) File "/srv/dev/mailman/mailman/src/mailman/core/runner.py", line 228, in _process_one_file keepqueued = self._dispose(mlist, msg, msgdata) File "/srv/dev/mailman/mailman/src/mailman/runners/digest.py", line 344, in _dispose rfc1153_digest.add_message(message, count) File "/srv/dev/mailman/mailman/src/mailman/runners/digest.py", line 269, in add_message payload = unicode(payload, 'us-ascii', 'replace') TypeError: decoding Unicode is not supported Feb 20 22:20:45 2013 (13337) SHUNTING: 1361398845.847068+d12dc2ef44dcca60ade2fc94f6f830bd09a6b912 Feb 20 22:20:52 2013 (13337) Uncaught runner exception: decoding Unicode is not supported Feb 20 22:20:52 2013 (13337) Traceback (most recent call last): File "/srv/dev/mailman/mailman/src/mailman/core/runner.py", line 145, in _one_iteration self._process_one_file(msg, msgdata) File "/srv/dev/mailman/mailman/src/mailman/core/runner.py", line 228, in _process_one_file keepqueued = self._dispose(mlist, msg, msgdata) File "/srv/dev/mailman/mailman/src/mailman/runners/digest.py", line 344, in _dispose rfc1153_digest.add_message(message, count) File "/srv/dev/mailman/mailman/src/mailman/runners/digest.py", line 269, in add_message payload = unicode(payload, 'us-ascii', 'replace') TypeError: decoding Unicode is not supported Feb 20 22:20:52 2013 (13337) SHUNTING: 1361398852.901291+bc2f1ab7dad828020238e06815fd2b4adab0fe61 The attached patch fixes both tracebacks. ** Affects: mailman Importance: Undecided Status: New ** Tags: mailman3 ** Patch added: "mailman-unicode.patch" https://bugs.launchpad.net/bugs/1130957/+attachment/3539184/+files/mailman-… -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1130957 Title: Unicode errors in mailman3 To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1130957/+subscriptions

5 12

[Bug 1130696] [NEW] AttributeError: Message instance has no attribute 'sender'
by Aurélien Bompard 30 Dec '14

30 Dec '14

Public bug reported: This is with mailman3: Feb 20 14:23:07 2013 (5721) Uncaught runner exception: MIMEMultipart instance has no attribute 'sender' Feb 20 14:23:07 2013 (5721) Traceback (most recent call last): File "/srv/dev/mailman/mailman/src/mailman/core/runner.py", line 145, in _one_iteration self._process_one_file(msg, msgdata) File "/srv/dev/mailman/mailman/src/mailman/core/runner.py", line 218, in _process_one_file elif msg.sender: AttributeError: MIMEMultipart instance has no attribute 'sender' Feb 20 14:23:07 2013 (5721) SHUNTING: 1361370187.943257+1fba5014964bdeae413f5280cd0f4d2cb5f7727b Feb 20 14:23:07 2013 (5721) Uncaught runner exception: Message instance has no attribute 'sender' Feb 20 14:23:07 2013 (5721) Traceback (most recent call last): File "/srv/dev/mailman/mailman/src/mailman/core/runner.py", line 145, in _one_iteration self._process_one_file(msg, msgdata) File "/srv/dev/mailman/mailman/src/mailman/core/runner.py", line 218, in _process_one_file elif msg.sender: AttributeError: Message instance has no attribute 'sender' Feb 20 14:23:08 2013 (5721) SHUNTING: 1361370187.973463+909c4b5e80497ec67e97765281e7ada77a865143 The message seems to be originating from mailman, it's a digest. I'm attaching a very simple patch that handles the case where there is no sender header. ** Affects: mailman Importance: Undecided Status: New ** Tags: easy mailman3 ** Patch added: "mailman-nosender.patch" https://bugs.launchpad.net/bugs/1130696/+attachment/3538395/+files/mailman-… -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1130696 Title: AttributeError: Message instance has no attribute 'sender' To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1130696/+subscriptions

2 4

[Bug 1060951] [NEW] Bug getting i18n'ed attachment filenames (RFC2231)
by Aurélien Bompard 30 Dec '14

30 Dec '14

Public bug reported: RFC 2231 allows filenames to have non-ascii characters. The get_filename() method in Python's Message class handles this by calling email.utils.collapse_rfc2231_value() at the end of get_filename. This method returns the filename in Unicode. This fails in Mailman because the mailman.email.message.Message class has a wrapper around get() and __getitem__() to return unicode headers. As a result, the collapse_rfc2231_value() tries to transforms into unicode an already unicode string, and I get the following exception: File "/usr/lib/python2.7/email/utils.py", line 319, in collapse_rfc2231_value return unicode(rawval, charset, errors) TypeError: decoding Unicode is not supported A possible solution to this would be to make Mailman's Message get_filename() method be more than just an exception-catching wrapper, and re-implement the original get_filename() method, inserting a conversion to str before calling collapse_rfc2231_value(). Does this make sense ? Any other idea for a possible solution ? ** Affects: mailman Importance: Undecided Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1060951 Title: Bug getting i18n'ed attachment filenames (RFC2231) To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1060951/+subscriptions

3 8

[Bug 1157854] [NEW] test_not_enough_parameters hangs on OS X
by Barry Warsaw 29 Nov '14

29 Nov '14

Public bug reported: test_not_enough_parameters (mailman.rest.tests.test_users.TestLogin) This test hangs completely on OS X 10.6.8 and 10.8.2. It does not hang on Ubuntu 13.04 AFAICT. Commenting out this test allows the rest of the test suite to run to completion, although I get three test failures (on OS X 10.8.2). test_cannot_create_duplicate_list (mailman.rest.tests.test_lists.TestLists) test_cannot_create_list_in_missing_domain (mailman.rest.tests.test_lists.TestLists) test_existing_user_error (mailman.rest.tests.test_users.TestUsers) Further, C-c leaves the RESTRunner running. ** Affects: mailman Importance: Undecided Status: New ** Tags: mailman3 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1157854 Title: test_not_enough_parameters hangs on OS X To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1157854/+subscriptions

1 3

[Bug 880613] [NEW] PostgreSQL constraints disabled
by Barry Warsaw 29 Nov '14

29 Nov '14

Public bug reported: In src/mailman/database/sql/postgres.sql, several foreign key constraints have been commented out because otherwise the test suite, or other aspects do not work. This is probably because there are cases where Mailman violates these constraints, but SQLite3 (the default database) does not care. All disabled constraints are marked with XXX in the above file. Really, these should be fixed. ** Affects: mailman Importance: Medium Status: Confirmed ** Tags: mailman3 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/880613 Title: PostgreSQL constraints disabled To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/880613/+subscriptions

1 2

[Bug 1091586] [NEW] Frequent OperationalError: database is locked with sqlite
by Aurélien Bompard 26 Nov '14

26 Nov '14

Public bug reported: I'm seeing frequent locking errors with SQLite on the current version of mailman3 from bzr. Here's an example traceback : Traceback (most recent call last): File "/srv/dev/mailman/bin/runner", line 9, in <module> load_entry_point('mailman==3.0.0b2-', 'console_scripts', 'runner')() File "/srv/dev/mailman/mailman3/mailman/src/mailman/bin/runner.py", line 253, in main runner.run() File "/srv/dev/mailman/mailman3/mailman/src/mailman/core/runner.py", line 96, in run filecnt = self._one_iteration() File "/srv/dev/mailman/mailman3/mailman/src/mailman/core/runner.py", line 173, in _one_iteration config.db.commit() File "/srv/dev/mailman/mailman3/mailman/src/mailman/database/base.py", line 77, in commit self.store.commit() File "/srv/dev/mailman/lib/python2.6/site-packages/storm-0.19-py2.6-linux-x86_64.egg/storm/store.py", line 122, in commit self._connection.commit() File "/srv/dev/mailman/lib/python2.6/site-packages/storm-0.19-py2.6-linux-x86_64.egg/storm/databases/sqlite.py", line 126, in commit self.raw_execute("COMMIT", _end=True) File "/srv/dev/mailman/lib/python2.6/site-packages/storm-0.19-py2.6-linux-x86_64.egg/storm/databases/sqlite.py", line 154, in raw_execute return Connection.raw_execute(self, statement, params) File "/srv/dev/mailman/lib/python2.6/site-packages/storm-0.19-py2.6-linux-x86_64.egg/storm/database.py", line 322, in raw_execute self._check_disconnect(raw_cursor.execute, *args) File "/srv/dev/mailman/lib/python2.6/site-packages/storm-0.19-py2.6-linux-x86_64.egg/storm/database.py", line 371, in _check_disconnect return function(*args, **kwargs) sqlite3.OperationalError: database is locked It happens during the normal processing of Mailman, not while using the API (to my knowledge), so it seems different from bug #856004. I can reproduce this easily by letting Mailman work for some time. After the locking error, new messages are stuck in var/queue/pipeline: $ ls var/queue/* var/queue/archive: var/queue/bad: var/queue/bounces: var/queue/command: var/queue/digest: var/queue/in: var/queue/lmtp: var/queue/nntp: var/queue/out: var/queue/pipeline: 1355781960.9870529+18f0acdf07aab616f793ecf76acfa1994e62b3a9.pck 1355799347.787621+213f3a6a971717ad1ba27f3d56b65767747a45da.pck 1355814973.8623891+4e66eeadef9b8c9ae99e4ed022c6c93f5af75c05.pck 1355782349.546113+ee14cb323574b647d9014f742e3f505e388d553e.pck 1355800543.460628+c455625c1ad86a5a77c9c515fcb6d555ba439b19.pck 1355815808.8860879+ca3fb5f45999e47c92756489daa951672ba4304d.pck 1355792739.8787439+19973fbcf763f036655aa0a7d477231246afdfbd.pck 1355802301.7830889+7989a3199c7eb491b65176937c0c1658cca9d46d.pck 1355820018.1813829+5005ded04da3574a7f3cd7472c9d635c577b6c32.pck 1355794764.597765+6cf379ad16c948117bb65f0aed0b3c230268ffd2.pck 1355803681.7455051+52d185cdcaecaf883bd43f375f5253567f5cd568.pck 1355822188.0491021+6a3cab9831d03b4f94475f745fa508c5126116b4.pck 1355794889.8323901+e14e25e342ec59709266040d830d7e12be2a1261.pck 1355805362.052228+422e573a6117edb7aae1acf9150ac58c210cedba.pck 1355822293.2363911+627f13dd2121bcb0f1916bc0448cc3b8adc9ad1f.pck 1355795937.2442579+62193d05ee80c6a22213cf2ff211c135fb7d38d9.pck 1355807374.9844501+8de57ab53819fac59d64705bcc56f86899d22634.pck 1355798662.8335559+554da4e7690e116e6fabee5764ac69829dc25685.pck 1355808273.143533+ed1acbf580c596ed921e062ece575877f0c9304b.pck var/queue/rest: var/queue/retry: var/queue/shunt: 1355776302.1302171+c657867b33bf6e37554ff83ee26f4096a77c1114.pck var/queue/virgin: And I need to restart mailman to make it process them again. The locked caused the message to be shunted. I'll attach the mailman.log file, where you'll see many "database is locked" errors, happening on different requests. ** Affects: mailman Importance: Undecided Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1091586 Title: Frequent OperationalError: database is locked with sqlite To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1091586/+subscriptions

2 8

[Bug 1082746] [NEW] Automated processes can swamp a list with web subscription requests.
by Mark Sapiro 01 Oct '14

01 Oct '14

Public bug reported: There are discussions of this in threads at <http://mail.python.org/pipermail/mailman- users/2012-October/074213.html>, <http://mail.python.org/pipermail /mailman-users/2012-October/074278.html> and <http://mail.python.org/pipermail/mailman- users/2012-November/074412.html>. The Mailman developers do not think there is any way to prevent this other that disabling web subscribe entirely, as by definition, subscription requests come from unauthenticated users. However, an attempt will be made to mitigate this by making a site option to include a dynamically generated hidden hash in the subscribe form which will at least require an automated process to first GET and parse the listinfo form immediately prior to POSTing it. ** Affects: mailman Importance: Medium Assignee: Mark Sapiro (msapiro) Status: In Progress -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1082746 Title: Automated processes can swamp a list with web subscription requests. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1082746/+subscriptions

3 8

[Bug 1095422] [NEW] Non-queue runners should not create var/queue/* directories
by Barry Warsaw 22 Apr '14

22 Apr '14

Public bug reported: The LMTP and REST runners are not queue runners. They are daemon processes which do not scan directories. They should not create directories in var/queue, probably by disabling the creation of the Switchboard in their subclass. ** Affects: mailman Importance: Low Status: Triaged ** Tags: mailman3 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1095422 Title: Non-queue runners should not create var/queue/* directories To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1095422/+subscriptions

2 8