Mailman 3 September 2004 - Mailman-coders

[ mailman-Patches-891491 ] Scrubber.py patch
by SourceForge.net Sept. 11, 2004

Sept. 11, 2004

Patches item #891491, was opened at 2004-02-06 02:26 Message generated for change (Comment added) made by ber You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=891491&group_i… Category: Pipermail Group: Mailman 2.1 Status: Open Resolution: None Priority: 8 Submitted By: Tokio Kikuchi (tkikuchi) Assigned to: Nobody/Anonymous (nobody) Summary: Scrubber.py patch Initial Comment: Scrubber.py has number of bugs for processing various types of attachment and languages and many have submitted patches to fix them. This patch item is opened to collect such patches for convenience. This patch corrects: - if an attached text is composed by win notepad, it has no charset specified and actual charset may be different from message/list charset. This sometimes cause error in composing digest message. - sometimes, null charset is represented by '' as well as None. - embedded rfc-2822 message is lost if you don't use msg.walk() - special problem with japanese charsets. - t (stringfied part) may be None which you can't append a '\n'. ---------------------------------------------------------------------- Comment By: Bernhard Reiter (ber) Date: 2004-09-11 20:04 Message: Logged In: YES user_id=113859 scrubber.patch 2004-08-24 has a problem. Charset(lcset).output_charset can return None according to the documentation. E.g. when no conversion is needed. This would assign Non to lcset_out . Later this leads to an exception in try: if len(charset) == 0: charset = 'us-ascii' t = t.encode(charset, 'replace') except (UnicodeError, LookupError, ValueError): t = t.encode(lcset, 'replace') because: TypeError: len() of unsized object ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2004-08-24 09:58 Message: Logged In: YES user_id=67709 added a fix for the case of lcset_out <> lcset. ---------------------------------------------------------------------- Comment By: Bernhard Reiter (ber) Date: 2004-04-14 20:53 Message: Logged In: YES user_id=113859 Thanks for working on the patch. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2004-02-25 11:42 Message: Logged In: YES user_id=67709 uploading revised patch. Now fixes a few more bugs which try to decode scrub plain text message and result in mojibake. Also, japanese filename tend to become so long that system limit may exceeded because of mime encoding, so add an option not to use the filename in the message but to use 'attachment' as filename. Because this patch spans two files (Defaults.py.in and Handlers/Scrubber.py) you have to cd mailman and patch -p1 < this_patch. (Well, I think it is -p1. If it didn't work, try -p0 ;-) ---------------------------------------------------------------------- Comment By: Jonathan Larmour (jifl) Date: 2004-02-22 18:25 Message: Logged In: YES user_id=817601 I strongly recommend applying this patch. I received a mail bounce on a list with an empty charset in a part (i.e. "charset=") and it caused /var/mailman/cron/senddigest and thus all digest processing to fail because of this error: Traceback (most recent call last): File "/var/mailman/cron/senddigests", line 94, in ? main() File "/var/mailman/cron/senddigests", line 86, in main mlist.send_digest_now() File "/var/mailman/Mailman/Digester.py", line 60, in send_digest_now ToDigest.send_digests(self, mboxfp) File "/var/mailman/Mailman/Handlers/ToDigest.py", line 123, in send_digests send_i18n_digests(mlist, mboxfp) File "/var/mailman/Mailman/Handlers/ToDigest.py", line 295, in send_i18n_digests msg = scrubber(mlist, msg) File "/var/mailman/Mailman/Handlers/Scrubber.py", line 308, in process t = t.encode(charset, 'replace') File "/usr/lib/python2.2/encodings/__init__.py", line 51, in search_function mod = __import__(modname,globals(),locals(),'*') which is something this patch fixes. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=891491&group_i…

1 0

[ mailman-Bugs-1025372 ] empty Cc:
by SourceForge.net Sept. 9, 2004

Sept. 9, 2004

Bugs item #1025372, was opened at 2004-09-09 16:02 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1025372&group_… Category: mail delivery Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Rob Ellis (robellis) Assigned to: Nobody/Anonymous (nobody) Summary: empty Cc: Initial Comment: In lists migrated from 2.0.13, new messages without a Cc: header end up with an empty one when delivered by mailman (2.1.5). Freshly created lists don't seem to have the problem ? This is on a freebsd 4 stable machine running postfix 2.0.19,1 with mailman set up to use SMTPDirect. Python 2.3.3. The attached patch to AvoidDuplicates.py/CookHeaders.py seems to fix it... - rob ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1025372&group_…

1 0

[ mailman-Patches-1024289 ] Add support for $Orig and $REF for Lotus Notes < 5.0.9
by SourceForge.net Sept. 8, 2004

Sept. 8, 2004

Patches item #1024289, was opened at 2004-09-08 15:35 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1024289&group_… Category: Pipermail Group: Mailman 2.1 Status: Open Resolution: None Priority: 5 Submitted By: shobhan challa (shobhanc) Assigned to: Nobody/Anonymous (nobody) Summary: Add support for $Orig and $REF for Lotus Notes < 5.0.9 Initial Comment: Lotus Notes below 6.25 doesnt set the 'In-Reply-To' or 'References' header. but it sets 'Orig' and 'REF' headers. Mailman should be able to process 'Orig' and 'REF' headers if 'In-Reply-To' is not set for Lotus Notes. Does anyone have any idea how to do this..? Thanks ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1024289&group_…

1 0

[ mailman-Bugs-1023942 ] No "Date:" line in digest header
by SourceForge.net Sept. 7, 2004

Sept. 7, 2004

Bugs item #1023942, was opened at 2004-09-07 14:55 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1023942&group_… Category: mail delivery Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Todd K. Watson (tkdubs) Assigned to: Nobody/Anonymous (nobody) Summary: No "Date:" line in digest header Initial Comment: I am running Mailman-2.1.5. Mailman fails to insert the "Date:" line in the header, which can cause problems for MTA's which do not inject a "Date:" line (such as qmail). Each individual message within the digest has a date line in its header, but the digest itself is missing the Date line. This causes mail readers like Thunderbird to label the message as being sent on Dec. 31, 1969. Most MTA's and MUA's inject a Date line, but I'm using Qmail as an MTA -- which doesn't inject one. It is the job of the MUA (Mailman in this case) to create the Date: line according to RFC-2822. This was fixed for non-digested messages delivered to lists in 2.1-beta-1 of Mailman according to the NEWS file, but has not yet been addressed for delivery of digests. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1023942&group_…

1 0

[ mailman-Bugs-1022762 ] common.c is using getgid() instead of getegid
by SourceForge.net Sept. 7, 2004

Sept. 7, 2004

Bugs item #1022762, was opened at 2004-09-05 17:40 Message generated for change (Comment added) made by gmottram You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1022762&group_… Category: security/privacy Group: None Status: Open Resolution: None Priority: 5 Submitted By: Geoff Mottram (gmottram) Assigned to: Nobody/Anonymous (nobody) Summary: common.c is using getgid() instead of getegid Initial Comment: The mailman wrapper that is used with its set group id set is checking the real group id in src/common.c (line 121). This will only work if mailman is configured to use the group "mail" as that is the only time the real and effective group of mailman will match the configuration. Any programs run by sendmail are real user id of "mail" and real group id of "mail". When using the set group id or set user id flags on an executable file, the program's real group and user values do not change, only their effective group and user id's. I am running Fedora core release 1 (kernel version 2.4.22), mailman version 2.1.5 and sendmail 8.12.10 with "smrsh". The fix is to change line 121 in src/common.c from: mygid = getgid() to mygid = getegid() With this change mailman can be installed as group "mailman" (or any other group besides "mail") instead of group "mail" (which is probably a security issue). Best, Geoff Mottram ---------------------------------------------------------------------- >Comment By: Geoff Mottram (gmottram) Date: 2004-09-07 02:35 Message: Logged In: YES user_id=1116625 I have more fully documented a fix to the above problem here: http://minaret.biz/tips/mailman.html In addition to the change from getgid() to getegid(), you must re-run configure with the "--with-cgi-gid=mailman" option for the cgi-bin scripts to work. Geoff ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1022762&group_…

1 0

[ mailman-Bugs-1022762 ] common.c is using getgid() instead of getegid
by SourceForge.net Sept. 5, 2004

Sept. 5, 2004

Bugs item #1022762, was opened at 2004-09-05 17:40 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1022762&group_… Category: security/privacy Group: None Status: Open Resolution: None Priority: 5 Submitted By: Geoff Mottram (gmottram) Assigned to: Nobody/Anonymous (nobody) Summary: common.c is using getgid() instead of getegid Initial Comment: The mailman wrapper that is used with its set group id set is checking the real group id in src/common.c (line 121). This will only work if mailman is configured to use the group "mail" as that is the only time the real and effective group of mailman will match the configuration. Any programs run by sendmail are real user id of "mail" and real group id of "mail". When using the set group id or set user id flags on an executable file, the program's real group and user values do not change, only their effective group and user id's. I am running Fedora core release 1 (kernel version 2.4.22), mailman version 2.1.5 and sendmail 8.12.10 with "smrsh". The fix is to change line 121 in src/common.c from: mygid = getgid() to mygid = getegid() With this change mailman can be installed as group "mailman" (or any other group besides "mail") instead of group "mail" (which is probably a security issue). Best, Geoff Mottram ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1022762&group_…

1 0

[ mailman-Bugs-1022562 ] news_moderation should be ignored when no gateway is used
by SourceForge.net Sept. 5, 2004

Sept. 5, 2004

Bugs item #1022562, was opened at 2004-09-05 15:27 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1022562&group_… Category: nntp/news Group: Out of Date Status: Open Resolution: None Priority: 5 Submitted By: Alex Schroeder (kensanata) Assigned to: Nobody/Anonymous (nobody) Summary: news_moderation should be ignored when no gateway is used Initial Comment: Using version 2.1.4.ber1... When news_moderation is set to Moderated, but both gateway_to_news and gateway_to_mail are set to No, all mails (even by members) require moderator approval. I think that news_moderation should be ignored when News server settings indicate that no Mail<->News gateway is active. We are two moderators, one newbie and me. The newbie had played around with the settings, and I tried to fix it. It hadn't occured to me to check the Mail<->News gateways section, because we don't use a gateway. A member on #mailman pointed me to the keyword "newsgroup" in the reason given: From: alex(a)emacswiki.org Subject: Re: SWPAT-action in Switzerland Reason: Posting to a moderated newsgroup ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1022562&group_…

1 0

[ mailman-Bugs-1022515 ] wrong location for Fedora Core 2 sendmail in Defaults.py
by SourceForge.net Sept. 5, 2004

Sept. 5, 2004

Bugs item #1022515, was opened at 2004-09-05 06:59 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1022515&group_… Category: configuring/installing Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Jonathan Baron (jonbaron1944) Assigned to: Nobody/Anonymous (nobody) Summary: wrong location for Fedora Core 2 sendmail in Defaults.py Initial Comment: On Fedora Core 2, using the RPM (which may not be your problem, but you may know whose problem it is), the location for sendmail in /var/mailman/Mailman/Default.py is /usr/lib/sendmail. Mailman would not send mail until I changed it to /usr/bin/sendmail in mm_cfg.py and restarted. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1022515&group_…

1 0

[ mailman-Patches-1021548 ] Provide subscription information to reject lists
by SourceForge.net Sept. 2, 2004

Sept. 2, 2004

Patches item #1021548, was opened at 2004-09-02 18:15 Message generated for change (Comment added) made by jrhett You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1021548&group_… Category: list administration Group: Mailman 2.1 Status: Open Resolution: None Priority: 5 Submitted By: Joe Rhett (jrhett) Assigned to: Nobody/Anonymous (nobody) Summary: Provide subscription information to reject lists Initial Comment: This patch provides useful subscription instructions to people who receive a rejection notice on a subscriber-only list. This really should be a per-list configuration option, or even better yet an editable field that the list admin can use to provide information to users. ---------------------------------------------------------------------- >Comment By: Joe Rhett (jrhett) Date: 2004-09-02 19:32 Message: Logged In: YES user_id=104595 Oops, wrong case on method invocation. Fix is here... ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1021548&group_…

1 0

[ mailman-Patches-1021548 ] Provide subscription information to reject lists
by SourceForge.net Sept. 2, 2004

Sept. 2, 2004

Patches item #1021548, was opened at 2004-09-02 18:15 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1021548&group_… Category: list administration Group: Mailman 2.1 Status: Open Resolution: None Priority: 5 Submitted By: Joe Rhett (jrhett) Assigned to: Nobody/Anonymous (nobody) Summary: Provide subscription information to reject lists Initial Comment: This patch provides useful subscription instructions to people who receive a rejection notice on a subscriber-only list. This really should be a per-list configuration option, or even better yet an editable field that the list admin can use to provide information to users. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1021548&group_…

1 0