Mailman 3 December 2003 - Mailman-coders

[ mailman-Patches-667026 ] HyperArch.py unicode substitution
by SourceForge.net 25 Dec '03

25 Dec '03

Patches item #667026, was opened at 2003-01-13 07:42 Message generated for change (Comment added) made by tkikuchi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=667026&group_i… Category: Pipermail Group: Mailman 2.1 >Status: Closed Resolution: None Priority: 6 Submitted By: Tokio Kikuchi (tkikuchi) Assigned to: Nobody/Anonymous (nobody) Summary: HyperArch.py unicode substitution Initial Comment: bin/arch and HyperArch.py produced error when i18n characters are present in the message body. I suspect that the text is in unicode string. This patch tests if text is unicode and then make the substitute string unicode. File "/usr/home/mailman/mailman-21/Mailman/Archiver/pipermail.py", line 592, i n add_article temp = self.format_article(article) File "/usr/home/mailman/mailman-21/Mailman/Archiver/HyperArch.py", line 1192, in format_article self.__processbody_URLquote(lines) File "/usr/home/mailman/mailman-21/Mailman/Archiver/HyperArch.py", line 1131, in __processbody_URLquote text = re.sub('@', _(' at '), text) File "/usr/local/lib/python2.1/sre.py", line 63, in sub return _compile(pattern, 0).sub(repl, string, count) File "/usr/local/lib/python2.1/sre.py", line 164, in _sub return _subn(pattern, template, string, count)[0] File "/usr/local/lib/python2.1/sre.py", line 185, in _subn append(filter(m)) File "/usr/local/lib/python2.1/sre.py", line 173, in filter return sre_parse.expand_template(template, match) File "/usr/local/lib/python2.1/sre_parse.py", line 732, in expand_template return string.join(literals, sep) File "/usr/local/lib/python2.1/string.py", line 128, in join return sep.join(words) UnicodeError: ASCII decoding error: ordinal not in range(128) ---------------------------------------------------------------------- >Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-12-25 12:48 Message: Logged In: YES user_id=67709 merged into #865661. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-20 00:26 Message: Logged In: YES user_id=67709 I think this deserves to be included in next release (2.1.2). So, increment priority and clean up old patch. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-04 06:45 Message: Logged In: YES user_id=67709 Update this patch for small bug. Charset defaults to 'us-ascii'. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=667026&group_i…

1 0

[ mailman-Patches-672389 ] admindb.py and admin/user notice i18n subject
by SourceForge.net 25 Dec '03

25 Dec '03

Patches item #672389, was opened at 2003-01-22 12:05 Message generated for change (Comment added) made by tkikuchi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=672389&group_i… Category: internationalization Group: Mailman 2.1 >Status: Closed Resolution: None Priority: 5 Submitted By: Tokio Kikuchi (tkikuchi) Assigned to: Nobody/Anonymous (nobody) Summary: admindb.py and admin/user notice i18n subject Initial Comment: When a message is hold for approval, notices are sent to the user and administrator. The administrator can later process the message with admindb cgi interface. When an i18n message was held, the subject is shown as mime encoded string and not easily readable. This patch decode the header and show the subject in the list preferred charset. ---------------------------------------------------------------------- >Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-12-25 12:45 Message: Logged In: YES user_id=67709 merged into #865661. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-01-23 00:38 Message: Logged In: YES user_id=67709 I have to change cron/checkdbs also. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=672389&group_i…

1 0

[ mailman-Patches-865661 ] Collection of i18n patches
by SourceForge.net 25 Dec '03

25 Dec '03

Patches item #865661, was opened at 2003-12-25 12:35 Message generated for change (Settings changed) made by tkikuchi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=865661&group_i… >Category: internationalization >Group: Mailman 2.1 Status: Open Resolution: None Priority: 9 Submitted By: Tokio Kikuchi (tkikuchi) Assigned to: Nobody/Anonymous (nobody) Summary: Collection of i18n patches Initial Comment: This patch works for 1. _at_ substitution for archive. 2. MIME decoded subject and message body in admindb pending post list. 3. i18n personalization. 4. Header/Footer charset adjusting for multiple charset. (works for Latin-15/1 problem, I believe.) 5. i18n message held notice. 6. fix for scrubber bug (atatched message). 7. i18n checkdbs. This collection of patch is for most recent CVS (2.1.4b) as of 12/25/2003 and I hope this is included in 2.1.4-release. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=865661&group_i…

1 0

[ mailman-Patches-664209 ] best effort to keep text/plain
by SourceForge.net 25 Dec '03

25 Dec '03

Patches item #664209, was opened at 2003-01-08 06:14 Message generated for change (Comment added) made by tkikuchi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=664209&group_i… Category: internationalization Group: Mailman 2.1 >Status: Closed Resolution: None Priority: 7 Submitted By: Tokio Kikuchi (tkikuchi) Assigned to: Nobody/Anonymous (nobody) Summary: best effort to keep text/plain Initial Comment: When a message come in different charset than list specific one, Decorate.py adds the header and footer in mime attatchments. This patch tries to keep the good-old plain text format by making these texts into unicode and encode in list preferred charset. If it fails, the messages will get mime-multiparted as was the case without this patch. ---------------------------------------------------------------------- >Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-12-25 12:43 Message: Logged In: YES user_id=67709 merged into #865661. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-05-12 00:10 Message: Logged In: YES user_id=67709 If you personalize delivery, i18n user name cause error because the name is stored in unicode. I merge this fix into this Decorate.py.patch.txt ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-20 11:42 Message: Logged In: YES user_id=67709 Sorry, there was a error in the previous patch. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-20 01:24 Message: Logged In: YES user_id=67709 Refine the code and increment priority. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-01-08 07:34 Message: Logged In: YES user_id=67709 Expand this patch to base64 encoded plain text. apply the second patch Decorate.py.diff2 to the original Decorate.py ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=664209&group_i…

1 0

[ mailman-Patches-670167 ] fix i18n attachment description in archive
by SourceForge.net 25 Dec '03

25 Dec '03

Patches item #670167, was opened at 2003-01-18 05:58 Message generated for change (Comment added) made by tkikuchi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=670167&group_i… Category: Pipermail Group: Mailman 2.1 >Status: Closed Resolution: Accepted Priority: 8 Submitted By: Tokio Kikuchi (tkikuchi) Assigned to: Nobody/Anonymous (nobody) Summary: fix i18n attachment description in archive Initial Comment: Bug-ID 669081 (Major attachment handling bug!) is caused inaccurate handling of charset in Scrubber.py. This is caused by misuse of email functions (or by bug in email package). In Scrubber.py, attempt is made to get message charset by part.get_charset() but it returns only None, as far as I experimented. In this patch, message charset is extracted from regular expression pattern in content-type header. This also set the charset of internally crafted message part. ---------------------------------------------------------------------- >Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-12-25 12:40 Message: Logged In: YES user_id=67709 I have opened a new tracker for collection of i18n patch #865661. So, closing this patch. ---------------------------------------------------------------------- Comment By: Guillaume Rousse (guillomovitch) Date: 2003-11-14 09:36 Message: Logged In: YES user_id=144568 What is the status of this patch for mailman 2.1.3 ? ---------------------------------------------------------------------- Comment By: Hugh Caley (hcaley) Date: 2003-05-30 17:23 Message: Logged In: YES user_id=17460 I patched version 2.1.2 of Mail man with patch Scrubber.py.patch.030224.txt, using "patch -p0 <Scrubber.py.patch.030224.txt". The patch applied cleanly, other than removing a couple of CR's at the end of the file. However, it doesn't seem to make a difference; messages sent from Outlook XP with an attachment still lose their message text. Did I do this correctly? Hugh_Caley(a)affymetrix.com ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-04-22 13:00 Message: Logged In: YES user_id=67709 Recently, I had a chance to get personal correspondence to refer this patch. To quote his comment, "(it) works like a charm!" So, I am incrementing the priority. :^) ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-24 04:34 Message: Logged In: YES user_id=67709 Uploading revised patch to fix more error. Sorry for the people downloaded earlier. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-24 01:39 Message: Logged In: YES user_id=67709 update my patch to fix error reported by sumeet File "/list/Mailman/Handlers/Scrubber.py", line 320, in process if not t.endswith('\n'): AttributeError: 'NoneType' object has no attribute 'endswith' ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-22 07:05 Message: Logged In: YES user_id=67709 This patch for Scrubber.py now include Bug-ID #691039. save_attachment() now returns (url, size), because in previous code, get_paylaod() is called before calling save_attachment() only to get the size. save_attachment() calls get_payload() inside. We might be able to discard the attachment if get_payload(decode=1) fail. (TBD: return discard message and size 0 ?) ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-20 01:31 Message: Logged In: YES user_id=67709 Increment priority because this is now a bug fix. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-04 06:08 Message: Logged In: YES user_id=67709 I made a new patch to fix embedded multipart messages are stripped bug. this patch is for CVS. see http://mail.python.org/pipermail/mailman-users/2003-February/026071.html ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-01-20 05:13 Message: Logged In: YES user_id=12800 Reopening so this issue doesn't get lost. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-01-20 04:03 Message: Logged In: YES user_id=67709 We, Japanese, need additional process of stringify and regenerate message instance.. Internal message is in 'euc-jp' but return value of get_content_charset() becomes 'iso-2022-jp' even though the get_payload() returns euc-jp text. The message and part body is converted to iso-2022-jp when it is output to SMTP (or whatever accepts in string format). ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-01-20 02:18 Message: Logged In: YES user_id=12800 Accepted, with changes. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-01-19 00:52 Message: Logged In: YES user_id=67709 Update of patch. Please backout the first one if you have already applied. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=670167&group_i…

1 0

[ mailman-Patches-865661 ] Collection of i18n patches
by SourceForge.net 25 Dec '03

25 Dec '03

Patches item #865661, was opened at 2003-12-25 12:35 Message generated for change (Settings changed) made by tkikuchi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=865661&group_i… Category: None Group: None Status: Open Resolution: None >Priority: 9 Submitted By: Tokio Kikuchi (tkikuchi) Assigned to: Nobody/Anonymous (nobody) Summary: Collection of i18n patches Initial Comment: This patch works for 1. _at_ substitution for archive. 2. MIME decoded subject and message body in admindb pending post list. 3. i18n personalization. 4. Header/Footer charset adjusting for multiple charset. (works for Latin-15/1 problem, I believe.) 5. i18n message held notice. 6. fix for scrubber bug (atatched message). 7. i18n checkdbs. This collection of patch is for most recent CVS (2.1.4b) as of 12/25/2003 and I hope this is included in 2.1.4-release. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=865661&group_i…

1 0

[ mailman-Patches-865661 ] Collection of i18n patches
by SourceForge.net 25 Dec '03

25 Dec '03

Patches item #865661, was opened at 2003-12-25 12:35 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=865661&group_i… Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Tokio Kikuchi (tkikuchi) Assigned to: Nobody/Anonymous (nobody) Summary: Collection of i18n patches Initial Comment: This patch works for 1. _at_ substitution for archive. 2. MIME decoded subject and message body in admindb pending post list. 3. i18n personalization. 4. Header/Footer charset adjusting for multiple charset. (works for Latin-15/1 problem, I believe.) 5. i18n message held notice. 6. fix for scrubber bug (atatched message). 7. i18n checkdbs. This collection of patch is for most recent CVS (2.1.4b) as of 12/25/2003 and I hope this is included in 2.1.4-release. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=865661&group_i…

1 0

[ mailman-Patches-636412 ] discard old pending posts
by SourceForge.net 25 Dec '03

25 Dec '03

Patches item #636412, was opened at 2002-11-11 00:39 Message generated for change (Comment added) made by tkikuchi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=636412&group_i… Category: None Group: Mailman 2.2 / 3.0 >Status: Closed Resolution: None Priority: 7 Submitted By: Tokio Kikuchi (tkikuchi) Assigned to: Nobody/Anonymous (nobody) Summary: discard old pending posts Initial Comment: This short script will help you to discard old pending posts. I put it in cron dir and run daily with this crontab entry: 55 7 * * * /usr/local/bin/python -S /home/mailman/cron/auto_discard | mail mailman-owner I hope this idea is integrated in cron/checkdb. (sorry I have no time to work now) ---------------------------------------------------------------------- >Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-12-25 12:10 Message: Logged In: YES user_id=67709 closing this patch in favor of #790494. ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-03-13 19:52 Message: Logged In: YES user_id=12800 Upping the priority ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2002-11-18 23:29 Message: Logged In: YES user_id=12800 This would be cool to add to cron/checkdbs. Here are some ideas - either have a MAX_REQUEST_AGE value in Defaults.py or a max_request_age attribute on lists if you want this to be different per-list (which might be a good idea since this is dependent on how often the list admins clear their pendings) - in the checkdbs message, keep a record of how many old ones you expire and mention it in the user notification. e.g. 17 old requests automatically expired. I'll mark this as for MM2.1 group, but it's really going to be pushed back until the following release. ---------------------------------------------------------------------- Comment By: Victor Nolton (ven-x) Date: 2002-11-11 01:37 Message: Logged In: YES user_id=646258 Thank ya! worked perfect! Thank you ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=636412&group_i…

1 0

[ mailman-Bugs-864700 ] Extra period in attachment name problem
by SourceForge.net 24 Dec '03

24 Dec '03

Bugs item #864700, was opened at 2003-12-22 17:33 Message generated for change (Comment added) made by bwarsaw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=864700&group_i… Category: None Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Kevin W. Gagel (kwgagel) Assigned to: Nobody/Anonymous (nobody) Summary: Extra period in attachment name problem Initial Comment: Having more than one period "." in the name of an attachment causes mailman to disregard portions of the file name, including the extention of the file. For example a file named: PRESIDENT'S NEWSLETTER NO. 2 - 2003-2004 ACADEMIC December.pdf Results in a file attachment of: PRESIDENT'S_NEWSLETTER_NO._2_-_2003- 2004_ACADEMIC (the above is wraped by the textbox input). Sending the same file attachment directly to a user does not cause this problem. Sending it through mailman does result in the change to the file name and extenton. ---------------------------------------------------------------------- >Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-12-25 00:02 Message: Logged In: YES user_id=12800 Please upload a message which exibits this behavior. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=864700&group_i…

1 0

[ mailman-Bugs-865489 ] tunable rejection message for non-members?
by SourceForge.net 24 Dec '03

24 Dec '03

Bugs item #865489, was opened at 2003-12-24 14:16 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=865489&group_i… Category: security/privacy Group: None Status: Open Resolution: None Priority: 5 Submitted By: David Abrahams (david_abrahams) Assigned to: Nobody/Anonymous (nobody) Summary: tunable rejection message for non-members? Initial Comment: I got this at the end of a bitter complaint from someone who couldn't figure out how to get into our mailing lists starting from GMane: > I also recommend cleaning up the newsgroup registration procedure so > that people who are not aware of the unusual requirement of > pre-registration are told why it exists and how to deal with it. > For example, I got this back when I first tried to post: > > You are not allowed to post to this mailing list, and your message has > been automatically rejected. If you think that your messages are > being rejected in error, contact the mailing list owner at > boost-users-owner(a)lists.boost.org. It appears Mailman allows us to tune the message that "moderated members" get when they post. Ours is: You are posting to a moderated mailing list from an email address that is not subscribed to the list. To facilitate the moderators job, we insist that all postings come from email addresses that are subscribed to the list (this does not mean that you have to receive individual emails from the list, or that you can't use a news group alias to access and post to the list, just that you must register first). Please visit http://lists.boost.org/mailman/listinfo.cgi/boost to register with the list. Thankyou, The Boost List Moderators Unfortunately, it doesn't seem to have a way to tune the message given to users who aren't members. If we want to keep spammers out by requiring registration before posting, *and* we want to moderate first-time posts, but we want users to get a nice explanation of how to get posting privileges, what can we do? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=865489&group_i…

1 0