Mailman 3 July 2013 - code-quality

Flake8 News
by Ian Cordasco 29 Aug '13

29 Aug '13

Hey all, I would first like to apologize for my complete disappearance from everything related to this list. Between finishing my masters, moving 1000 miles away and starting a new job (before I was even able to acquire domestic internet), I haven't had time for much of anything. In spite of that poor excuse, I'm sprinting on Flake8 today (trying to fix bugs and get other things written), and I wanted community feedback on a few things. First, is there any interest in developing a pylint plugin for Flake8? If so, who's interested in working with me on it. (I doubt we will finish it today, but I'd at least like to start it.) Second, can anyone provide some guidance (or at least opinions) on issue #85 on Flake8's bug tracker[1]. I'm conflicted about using a script to manage which version of python we use and I am quite partial to the method of appending the python version to the executable's name. However, if others have strong opinions on this, I'm quite willing to listen and would love more information. Finally, if there is anyone willing to collaborate with me on issues #95 [2], #97 [3], and #99 [4], I'd heartily appreciate it. To save you a few clicks, here are some summaries of those issues: #95: Generate code quality visualizations akin to: https://github.com/jsoverson/plato #97: Maintainability index based off McCabe, Halstead and SLOC #99: Machine readable output. This can probably take full advantage of pep8 features without needing to do anything special with Flake8. Firehose may also be of interest. [1]: https://bitbucket.org/tarek/flake8/issue/85 [2]: https://bitbucket.org/tarek/flake8/issue/95 [3]: https://bitbucket.org/tarek/flake8/issue/97 [4]: https://bitbucket.org/tarek/flake8/issue/99 Thanks in advance, Ian

6 11

More complete Bitbucket mails?
by Skip Montanaro 18 Jul '13

18 Jul '13

Is there some way to get Bitbucket to give me more information in its emails? I only have decent access at the moment to email. All I get are "approved" or "declined" mails with links, no comments the submitter might have included. Thx, Skip

2 1

copy/paste detection tool
by Lionel Barret 18 Jul '13

18 Jul '13

Hi, My name is Lionel Barret, I attended Florent Xicluna”s Europython talk Tuesday and it reminded me of a clone detection tool I used in the past (on a 100k sloc codebase) I talked about it with a few people (Florent Xicluna , Joe Gordon) and they were interested. Florent told me it was the list for this kind of discussion. This tool named clonedigger (http://clonedigger.sourceforge.net/ ) detects copy/pasted code or independent writing of the same classes/functions across a big codebase. In my last job, I used to get a daily html report, a big overview of the things that have been copy/pasted/rewritten. it was really useful. Sadly, it is unmaintained, the last upload dates from 2011. Besides, it”s using old packages (like the compiler package) and likely incompatible with python3 (either for running or for analyzing). I really think this kind of tool should be part of any code-quality toolbox, like pyflakes, pep8, etc. ( The tool itself is GPL, so no blocking there. ). I just wanted to see if anybody would be interested by an updated version of the tool and who could help. From the top of my mind, the next steps would be contacting the original author, evaluate the work to do (obsolete modules used and python3 incompatibilities) and eventually refactor the code. So what do you think ? Best, L.

2 3

autopep8 in flake8
by Tarek Ziadé 17 Jul '13

17 Jul '13

Hey folks what would you think about an option to call autopep8 as a plugin in Flake8 ? Cheers Tarek -- Tarek Ziadé | http://ziade.org

1 0

StackOverflow Tags
by Ian Cordasco 16 Jul '13

16 Jul '13

Hey all, I recently acquired enough reputation on StackOverflow to create new tags. I made one[1] for Flake8 since there seemed to be a few questions on there about it. If you guys need tags for your projects and have a few questions on there that could be tagged with them, let me know. Also if you have StackOverflow accounts and see questions that aren't already tagged, please tag them. It makes searching them that much easier. Thanks, Ian [1]: http://stackoverflow.com/questions/tagged/flake8

1 0

Adding new warnings?
by Skip Montanaro 08 Jul '13

08 Jul '13

Is there some magic to adding new messages to pylint? I've defined my new warning in checkers/classes.py by adding a new key/value pair to the MSGS dict: MSGS = { ... 'W0234': ('instance attribute %r is not used within the class', 'defined-attribute-not-accessed', 'Used when an attribute defined by the class is not accessed \ by the class itself.'), } but when I try to disable my new warning (W0324) with something like "# pylint: disable=C0302,W0324", it complains: E: 1: Bad option value 'W0324' Is there some sort of message compilation step which gathers all the keys from the MSGS dictionaries? I looked for all the places where "W0233" appeared, and tried to mimic that, but that would seem not to have been sufficient. I can see by the tracebacks that it is getting my new code. In fact, when I am unable to disable W0234, the checker emits the unused messages I'm trying to suppress, e.g.: W:113:ClassLevelMessage: instance attribute 'attr0' is not used within the class so I know my new code is being executed. Thx, Skip

4 5

pylint unit tests?
by Skip Montanaro 04 Jul '13

04 Jul '13

I'm struggling trying to get a clean test run in my local pylint repo. At the moment, I have one small checker function, whose call I have commented out, and have reverted all edits to the test inputs. When I run ./fulltest.sh 2.7 on my Mac, I get a lot of output, ending with this: Ran 528 test cases in 61.66s (54.36s CPU), 17 failures, 5 skipped 10 modules OK (2 failed) Is that the expected baseline unit test output from the current default branch? Reading in contribute.rst I got the impression that the unit tests should run cleanly. Thanks, Skip

3 6

[ANN] pep8 1.4.6 and PyFlakes 0.7.3
by Florent 02 Jul '13

02 Jul '13

Hello, I'm pleased to announce the release of Pyflakes 0.7.3 and pep8 1.4.6. Changes in these versions: * http://pep8.readthedocs.org/en/1.4.6/developer.html#changes * http://bazaar.launchpad.net/~pyflakes-dev/pyflakes/master/view/106/NEWS.txt -- Florent Xicluna

1 0

Pylint - missing module docstring for __init__.py
by Skip Montanaro 02 Jul '13

02 Jul '13

This warning seems specious: __init__.py:1: [C0111] Missing module docstring especially since __init__.py is often empty (as it is in this case), being used only as a marker that a directory is actually a package. This is in Python 2.7. I'm doing nothing to override the docstring_min_length config parameter, so if my reading of DocStringChecker._check_docstring is correct, this message should not be emitted for any zero-length module. I can't tell where/how self.config.docstring_min_length is initialized (find+grep doesn't return many hits), so can't tell what its value is, either. (Well, not without inserting a print statement.) What am I missing here? Skip

2 1