code-quality August 2014

code-quality@python.org

7 participants
9 discussions

Pylint not reporting modules passed on command line

by Mark E. Hamilton

Hi, again, I've got a test structure that looks like this: % find . . ./test_dir1 ./test_dir1/subdir1 ./test_dir1/subdir1/test1.py ./test_dir2 ./test_dir2/subdir2 ./test_dir2/subdir2/test2.py If I pass both .py files to pylint on the command line it processes both, but only reports one of them in the 'by module' section. % pylint test_dir1/subdir1/test1.py test_dir2/subdir2/test2.py No config file found, using default configuration ************* Module test1 C: 5, 0: Line too long (87/80) (line-too-long) ... ************* Module test2 C: 1, 0: Missing module docstring (missing-docstring) ... % errors / warnings by module ----------------------------- +-------+------+--------+---------+-----------+ |module |error |warning |refactor |convention | +=======+======+========+=========+===========+ |test2 |0.00 |100.00 |100.00 |60.00 | +-------+------+--------+---------+-----------+ ... Statistics by type ------------------ +---------+-------+-----------+-----------+------------+---------+ |type |number |old number |difference |%documented |%badname | +=========+=======+===========+===========+============+=========+ |module |2 |2 |= |0.00 |0.00 | +---------+-------+-----------+-----------+------------+---------+ ... It's always the same file (test2.py) which gets reported, even if I change the order of the files on the command line. The same thing occurs if I pass --output-format=text or --output-format=html; both the pylint_global.txt and pylint_global.html files are missing the test1.py module from the 'errors/warnings by module' section. Is this a bug, or just something I'm doing wrong or misunderstanding? -- ---------------- Mark E. Hamilton Engineering Sciences Center Senior Member of Technical Staff Sandia National Laboratories 505-844-7666

7 years, 1 month

How and where to add tests for Python 3

by François Magimel

Hello! I'm new in this mailing, so I will introduce myself first. I'm François (alias Linkid), a French engineering student who code mainly in Python. I'm involved in some open source projects and some of them like Django or OpenStack. I would like to add a test for Python 3 to check an import, but I don't really know on which project (pep8, pyflakes, …) to do that and how to do it (by a push request on github or somewhere else, by a bug report, …). I searched some clue and I think my test should be used by pyflakes, but I'm not sure… So, here are my questions: - on which project should I add a Python 3 import test ? - how I should process ? I think it could help be a lot if someone explain me what one project really check, if it is possible. Thank you. François Magimel (Linkid)

7 years, 1 month

Yet another namespace issue ? Virtualenv

by François Vanderkelen

Hi experts, I have another issue which seems to be related to namespaces but happening only inside virtualenv. Whenever I am running pylint on a namespaced module calling dependencies inside another module within the same namespace (or a parent one), I get an unable to import "module" error. I missed a command and installed all my packages in my global environement by mistake and ran the same pylint, everything was running smoothly (went from -14,14 to 8.46 for a single file). I tried to change the vitualen pylint version to match the one installed globally without success. Looks like the pylint inside my virtualenv is not running on the correct path. I will continue digging and try to provide you with more details (and files) but I was wondering if this was a known issue or just a configuration thing ? Thanks in advance. François

7 years, 1 month

[ANN] Pylint 1.3.1 / Astroid 1.2.1 released

by Claudiu Popa

Hello! I'm happy to announce that Pylint 1.3.1 and Astroid 1.2.1 were released. These releases include some bugfixes with the new string formatting checker and a couple of crash fixes. Please note that Pylint 1.3.X is the last version of Pylint which supports Python 2.5 and 2.6. Enjoy!

7 years, 1 month

pylint traceback AttributeError: 'NoneType' object has no attribute 'scope'

by Mark E. Hamilton

With this test script: % cat test_util.py #!/usr/bin/env python """Some docstring""" import sys if __name__ == '__main__': """Another docstring.""" pass pylint throws this traceback: % pylint --rcfile=/dev/null test_util.py Traceback (most recent call last): File "/projects/sierra/linux_rh6/install/Python/2.7/bin/pylint", line 9, in <module> load_entry_point('pylint==1.3.0', 'console_scripts', 'pylint')() File "/projects/sierra/linux_rh6/install/Python/2.7/lib/python2.7/site-packages/pylint-1.3.0-py2.7.egg/pylint/__init__.py", line 21, in run_pylint Run(sys.argv[1:]) File "/projects/sierra/linux_rh6/install/Python/2.7/lib/python2.7/site-packages/pylint-1.3.0-py2.7.egg/pylint/lint.py", line 991, in __init__ linter.check(args) File "/projects/sierra/linux_rh6/install/Python/2.7/lib/python2.7/site-packages/pylint-1.3.0-py2.7.egg/pylint/lint.py", line 585, in check self.check_astroid_module(astroid, walker, rawcheckers, tokencheckers) File "/projects/sierra/linux_rh6/install/Python/2.7/lib/python2.7/site-packages/pylint-1.3.0-py2.7.egg/pylint/lint.py", line 662, in check_astroid_module walker.walk(astroid) File "/projects/sierra/linux_rh6/install/Python/2.7/lib/python2.7/site-packages/pylint-1.3.0-py2.7.egg/pylint/utils.py", line 804, in walk self.walk(child) File "/projects/sierra/linux_rh6/install/Python/2.7/lib/python2.7/site-packages/pylint-1.3.0-py2.7.egg/pylint/utils.py", line 804, in walk self.walk(child) File "/projects/sierra/linux_rh6/install/Python/2.7/lib/python2.7/site-packages/pylint-1.3.0-py2.7.egg/pylint/utils.py", line 801, in walk cb(astroid) File "/projects/sierra/linux_rh6/install/Python/2.7/lib/python2.7/site-packages/pylint-1.3.0-py2.7.egg/pylint/checkers/base.py", line 558, in visit_discard if (sibling.scope() is scope and AttributeError: 'NoneType' object has no attribute 'scope' Removing the second docstring (see below) resolves this error: % cat test_util.py #!/usr/bin/env python """Some docstring""" import sys if __name__ == '__main__': # """Another docstring.""" pass -- ---------------- Mark E. Hamilton Engineering Sciences Center Senior Member of Technical Staff Sandia National Laboratories 505-844-7666

7 years, 2 months

Pylint output inconsistent

by Mark E. Hamilton

Hi, Why does the 'Statistics by type' move around when I run pylint multiple times? Sometimes it is reported between 'Raw Metrics' and 'Duplication', other times it comes before 'Raw Metrics', and sometimes it comes after the 'Report' section. I can run it four times and get four different orders, without changing anything. -- ---------------- Mark E. Hamilton Engineering Sciences Center Senior Member of Technical Staff Sandia National Laboratories 505-844-7666

7 years, 2 months

Re: [code-quality] [EXTERNAL] Re: How does pylint find files to process

by Mark E. Hamilton

On 08/08/14 13:15, Claudiu Popa wrote: > On Thu, Aug 7, 2014 at 9:57 PM, Mark E. Hamilton <mhamilt(a)sandia.gov> wrote: >> Hi, >> >> I'm having trouble figuring out how pylint finds python files to process. If >> I find() all the .py files in my project and pass them on the command line >> pylint processes them correctly (after I set up PYTHONPATH, of course.) >> >> However, if I just pass my project directory to pylint it fails with: >> >> F: 1, 0: error while code parsing: Unable to load file '.../__init__.py' >> ([Errno 2] No such file or directory: '.../__init__.py') (parse-error) >> >> If I create an empty __init__.py file it works, but only finds and processes >> some of the files. This seems to imply that I need to created __init__.py >> files in my entire tree. Is that the case? >> > > > Yes, that's the case, you need __init__.py files in order to tell > pylint that those are packages. Pylint doesn't support (yet) Python > 3's implicit namespace packages (PEP 420). > FWIW, we're using these versions: ceerws3111a 1123% pylint --version No config file found, using default configuration pylint 1.2.1, astroid 1.1.1, common 0.61.0 Python 2.7.4 (default, Aug 26 2013, 10:48:13) [GCC 4.4.6 20120305 (Red Hat 4.4.6-4)] IAE, perhaps this is just a misunderstanding we have about python. All of our python scripts work, and we've never had __init__.py files in every subdirectory. What you say would imply that even directories which contain no python files have to have a __init__.py file. For instance, if I have this: % find . . ./test_dir1 ./test_dir1/subdir1 ./test_dir1/subdir1/test1.py it seems that I would have to create __init__.py files in '.', test_dir1, and subdir1, even though '.' and test_dir1 don't contain any python files. However, to test this I ran pylint this way: pylint ${PWD} I get the 'Unable to load' error I reported above. This touch __init__.py pylint ${PWD} only processes the __init__.py file, as expected from what you said, and reports a missing-dosctring. However, when I do this pylint throws traceback. touch test_dir1/__init__.py pylint ${PWD} No config file found, using default configuration Traceback (most recent call last): File "/projects/sierra/linux_rh6/install/Python/2.7/bin/pylint", line 9, in <module> load_entry_point('pylint==1.2.1', 'console_scripts', 'pylint')() File "/projects/sierra/linux_rh6/install/Python/2.7/lib/python2.7/site-packages/pylint-1.2.1-py2.7.egg/pylint/__init__.py", line 21, in run_pylint Run(sys.argv[1:]) File "/projects/sierra/linux_rh6/install/Python/2.7/lib/python2.7/site-packages/pylint-1.2.1-py2.7.egg/pylint/lint.py", line 1051, in __init__ linter.check(args) File "/projects/sierra/linux_rh6/install/Python/2.7/lib/python2.7/site-packages/pylint-1.2.1-py2.7.egg/pylint/lint.py", line 608, in check for descr in self.expand_files(files_or_modules): File "/projects/sierra/linux_rh6/install/Python/2.7/lib/python2.7/site-packages/pylint-1.2.1-py2.7.egg/pylint/lint.py", line 638, in expand_files result, errors = expand_modules(modules, self.config.black_list) File "/projects/sierra/linux_rh6/install/Python/2.7/lib/python2.7/site-packages/pylint-1.2.1-py2.7.egg/pylint/utils.py", line 648, in expand_modules submodname = '.'.join(modpath_from_file(subfilepath)) File "/projects/sierra/linux_rh6/install/Python/2.7/lib/python2.7/site-packages/logilab_common-0.61.0-py2.7.egg/logilab/common/modutils.py", line 250, in modpath_from_file filename, ', \n'.join(sys.path))) ImportError: Unable to find module for /ascldap/users/mhamilt/project/test_dir1/__init__.py in /home/mhamilt, /projects/sierra/linux_rh6/install/Python/2.7.4/bin, ... Creating __init__.py in subdir1 doesn't resolve this traceback, nor does creating a python file in test_dir1. However, setting PYTHONPATH to this export PYTHONPATH=${PWD}/test_dir1 pylint ${PWD} does resolve the traceback, and pylint processes the two __init__.py files. Finally, doing this touch test_dir1/subdir1/__init__.py % find . . ./test_dir1 ./test_dir1/__init__.py ./test_dir1/subdir1 ./test_dir1/subdir1/test1.py ./test_dir1/subdir1/__init__.py ./test_dir2 ./test_dir2/subdir2 ./test_dir2/subdir2/test2.py ./__init__.py pylint ${PWD} works, processes all three __init__.py files and the test1.py file. If I unset PYTHONPATH the traceback returns. I don't understand: 1. Why pylint is throwing a traceback 2. Why setting PYTHONPATH to the directory in the middle is necessary. 3. Why creating all those __init__files is necessary. -- ---------------- Mark E. Hamilton Engineering Sciences Center Senior Member of Technical Staff Sandia National Laboratories 505-844-7666

7 years, 2 months

Custom pylint checkers for Python 2/3 compatibility

by Claudiu Popa

Hello Brett. At a quick glance, the patch looks really good, even with the scarce documentation that we have. :-) Maybe you can turn this into a pull request for Pylint, so that we may have in the near future a mode that only checks Python 2/3 compatibility? That way would be easier for review, too. Thank you.

7 years, 2 months

How does pylint find files to process

by Mark E. Hamilton

Hi, I'm having trouble figuring out how pylint finds python files to process. If I find() all the .py files in my project and pass them on the command line pylint processes them correctly (after I set up PYTHONPATH, of course.) However, if I just pass my project directory to pylint it fails with: F: 1, 0: error while code parsing: Unable to load file '.../__init__.py' ([Errno 2] No such file or directory: '.../__init__.py') (parse-error) If I create an empty __init__.py file it works, but only finds and processes some of the files. This seems to imply that I need to created __init__.py files in my entire tree. Is that the case? -- ---------------- Mark E. Hamilton Engineering Sciences Center Senior Member of Technical Staff Sandia National Laboratories

7 years, 2 months

2021

2020

2019

2018

2017

2016

2015

2014

2013

code-quality August 2014