Mailman 3 October 2015 - code-quality

Moving pylint/astroid to GitHub
by Florian Bruhin 07 Dec '15

07 Dec '15

Hey, what do you think about moving pylint and astroid from Bitbucket/hg to GitHub/git? I've briefly talked with Claudiu about this, and he seems open to the idea and suggested I write this mail :) If people agree, I'll be able to move issues (including the correct issue numbers) and the repository (including tags/branches). I recently helped doing the same for pytest: https://bitbucket.org/pytest-dev/pytest/issues/699/ Unfortunately, I didn't find a good way to migrate pull requests, so those would've been to be recreated by their authors. Some rationales, from my point of view: - GitHub has the bigger exposure, and more people are familiar with it than with Bitbucket - this potentially means more contributors. - Contributing is IMHO cumbersome with Bitbucket. Apparently, one's supposed to use bookmarks instead of branches (because branches can't be deleted, IIRC), but Bitbucket doesn't support doing pull requests with them - the "solution" Bitbucket uses when editing things with the online editor is to create a new fork for every change, by the way... I also tried to find documentation for basic stuff like "how do I contribute to a project with branches and PRs", and found it very difficult. Sure, I'm used to git, but getting started with git was a lot easier than with hg/bitbucket. - Travis CI[1] is a lot better than drone.io, the current CI system in use. For example, one is able to test PRs, which is something essential in a CI IMHO (and also makes contributing easier). I don't think I need to elaborate on that :) - There's also a lot of other potentially useful tooling which is available for GitHub, but not BitBucket - see point 1 (bigger exposure). [1] https://travis-ci.org/ My plan would be to create a pylint organization on GitHub and move the repos and issues there. Opinions? Florian -- http://www.the-compiler.org | me(a)the-compiler.org (Mail/XMPP) GPG: 916E B0C8 FD55 A072 | http://the-compiler.org/pubkey.asc I love long mails! | http://email.is-not-s.ms/

4 8

Reporting a bug in pyflakes
by Marcin Gozdalik 30 Oct '15

30 Oct '15

Hi I'd like to report a bug in pyflakes (I erroneously reported it against flake8 - https://gitlab.com/pycqa/flake8/issues/96), but it seems that https://github.com/pyflakes/pyflakes/issues only allows pull requests. How should I report bug in pyflakes? Best regards, Marcin

2 1

Re: [code-quality] Flake8 in python script?
by Carl Crowder 23 Oct '15

23 Oct '15

Hi all, author of Prospector here. It's definitely not an alternative to pylint or flake8, it's just a convenience wrapper. The entire point was just to make it a bit easier to get started as not everyone wants to spend the time configuring every tool. The idea is to be a "gateway drug" to bridge the gap between no code quality tooling and having everything configured perfectly for your particular project. As a "code quality newbie" you're sort of the target market, but I encourage you to dig deeper if you get benefits from prospector as you will get more benefits by tuning each tool yourself to fit your particular style of coding! Cheers, Carl On 22 October 2015 at 21:27, Linus Törngren <linus(a)etnolit.se> wrote: > I do, but as I understand it prospector aggregates (optionally) the results > of pylint, pyflakes, mccabe, dodgy, pep8 and pep257. It also has a bunch of > profiles with settings for the different tools. That’s attractive for a code > quality newbie like me. > > 22 okt. 2015 kl. 21:16 skrev Claudiu Popa <pcmanticore(a)gmail.com>: > > On Thu, Oct 22, 2015 at 8:03 PM, Peter Bittner <peter.bittner(a)gmx.net> > wrote: > > Strictly speaking, Prospector isn't an alternative to flake8, but to > PyLint. The verbosity of PyLint with default settings is the main > critique of Prospector's author. He's running a nice service, by the > way, Landscape. Very nice and free for Open Source projects. > https://landscape.io/ > > > You do realize that Prospector is using Pylint as its underlying > technology? Can't really consider it an alternative in this case: > http://prospector.readthedocs.org/en/master/ > > > > _______________________________________________ > code-quality mailing list > code-quality(a)python.org > https://mail.python.org/mailman/listinfo/code-quality >

1 0

flake8 && python 3.5.0
by Luis San Martin 22 Oct '15

22 Oct '15

Hello, It seems asyncio syntax is not considered for python 3.5. I couldn't find any reported issue regarding this i.e. I'm on flake8 (2.4.1) with python 3.5.0. Just cloned https://github.com/dabeaz/curio.git and got this. pathcl@sid:~/src/curio$ flake8 ./curio/file.py Traceback (most recent call last): File "/home/pathcl/.pyenv/versions/3.5.0/bin/flake8", line 11, in <module> sys.exit(main()) File "/home/pathcl/.pyenv/versions/3.5.0/lib/python3.5/site-packages/flake8/main.py", line 33, in main report = flake8_style.check_files() File "/home/pathcl/.pyenv/versions/3.5.0/lib/python3.5/site-packages/pep8.py", line 1672, in check_files runner(path) File "/home/pathcl/.pyenv/versions/3.5.0/lib/python3.5/site-packages/flake8/engine.py", line 95, in input_file return fchecker.check_all(expected=expected, line_offset=line_offset) File "/home/pathcl/.pyenv/versions/3.5.0/lib/python3.5/site-packages/pep8.py", line 1412, in check_all self.check_ast() File "/home/pathcl/.pyenv/versions/3.5.0/lib/python3.5/site-packages/pep8.py", line 1358, in check_ast checker = cls(tree, self.filename) File "/home/pathcl/.pyenv/versions/3.5.0/lib/python3.5/site-packages/flake8/_pyflakes.py", line 43, in __init__ withDoctest=self.withDoctest) File "/home/pathcl/.pyenv/versions/3.5.0/lib/python3.5/site-packages/pyflakes/checker.py", line 294, in __init__ self.handleChildren(tree) File "/home/pathcl/.pyenv/versions/3.5.0/lib/python3.5/site-packages/pyflakes/checker.py", line 547, in handleChildren self.handleNode(node, tree) File "/home/pathcl/.pyenv/versions/3.5.0/lib/python3.5/site-packages/pyflakes/checker.py", line 589, in handleNode handler(node) File "/home/pathcl/.pyenv/versions/3.5.0/lib/python3.5/site-packages/pyflakes/checker.py", line 812, in CLASSDEF self.handleNode(stmt, node) File "/home/pathcl/.pyenv/versions/3.5.0/lib/python3.5/site-packages/pyflakes/checker.py", line 588, in handleNode handler = self.getNodeHandler(node.__class__) File "/home/pathcl/.pyenv/versions/3.5.0/lib/python3.5/site-packages/pyflakes/checker.py", line 458, in getNodeHandler self._nodeHandlers[node_class] = handler = getattr(self, nodeType) AttributeError: 'FlakesChecker' object has no attribute 'ASYNCFUNCTIONDEF' What is going wrong? -- Luis San Martin R. User #333411 linuxcounter.net

2 1

Flake8 in python script?
by Linus Törmgren 22 Oct '15

22 Oct '15

Hi, I would like to use flake8 from within Python script but I can't find any hint in the docs on how to do this? For instance, with pylint I can do a "from pylint import epylint as lint" and then run the linter with "lint.run()". Kind regards Linus Törngren

3 2

Fwd: Re: Question about pylint plugin
by Michel RENON 20 Oct '15

20 Oct '15

[resent because I forgot to answer to list] > [...] > Hi Michel, > > Your checker needs to define at least one message in order > to be executed. For instance, adding a dummy msg such as > msgs = {'E9999': ('a', 'b', 'c')} makes it run as expected. > > > Hope this helps, > Claudiu. > Thanks a lot !! A simple warning ("no message defined in checker") would have saved me hours of debug ! Should I file a bug/request ? Michel

1 0

Question about pylint plugin
by Michel RENON 20 Oct '15

20 Oct '15

Hi, I'm trying to write a pylint checker and I have a problem. Based on several examples found on internet, I wrote a checker skeleton. It is loaded, but it never get called to check. In the following example, the '__init__()' method is called, but other methods 'open()', 'visit_class()', 'visit_function()' and 'visit_callfunc()' are never called. As the checker is loaded, it's not a problem in the pylint command. Do you have any clues to solve that problem ? Here are the 3 files (all stored in the same folder): first, the checker : "fields_checker.py" 8<----------------------------------------- import astroid from pylint.interfaces import IAstroidChecker from pylint.checkers import BaseChecker class MyFieldsChecker(BaseChecker): """Checks for my fields """ __implements__ = (IAstroidChecker,) name = 'my-fields-checker' msgs = {} def __init__(self, linter=None): BaseChecker.__init__(self, linter) print("MyFieldsChecker.__init__()") def open(self): print("MyFieldsChecker.open() ") def visit_attribute(self, node): print("MyFieldsChecker.visit_Attribute : {}".format(dir(node))) self.generic_visit(node) def visit_class (self, node): print("MyFieldsChecker.visit_class : {}".format(dir(node))) self.generic_visit(node) def visit_function(self, node): print("MyFieldsChecker.visit_function : {}".format(dir(node))) self.generic_visit(node) def visit_callfunc(self, node): print("MyFieldsChecker.visit_callfunc : {}".format(dir(node))) self.generic_visit(node) def register(linter): """required method to auto register this checker """ print("DEBUG register MyFieldsChecker") linter.register_checker(MyFieldsChecker(linter)) 8<----------------------------------------- then the pylint command, executed on Ubuntu 14.04 : "do.sh" 8<----------------------------------------- PYTHONPATH=${PYTHONPATH}:$(pwd) export PYTHONPATH pylint --load-plugins=fields_checker -r n test.py 8<----------------------------------------- and just fyi, the tested python file : "test.py" 8<----------------------------------------- def method1(p, q, r): print p, q, r method1('a', 'b', 'c') class Test(object): def __init__(self): self.f1 = "a" _myfields = { 'f2' : "azerty", } t = Test() 8<----------------------------------------- and the result : 8<----------------------------------------- $ sh do.sh DEBUG register MyFieldsChecker MyFieldsChecker.__init__() ************* Module test C: 1, 0: Missing module docstring (missing-docstring) C: 3, 0: Invalid argument name "p" (invalid-name) C: 3, 0: Invalid argument name "q" (invalid-name) C: 3, 0: Invalid argument name "r" (invalid-name) C: 3, 0: Missing function docstring (missing-docstring) C: 12, 8: Invalid attribute name "f1" (invalid-name) C: 9, 0: Missing class docstring (missing-docstring) R: 9, 0: Too few public methods (0/2) (too-few-public-methods) C: 21, 0: Invalid constant name "t" (invalid-name) 8<----------------------------------------- Thanks, Michel

2 1

How to tell pylint about base class attributes?
by Skip Montanaro 19 Oct '15

19 Oct '15

I'm linting a piece of code containing a class which inherits from a base class which is not available at lint time. Consequently, I get all sorts of messages about unknown attributes which the subclass uses from its parent. Short of completely disabling E1101 (no-member), is there a way to say, "class B, a subclass of class A which you can't see, really does have an attribute named x"? The code for class A is not going to be available, as I'm just running pylint in isolation from the rest of the environment in which it is run. Thx, Skip Montanaro

2 1

(no subject)
by Luis San Martin 19 Oct '15

19 Oct '15

Hello, I've tried pep8 and flake8 on python 3.6.0a0 though both will not work. pathcl@sid:~/src$ flake8 Traceback (most recent call last): File "/home/pathcl/.pyenv/versions/3.6-dev/bin/flake8", line 7, in <module> from flake8.main import main File "/home/pathcl/.pyenv/versions/3.6-dev/lib/python3.6/site-packages/flake8/main.py", line 8, in <module> from flake8.engine import get_parser, get_style_guide File "/home/pathcl/.pyenv/versions/3.6-dev/lib/python3.6/site-packages/flake8/engine.py", line 6, in <module> import pep8 File "/home/pathcl/.pyenv/versions/3.6-dev/lib/python3.6/site-packages/pep8.py", line 1204, in <module> init_checks_registry() File "/home/pathcl/.pyenv/versions/3.6-dev/lib/python3.6/site-packages/pep8.py", line 1203, in init_checks_registry register_check(function) File "/home/pathcl/.pyenv/versions/3.6-dev/lib/python3.6/site-packages/pep8.py", line 1186, in register_check args = inspect.getargspec(check)[0] AttributeError: module 'inspect' has no attribute 'getargspec' it seems getargspec is going to be deprecated. https://docs.python.org/3.6/whatsnew/3.6.html#removed Kind regards -- Luis San Martin R. User #333411 linuxcounter.net

2 2

Re: [code-quality] code-quality Digest, Vol 32, Issue 4
by Cara 16 Oct '15

16 Oct '15

> what do you think about moving pylint and astroid from Bitbucket/hg to > GitHub/git? I've briefly talked with Claudiu about this, and he seems > open to the idea and suggested I write this mail :) I vote in favor, principally because of the CI issue. I find Github's interface easier to use, though not by enough to make me care much, and I'm not attached to Mercurial or Git, but drone.io is the source of persistent problems for me when working on astroid because it runs ancient software. Apparently it's still on Mercurial 2.0, and the latest Python version it supports is 3.3. Since most people who use Python 3 at all use the latest release, having a CI that's two full versions behind undercuts the point of having a CI in the first place, since drone.io isn't even testing the Python 3 version most users have. Cara

1 0