code-quality May 2021

code-quality@python.org

13 participants
7 discussions

Prospector maintenance
by Stéphane Brunner 01 Jun '21

01 Jun '21

Hello, I don't see any committer that is active on the Prospector project, I'm I right? If yes, is there any plan to maintain this project? Sincerely, Stéphane -- *Stéphane Brunner* Geospatial Solutions Software Developer *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS camptocamp.com mapfish.org

4 4

Pyside2, QAbstractItemModel subclassed setData and changedData.emit()
by Ed Lipson 31 May '21

31 May '21

I'm writing pyside2 code, using the QAbstractItemModel class. I've subclassed setData. The pyside2 doc says to explicitly emit the changedData signal if this is done. QAbstractItemModel — Qt for Python <https://doc.qt.io/qtforpython-5/PySide2/QtCore/QAbstractItemModel.html#subc…> pylint does not see the emit() method and the error needs to be suppressed: self.dataChanged.emit(index, index) # pylint: disable=E1101 { "resource": "xxx/src/main/python/models/mdl_abstbl_banktran.py", "owner": "python", "code": "no-member", "severity": 8, "message": "Method 'dataChanged' has no 'emit' member", "source": "pylint", "startLineNumber": 451, "startColumn": 17, "endLineNumber": 451, "endColumn": 17 } In a message with pyside2 support, they think the emit() member should be findable, being written here https://code.qt.io/cgit/pyside/pyside-setup.git/tree/sources/pyside6/libpys… Is this an artifact of the python/c++ nature of the pyside implementation? Thanks, Ed

1 0

used-before-assignment warning with :=
by Ed Lipson 31 May '21

31 May '21

I was running pylint (2.6.0) in VS Code against a module, the code was working. if (amt := self._data[index.row()][index.column()]) \ and float(amt) < 0.0: return QColor('red') I got the above error and had to change it to the below to clear the error. amt = self._data[index.row()][index.column()] if amt and float(amt) < 0.0: return QColor('red') I had thought the walrus was implemented to foster this style of code. Thanks, Ed

4 3

PyFlakes and function calls
by Ethan Furman 21 May '21

21 May '21

Greetings! I have the following function: def _convert_auto(self, value): if value.args or value.kwds or value.value is _auto_null: ... if source_len < target_len : prev_values = [] ... gnv = self._generate_next_value if self._auto_args: ... values = gnv(key, self._start, len(self._member_names), prev_values, *values) else: values = gnv(key, self._start, len(self._member_names), prev_values) ... return value Towards the bottom there are two calls that both start with values = gnv(key, self._start, ... The variable `key` does not exist -- is PyFlakes supposed to catch that? -- ~Ethan~

1 0

asking for option in Pyflakes --> handling Python built-in regex operations
by Beat Weiss 21 May '21

21 May '21

Hi there, First, thanks for all your time and effort. Guys like me, which aren't professional programmers, would produce spaghetti code for ever without YOU! I just started using Pyflakes and got a lot of warnings in respect to "main.py:168:20 're' may be undefined, or defined from star imports: modules.testbus" the specific line contains "re.search("Byte Array", self.getFormat(), re.I)" In this case Pyflakes warns about the built-in regex operation re.search. And in my case this are many code lines. Therefore I'd like to have a switch to ignore this warning or maybe Pyflakes can recognize the built-in regex operations? Kind regards, Beat Weiss Adv Senior Engineer Cloud FPGAs & Tape Phone: +41 44 724 82 66 Fax: +41 44 724 89 59 E-mail: wei(a)zurich.ibm.com www.zurich.ibm.com IBM Reserach Europe Saeumerstrasse 4 Rueschlikon, 8803 Switzerland This email may contain confidential information, intended for the recipient specified above only. It is strictly forbidden to share any part of this message with any third party, without a written consent of the sender. If you received this message by mistake, please reply to this message and follow with its deletion, so that we can ensure such a mistake does not occur in the future.

2 2

Bandit customization
by Maxim Mosharov 15 May '21

15 May '21

3 5

pre-commit, black, isort. how to use with pylint?
by Eli Simhayev 12 May '21

12 May '21

Hi, Firstly, thank you for the awesome work. Currently I’m using pre-commit with black, isort and another small hooks. What the preferable way to integrate pylint (in terms of workflow) in my use-case? Thank you [cid:image001.jpg@01D7471F.DAD3F080]<https://beyondminds.ai/> Eli Simhayev Machine Learning Engineer [cid:image003.png@01D7471F.DAD3F080]<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.linke…>[cid:image004.png@01D7471F.DAD3F080]<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.c…> The contents of this email message and any attachments are intended solely for the addressee(s) and may contain confidential and/or privileged information of BeyondMinds and may be legally protected from disclosure. If you are not the intended recipient of this message or their agent, or if this message has been addressed to you in error, please immediately alert the sender by reply email and then delete this message and any attachments. If you are not the intended recipient, you are hereby notified that any use, dissemination, copying, or storage of this message or its attachments is strictly prohibited.

3 5

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

code-quality May 2021