code-quality

Download

code-quality@python.org

December 2021

2 participants
2 discussions

How to start managing cyclomatic complexity for legacy code
by Andrey Solomatin Dec. 15, 2021

Dec. 15, 2021

Hi, I have a codebase with high cyclomatic complexity (mono repo with services and deployment scripts). I want to start managing its complexity. The good option is to add # noqa: C901 for each function that has high complexity. This solves the problem that new functions will be written in a good way. But the problems with the existing one are still there. 1) If your function has a bad complexity you can grow it further. If your script has a single function that means you don't control the complexity at all. 2) When the function is refactored it's a good chance that the suppression won't be removed. So it could grow back. I am looking for a solution to these problems. In general, it could look like the mapping between function name and current complexity. We check for exact matches and fix the function or mapping. So the complexity won't grow from one side, and suppression will always be actual. The mapping could be implemented by adding a number to the suppression comment or via a config file. If the solution for my problem doesn't exist yet, I could implement it myself. (code, tests, documentation, helper scripts, etc.) Best regards, Andrey Solomatin

1 0

pylint and embedded python
by Ivan Baidakou Dec. 9, 2021

Dec. 9, 2021

Hi, My company is using python embedded into an application. Is it possible to use pylint in unit tests, like the following: from pylint import epylint as lint lint.py_run('../lib/lib.py --rcfile=../pylint.rc') I have tried that one, but I get a strange error: Traceback (most recent call last): File "<string>", line 1, in <module> File "/home/b/development/euryale-module-py/build.debug/py/py_lib/site-packages/pylint/lint/__init__.py", line 76, in <module> from pylint.lint.parallel import check_parallel File "/home/b/development/euryale-module-py/build.debug/py/py_lib/site-packages/pylint/lint/parallel.py", line 8, in <module> from pylint import reporters File "/home/b/development/euryale-module-py/build.debug/py/py_lib/site-packages/pylint/reporters/__init__.py", line 27, in <module> from pylint import utils File "/home/b/development/euryale-module-py/build.debug/py/py_lib/site-packages/pylint/utils/__init__.py", line 47, in <module> from pylint.utils.ast_walker import ASTWalker File "/home/b/development/euryale-module-py/build.debug/py/py_lib/site-packages/pylint/utils/ast_walker.py", line 7, in <module> from astroid import nodes File "/home/b/development/euryale-module-py/build.debug/py/py_lib/site-packages/astroid/__init__.py", line 51, in <module> from astroid.nodes import node_classes, scoped_nodes File "/home/b/development/euryale-module-py/build.debug/py/py_lib/site-packages/astroid/nodes/__init__.py", line 27, in <module> from astroid.nodes.node_classes import ( # pylint: disable=redefined-builtin (Ellipsis) File "/home/b/development/euryale-module-py/build.debug/py/py_lib/site-packages/astroid/nodes/node_classes.py", line 47, in <module> from astroid import decorators, mixins, util File "/home/b/development/euryale-module-py/build.debug/py/py_lib/site-packages/astroid/decorators.py", line 36, in <module> from typing import ParamSpec ImportError: cannot import name 'ParamSpec' from 'typing' (/home/b/development/euryale-module-py/build.debug/py/py_lib/typing.py) After digging a bit, I think that somehow pylint is trying to use *python* executable (from PATH), because my host python is 3.10, while the embedded python is 3.9 and there is no python executable at all. My question is: is there a pylint API to let it check sources with the current python, without doing system/exec etc., which are not available in my case? WBR, basiliscos.

1 0