Mailman 3 April 2021 - Twisted

[Twisted-Python] Buildbot downtime
by Tom Prince 03 Mar '22

03 Mar '22

I am plannig to upgrade twisted's buildbot in the near future. In preperation for that, I am going to take down the production buildbot on Tuesday, June 26, around 1600 UTC[1]. During that time, the result of any builds done will be lost. Thus, I'd ask that people avoid committing to trunk during that time. I will send a reminder before I take down the buildbot both here, and on #twisted and #twisted-dev. Tom [1] http://timeanddate.com/worldclock/meetingtime.html?iso=20120626&p1=80&p2=22…

2 8

[Twisted-Python] Weekly Bug Summary
by trac＠twistedmatrix.com 27 Oct '21

27 Oct '21

5 5

[Twisted-Python] Twisted v21.2.0 breaks Crossbar.io
by Tobias Oberstein 24 Aug '21

24 Aug '21

Hi all, rgd Twisted v21.2.0, thanks a lot to all involved in this release! the release, mypy, more py3, .. +1! really appreciated. now, fwiw, just wanted to let you know (sorry, too late) about a regression with https://github.com/crossbario/crossbar that actually originates from https://github.com/crossbario/autobahn-python/issues/1470 => with Twisted v20.3.0 calling twisted.internet.protocol.ProcessProtocol.getPeer raises an AttributeError with Twisted v21.2.0 calling the same method raises an NotImplementedError => this fix broke our workaround for the bug now fixed;) https://github.com/crossbario/autobahn-python/pull/1469/files and released in: https://pypi.org/project/autobahn/21.3.1/ https://pypi.org/project/crossbar/21.3.1/ Cheers, /Tobias

7 15

[Twisted-Python] Twisted Python 0.7.0 Prerelease Testing
by Glyph Lefkowitz 05 Aug '21

05 Aug '21

hi there, folks: I'd really like to release 0.7.0 but I would like it to be at least a little bit tested before I do so. Could those of you with CVS trees check everything out and see if it performs as advertised? Deeper bugs than that will have to wait for the next release, but I'd at least like to know if it works for someone other than me. Thanks. ______ __ __ _____ _ _ | ____ | \_/ |_____] |_____| |_____| |_____ | | | | @ t w i s t e d m a t r i x . c o m http://www.twistedmatrix.com/~glyph/

4 5

[Twisted-Python] Strange recursion error with twisted.web
by Peter Westlake 16 Jun '21

16 Jun '21

I'm getting a "maximum recursion depth exceeded" error that appears to be coming from flatten(). The odd thing is that it only happens sometimes. The HTML that's being flattened does have a few Deferreds in it. Those come from function calls, which cache the results, which might explain why I only see the error on the first visit to the page (as far as I can tell). The system recursion limit is the standard 1000. My HTML is only nested a few tags deep, two orders of magnitude short of that. Is there anything about the way flatten() works that might cause this behaviour? Peter.

4 15

[Twisted-Python] Does anyone know why trunk is failing CI on PyPy 7.3.4?
by Wim Lewis 02 May '21

02 May '21

TLDR: Twisted appears broken on PyPy 7.3.4 (aka "3.7.10")? I don't have time right now to set up a PyPy-capable environment and try to reproduce this, but perhaps someone does? Long version: Trunk has been broken since the last merge a week or so ago, but I don't think the breakage is due to that merge. As an experiment I made a PR based off the last successful version of trunk, with a whitespace change, and it now fails CI as well. So I think the failure must be due to some change that isn't in Twisted or controlled-for by tox. The failure in all cases is in the pypy-3.7-alldeps-nocov-posix task. Unlike our usual CI problems it doesn't seem to be a random failure: it fails all the time in the same place. But the place doesn't make sense to me. It's in the IRC CTCP tests, and they fail in the same ways each time (an expected response is not received). The pair of CI runs closest to the change are these: run 5793: https://github.com/twisted/twisted/runs/2328450554 run 5809: https://github.com/twisted/twisted/runs/2360415474 There are a lot of differences, but sys.version went from 3.7.9 to 3.7.10 between those runs, so that seems like the most likely culprit. Last working: > sys.version : 3.7.9 (7e6e2bb30ac5, Nov 18 2020, 10:55:52) > [PyPy 7.3.3-beta0 with GCC 7.3.1 20180303 (Red Hat 7.3.1-5)] > sys.prefix : /opt/hostedtoolcache/PyPy/3.7.9/x64 > sys.exec_prefix : /opt/hostedtoolcache/PyPy/3.7.9/x64 > sys.executable : /opt/hostedtoolcache/PyPy/3.7.9/x64/bin/python First broken: > sys.version : 3.7.10 (51efa818fd9b, Apr 04 2021, 11:22:34) > [PyPy 7.3.4 with GCC 7.3.1 20180303 (Red Hat 7.3.1-5)] > sys.prefix : /opt/hostedtoolcache/PyPy/3.7.10/x64 > sys.exec_prefix : /opt/hostedtoolcache/PyPy/3.7.10/x64 > sys.executable : /opt/hostedtoolcache/PyPy/3.7.10/x64/bin/python PyPy's release notes for 7.3.4 don't list anything that jumps out at me: https://doc.pypy.org/en/latest/whatsnew-pypy3-7.3.4.html My guess would be some latent timing bug in Twisted that was uncovered by pypy execution time changes (I don't imagine that the CTCP code gets exercised very heavily these days) or perhaps PyPy got a bug. Wim.

3 6

[Twisted-Python] startTLS errors not propagating to Factory
by Richard van der Hoff 29 Apr '21

29 Apr '21

Hi folks, I've been investigating https://github.com/matrix-org/synapse/issues/9566, which amounts to: "when there is a TLS error connecting to the SMTP server, the resultant exception is unreadable". I think I've traced the problem to the fact that SMTPSenderFactory.clientConnectionFailed is being called with an unhelpful ConnectionAborted rather than anything more descriptive. I've then reproduced that with a simpler test case: see https://gist.github.com/richvdh/909761ff5dab23f0873eeddd7936a740. As you can see, the output is: "Factory lost connection. Reason: Connection was aborted locally using ITCPTransport.abortConnection." This seems to be thanks to TLSMemoryBIOProtocol.failVerification, which stashes the error and calls abortConnection(): https://github.com/twisted/twisted/blob/trunk/src/twisted/protocols/tls.py#…. At this point I'm struggling. Is the SMTP code holding the Factory wrong? Or is it reasonable to expect the verification error to propagate into clientConnectionFailed - in which case, how could this work? Thanks for your thoughts! Richard

2 5

[Twisted-Python] IDNA problem in twisted
by Barry Scott 29 Apr '21

29 Apr '21

We just added a patch to our twisted to prevent twisted from doing idna validation. _idnaBytes and _idnaText not convert from bytes to unicode based on the type of the provided arg. We had to do this because there are domain names that youtube.com uses that are not valid under IDNA-2008 https://tools.ietf.org/html/rfc5891#section-4.2.3.1 For example this URL: https://r2---sn-aigzrn7e.googlevideo.com/generate_204 Firefox is happy to visit this URL and does not change it when its enter in the address bar. The comment in the _idna.py code that say this: "Convert some text typed by a human into some ASCII bytes." and "Convert some IDNA-encoded octets into some human-readable text" The key idea here is that its human input that will be converted. But the code is used deep in the _sslverify.py where no human input is entered. I can see why a UI would need to do IDNA-2008 converts and validation but I'm not clear why its of value deep in the guts of twisted. Why is this code needed at all in twisted? If its for a high level API then why isn't it being called at the edge of the high level API calls? Barry

3 3

[Twisted-Python] Weekly Bug Summary
by trac＠twistedmatrix.com 25 Apr '21

25 Apr '21

1 0

[Twisted-Python] Weekly Bug Summary
by trac＠twistedmatrix.com 18 Apr '21

18 Apr '21

1 0