Mailman 3 November 2002 - Twisted

[Twisted-Python] docstring, whitespace patch for twisted.internet.interfaces.py
by Anthony Baxter Nov. 24, 2002

Nov. 24, 2002

added param lines.

1 0

[Twisted-Python] test_names (and others!)
by Jp Calderone Nov. 24, 2002

Nov. 24, 2002

First, the new dataReceived method of IRCClient is breaking unit tests. It's not obvious to me whether the method should be removed or the test should be updated. Second, I've re-enabled test_names. It still fails. It fails due to my inability to understand the proper way to set things up and tear them down, though, not because t.names is broken :) If someone who feels confident of their pyunit skills could take a look, and give me some suggestions on how to resolve the issue it's having, that'd be great. Jp -- In the days when Sussman was a novice Minsky once came to him as he sat hacking at the PDP-6. "What are you doing?" asked Minsky. "I am training a randomly wired neural net to play Tic-Tac-Toe." "Why is the net wired randomly?" asked Minsky. "I do not want it to have any preconceptions of how to play." Minsky shut his eyes. "Why do you close your eyes?" Sussman asked his teacher. "So the room will be empty." At that moment, Sussman was enlightened. -- 2:08am up 22 days, 13:02, 6 users, load average: 0.08, 0.10, 0.09

1 0

SMTP patches (was Re: [Twisted-Python] mail and web server authentication: yet to come or already there?)
by Anders Hammarquist Nov. 22, 2002

Nov. 22, 2002

In a message of Fri, 22 Nov 2002 12:10:04 +1100, Andrew Bennetts writes: >Ah, ok. Looks good to me, but I'm not the SMTP maintainer, so that doesn't >count for much... in general, I believe we aim to be "liberal in what we >accept, and strict in what we send" to maximise interoperability, so this >patch seems fine. Does Moshe or Itamar want to express an opinion here? :) Not that I fit the names, but I've been working with them on improving the SMTP server. I posted a patch a few weeks ago which solves this and some other problems. If anyone wants a copy of the patch, just mail me and ask for it. (It has evolved somewhat since the last posted version, mostly in terms of the unit tests). /Anders -- -- Of course I'm crazy, but that doesn't mean I'm wrong. Anders Hammarquist | iko(a)cd.chalmers.se Physics student, Chalmers University of Technology, | Hem: +46 31 88 48 50 G|teborg, Sweden. RADIO: SM6XMM and N2JGL | Mob: +46 707 27 86 87

2 1

Re: [Twisted-Python] mail and web server authentication: yet to come or already there?
by Stefano Debenedetti Nov. 21, 2002

Nov. 21, 2002

Andrew Bennetts wrote: > Note also that we distribute Win32 installers for released versions, like > 1.0.0, and soon also for 1.0.1, and these include prebuilt C modules. :-) if it was for the installer I would still be stuck with the echo example, to make it clear for people browsing the mail archives in order to find a solution for that, like I did, the windows installer doesn't work. > It might be worth attaching the full output and your test.log file to a bug > report in our Sourceforge bug tracker, so we can't forget about them :) test.log? doh, I should have noticed that before! :-) I'll do that as soon as SF comes up again thanks, ciao ste

1 0

Re: [Twisted-Python] mail and web server authentication: yet to come or already there?
by Stefano Debenedetti Nov. 21, 2002

Nov. 21, 2002

Hello Andrew, thanks a lot for the answer, I write some more comments inline: Andrew Bennetts wrote: > On Wed, Nov 20, 2002 at 09:42:08PM +0100, Stefano Debenedetti wrote: >>(is HTTP >>basic auth implemented somewhere btw?) > > I *think* twisted.web.guard has this functionality... I've heard it's going > to be overhauled at some point, it's not as nice as it could be. Unfortunately this seems to handle authentication at an application level while I need to use HTTP protocol authentication mechanisms, ok I'll have to give it a go myself. > I'm even less of a twisted.mail expert than a twisted.web expert, but I > think that twisted.mail's auth stuff predates twisted.cred, and we haven't > had time to migrate it to twisted.cred yet. Again, I'm going to try and do that, of course it would be easier if I had some more samples of twisted.cred I could start from :-) > Hmm. That looks like a dubious change to me. Wouldn't that fail for > headers like: > To: Mr. Example <dude(a)example.com> > > I'm not familiar with smtp.py though... :-) seems you are victim of a similar misunderstanding of SMTP that I had until recently: MAIL FROM and RCPT TO can only specify a mail address (in angle brackets). Headers like: To: Mr. Example <dude(a)example.com> go after the DATA command so they are not affected by this modification. Indeed the current code is already handling RFC821 correctly, as that RFC doesn't allow to put spaces after the column and before the first angle bracket but I have at least one mailer that does that and I've seen other SMTP implementations that forgive that (for example see [1]), so I'll post my patch here again: $ diff -u smtp.py_orig smtp.py --- smtp.py_orig 2002-11-01 05:47:10.000000000 +0100 +++ smtp.py 2002-11-22 00:04:24.000000000 +0100 @@ -122,7 +122,7 @@ self.transport.loseConnection() def do_MAIL(self, rest): - from_ = rest[len("MAIL:<"):-len(">")] + from_ = rest[string.find(rest, "<")+1:-len(">")] self.validateFrom(self.__helo, from_, self._fromValid, self._fromInvalid) @@ -134,7 +134,7 @@ self.sendCode(550, 'No mail for you!') def do_RCPT(self, rest): - to = rest[len("TO:<"):-len(">")] + to = rest[string.find(rest, "<")+1:-len(">")] user = User(to, self.__helo, self, self.__from) self.validateTo(user, self._toValid, self._toInvalid) If you think it is not correct to be forgiving towards non-RFC-compliant mailers, fine but IMHO some modifications to the existing code should be done anyway, otherwise mailers that send that space won't receive any error message and think everything went OK but twisted.mail won't be able to send the mail because as things are now it will try to send it to: "<dude(a)example.com" therefore failing silently (from sender's perspective). > 1. Twisted doesn't require any C modules to be compiled -- they're basically > just optional speed-ups. In fact the only C module in Twisted that works > on Windows is cBanana; cReactor and portmap don't apply to Windows > because it doesn't have the relevant APIs. > > 2. I've heard it's possible to use the mingw port of gcc to compile python > extensions... search comp.lang.python or google for details. Yes but the setup.py installer tries to compile at least cBanana and fails if that fails. I tried to use mingw but I end up with a long list of compilation errors, I am probably still doing something wrong and by googling I get to three or four fairly different explanations of how to do that so I guess it's still not as straightforward as a dummy user like me would require, anyway if it's not important I'll leave that aside for now :-) So even at the second attempt the only way to run the Twisted installer for me was to remove the parts of setup.py that mention external modules, that makes me feel like a bad boy but I found no other solution. > Eek. The UI shouldn't crash, but regardless usually I use "runtests -t", > i.e. run in text mode. > > Unfortunately Win32 support isn't 100% -- which tests are failing for you? Thanks for the -t tip. I found out that the testcases hang only if I use the cygwin python and that they behave differently if I run them with the -t flag, I copy here (by hand) the outputs of the graphical UI, both under cygwin and with regular python: under cygwin the graphical UI hangs while running test #155, with 181 tests remaining, after notifying the following: Failure: testLongFileListings (twisted.test.test_ftp.FTPPassiveClientAndServerTest) Failure: testRetr (twisted.test.test_ftp.FTPPassiveClientAndServerTest) Failure: testCorrectOrder (twisted.test.test_internet.callFromThreadTestCase) Error: testCorrectOrder (twisted.test.test_internet.callFromThreadTestCase) outside of cygwin the UI doesn't crash and manages to complete the tests, here are the results: Failure: testRetr (twisted.test.test_ftp.FTPPassiveClientAndServerTest) Failure: test_internet (twisted.test.test_import.AtLeastImportTestCase) Failure: testCallLater (twisted.test.test_internet.InterfaceTestCase) Failure: testCorrectOrder (twisted.test.test_internet.callFromThreadTestCase) Error: testCorrectOrder (twisted.test.test_internet.callFromThreadTestCase) Error: testOutput (twisted.test.test_iutils.UtilsTestCase) Error: testValue (twisted.test.test_iutils.UtilsTestCase) Failure: testNoPermission (twisted.test.test_logfile.LogFileTestCase) Error: testEcho (twisted.test.test_process.ProcessTestCase) Error: testProcess (twisted.test.test_process.ProcessTestCase) Error: testStdinReader (twisted.test.test_process.Win32ProcessTestCase) Failure: testRebuild (twisted.test.test_rebuild.RebuildTestCase) Failure: testCannotBind (twisted.test.test_tcp.CannotBindTestCase) Error: testReconnect (twisted.test.test_tcp.ConnectorTestCase) Error: testUserFail (twisted.test.test_tcp.ConnectorTestCase) Error: testUserFail (twisted.test.test_tcp.ConnectorTestCase) Error: testFailing (twisted.test.test_tcp.LoopbackTestCase) Error: testMessages (twisted.test.test_unix.UnixSocketTestCase) Please find attached also the results of the tests with the -t flag, also both under cygwin and with regular python, the tests outside of cygwin gave me different results on different executions so the files inside the zip I attach are four. Maybe I should think twice about that potato-frying job, don't wanna go back to java.... :-) thanks, ciao ste [1] http://jakarta.apache.org/james/

2 1

[Twisted-Python] PATCH: Improved scheme handling in t/lore/latex.py
by Cory Dodt Nov. 21, 2002

Nov. 21, 2002

This patch uses urlparse to get URLs from html documents in a more generalizable way. It also adds the ftp scheme, and handles mailto schemes like the rest of them. URLs with no scheme are handled the regular way. ____snip____ diff -u -r1.67 latex.py --- latex.py 17 Nov 2002 18:32:56 -0000 1.67 +++ latex.py 21 Nov 2002 21:37:41 -0000 @@ -20,6 +20,8 @@ import os, re from cStringIO import StringIO +import urlparse + import tree escapingRE = re.compile(r'([#$%&_{}^~\\])') @@ -140,13 +142,12 @@ % latexEscape(os.path.basename(fileName))) def visitNode_a_href(self, node): + supported_schemes=['http', 'https', 'ftp', 'mailto'] self.visitNodeDefault(node) href = node.getAttribute('href') - if href.startswith('http://') or href.startswith('https://'): + if urlparse.urlparse(href)[0] in supported_schemes: if node.childNodes[0].data != href: self.writer('\\footnote{%s}' % latexEscape(href)) - elif href.startswith('mailto:'): - pass else: if href.startswith('#'): href = self.filename + href __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus � Powerful. Affordable. Sign up now. http://mailplus.yahoo.com

2 1

[Twisted-Python] Journal changes
by Bruce Mitchener Nov. 21, 2002

Nov. 21, 2002

Itamar and I had discussed some changes to various parts of Journal to address problems that I'd found or had while working with it (fairly extensively). These were: * Provide a way to specify the doc string when using the wrapper method of creating commands. * Separate the re-construction of the DB from the constructor of the Journal. When this was joined, it wasn't possible to employ certain useful idioms, like doing a: service.journal.insertRow(...) within a command. (That's because you're in the middle of doing this somewhere: self.journal = xxx.XXXJournal(...) * Modify how the state is stored for the journal to allow multiple journals. I have a journal for a service and then a separate journal for each indidividual game that is in action. Right now, the way that command indices and so on are stored is broken for that use case. If there aren't any objections, I'd like to get these into CVS sometime within the next week or so. Do others have changes that they need made to the Journal interfaces as well? Itamar, did I forget about any other changes that we'd discussed? Cheers, - Bruce

1 0

[Twisted-Python] Cog: Checkpointed Object Graph object database
by Itamar Shtull-Trauring Nov. 20, 2002

Nov. 20, 2002

In my never ending quest to find a nice persistence mechanism I came across this. It actually seems quite nice. I think I may have posted this once before somewhere, but whatever. http://www.randomly.org/projects/cog/index.html -- Itamar Shtull-Trauring http://itamarst.org/ Available for Python, Twisted, Zope and Java consulting ***> http://VoteNoWar.org -- vote/donate/volunteer <***

1 0

[Twisted-Python] mail and web server authentication: yet to come or already there?
by Stefano Debenedetti Nov. 20, 2002

Nov. 20, 2002

Hello all, I am a new Twisted (and Python) user and first of all I would like to thank you for the great software. I love the architecture and I am sure I will learn a lot from looking at how it is implemented. I would like to use twisted as an integrated mail/web server, in order to do some stuff like what I've done here [1]. I think I need to develop some minor but useful stuff that I will then post here so you can all see how bad my python coding is :-) for example, I am working to make the POP3 server compatible with mozilla... One thing that is puzzling me is the twisted.cred stuff, even after reading all about it in the docs it is still not clear to my dummy self how to put it to use in order to restrict access on the twisted.web service (is HTTP basic auth implemented somewhere btw?) and also I don't understand why it is not used for access control to the twisted.mail services. Simply a matter of time or is it really meant for other types of authentication? Some more examples in this very sensitive area for people not using PB would help a lot.... One very small and probably already screwing-up-things contribution that I can do now is to the SMTP class, I include herewith my first attempt at using the diff utility: $ diff cvs/Twisted/twisted/protocols/smtp.py cvs/Twisted/twisted/protocols/smtp.py_orig 137c137 < to = rest[string.find(rest, "<")+1:-len(">")] --- > to = rest[len("TO:<"):-len(">")] After modifying that, I was able to send mail using Blat [2]. I am unfortunately locked on a win$ platform for my development so many things are unnecessarily difficult, like getting C stuff to compile without having visual studio installed for instance. Is this dependancy on the m$ compiler anything unavoidable when doing python? Please forgive if that's a stupid question, I am new to this very cool language and had a very hard time getting SSL to work even though it was stated it would build with borland or cygwin compilers: I read somewhere in the twisted archives that some guy promised to write a walkthrough for that, did that ever happen :-) ? Oops the very last is this one: are ALL tests supposed to work out-of-the-box (apart from those needing the crypto lib)? When I run them the UI crashes... :-( Alright I'll stop my whining here for now and thank you very much for reading so far and providing this great framework, ciao ste p.s. aha here I go again: no way for me to access the IRC channel (lucky you :) as my provider seems to be blocking the identd stuff :-((( what happened to [3]? [1] http://webaccess.mozquito.com:8080/mail/schnitz/how-to/174073468805351802.x… [2] http://www.interlog.com/~tcharron/blat.html [3] http://www.twistedmatrix.com/users/pb.twistd/

2 1

[Twisted-Python] Woven
by Bruce Mitchener Nov. 20, 2002

Nov. 20, 2002

Hey all, Some time ago, when the major changes to Woven started to happen, Glyph and/or Donovan were going to write up what the planned changes were and where Woven was going. I've got a fairly large amount of code using old Woven and am going to be faced soon with upgrading it to current Woven. Can someone provide some sort of actual explanation of how Woven works today and what some of the typical usages are? I already walked through the old Woven and figured it out back then, but I don't have the time to re-do that work. Also, it would be nice if large architectural changes were posted about as changes were made so that people who aren't on the IRC channel could keep up with things. Thanks, - Bruce

2 1