Mailman 3 January 2014 - Python-Dev

Re: [Python-Dev] [Python-checkins] cpython: whatsnew: XMLPullParser, plus some doc updates.
by Nick Coghlan 06 Jan '14

06 Jan '14

On 5 Jan 2014 12:54, "r.david.murray" <python-checkins(a)python.org> wrote: > > http://hg.python.org/cpython/rev/069f88f4935f > changeset: 88308:069f88f4935f > user: R David Murray <rdmurray(a)bitdance.com> > date: Sat Jan 04 23:52:50 2014 -0500 > summary: > whatsnew: XMLPullParser, plus some doc updates. > > I was confused by the text saying that read_events "iterated", since it > actually returns an iterator (that's what a generator does) that the > caller must then iterate. So I tidied up the language. I'm not sure > what the sentence "Events provided in a previous call to read_events() > will not be yielded again." is trying to convey, so I didn't try to fix that. It's a mutating API - once the events have been retrieved, that's it, they're gone from the internal state. Suggestions for wording improvements welcome :) Cheers, Nick. > > Also fixed a couple more news items. > > files: > Doc/library/xml.etree.elementtree.rst | 23 +++++++++----- > Doc/whatsnew/3.4.rst | 7 ++- > Lib/xml/etree/ElementTree.py | 2 +- > Misc/NEWS | 12 +++--- > 4 files changed, 25 insertions(+), 19 deletions(-) > > > diff --git a/Doc/library/xml.etree.elementtree.rst b/Doc/library/xml.etree.elementtree.rst > --- a/Doc/library/xml.etree.elementtree.rst > +++ b/Doc/library/xml.etree.elementtree.rst > @@ -105,12 +105,15 @@ > >>> root[0][1].text > '2008' > > + > +.. _elementtree-pull-parsing: > + > Pull API for non-blocking parsing > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > -Most parsing functions provided by this module require to read the whole > -document at once before returning any result. It is possible to use a > -:class:`XMLParser` and feed data into it incrementally, but it's a push API that > +Most parsing functions provided by this module require the whole document > +to be read at once before returning any result. It is possible to use an > +:class:`XMLParser` and feed data into it incrementally, but it is a push API that > calls methods on a callback target, which is too low-level and inconvenient for > most needs. Sometimes what the user really wants is to be able to parse XML > incrementally, without blocking operations, while enjoying the convenience of > @@ -119,7 +122,7 @@ > The most powerful tool for doing this is :class:`XMLPullParser`. It does not > require a blocking read to obtain the XML data, and is instead fed with data > incrementally with :meth:`XMLPullParser.feed` calls. To get the parsed XML > -elements, call :meth:`XMLPullParser.read_events`. Here's an example:: > +elements, call :meth:`XMLPullParser.read_events`. Here is an example:: > > >>> parser = ET.XMLPullParser(['start', 'end']) > >>> parser.feed('<mytag>sometext') > @@ -1038,15 +1041,17 @@ > > .. method:: read_events() > > - Iterate over the events which have been encountered in the data fed to the > - parser. This method yields ``(event, elem)`` pairs, where *event* is a > + Return an iterator over the events which have been encountered in the > + data fed to the > + parser. The iterator yields ``(event, elem)`` pairs, where *event* is a > string representing the type of event (e.g. ``"end"``) and *elem* is the > encountered :class:`Element` object. > > Events provided in a previous call to :meth:`read_events` will not be > - yielded again. As events are consumed from the internal queue only as > - they are retrieved from the iterator, multiple readers calling > - :meth:`read_events` in parallel will have unpredictable results. > + yielded again. Events are consumed from the internal queue only when > + they are retrieved from the iterator, so multiple readers iterating in > + parallel over iterators obtained from :meth:`read_events` will have > + unpredictable results. > > .. note:: > > diff --git a/Doc/whatsnew/3.4.rst b/Doc/whatsnew/3.4.rst > --- a/Doc/whatsnew/3.4.rst > +++ b/Doc/whatsnew/3.4.rst > @@ -1088,9 +1088,10 @@ > xml.etree > --------- > > -Add an event-driven parser for non-blocking applications, > -:class:`~xml.etree.ElementTree.XMLPullParser`. > -(Contributed by Antoine Pitrou in :issue:`17741`.) > +A new parser, :class:`~xml.etree.ElementTree.XMLPullParser`, allows a > +non-blocking applications to parse XML documents. An example can be > +seen at :ref:`elementtree-pull-parsing`. (Contributed by Antoine > +Pitrou in :issue:`17741`.) > > The :mod:`xml.etree.ElementTree` :func:`~xml.etree.ElementTree.tostring` and > :func:`~xml.etree.ElementTree.tostringlist` functions, and the > diff --git a/Lib/xml/etree/ElementTree.py b/Lib/xml/etree/ElementTree.py > --- a/Lib/xml/etree/ElementTree.py > +++ b/Lib/xml/etree/ElementTree.py > @@ -1251,7 +1251,7 @@ > self._close_and_return_root() > > def read_events(self): > - """Iterate over currently available (event, elem) pairs. > + """Return an iterator over currently available (event, elem) pairs. > > Events are consumed from the internal event queue as they are > retrieved from the iterator. > diff --git a/Misc/NEWS b/Misc/NEWS > --- a/Misc/NEWS > +++ b/Misc/NEWS > @@ -2193,14 +2193,14 @@ > - Issue #17555: Fix ForkAwareThreadLock so that size of after fork > registry does not grow exponentially with generation of process. > > -- Issue #17707: multiprocessing.Queue's get() method does not block for short > - timeouts. > - > -- Isuse #17720: Fix the Python implementation of pickle.Unpickler to correctly > +- Issue #17707: fix regression in multiprocessing.Queue's get() method where > + it did not block for short timeouts. > + > +- Issue #17720: Fix the Python implementation of pickle.Unpickler to correctly > process the APPENDS opcode when it is used on non-list objects. > > -- Issue #17012: shutil.which() no longer fallbacks to the PATH environment > - variable if empty path argument is specified. Patch by Serhiy Storchaka. > +- Issue #17012: shutil.which() no longer falls back to the PATH environment > + variable if an empty path argument is specified. Patch by Serhiy Storchaka. > > - Issue #17710: Fix pickle raising a SystemError on bogus input. > > > -- > Repository URL: http://hg.python.org/cpython > > _______________________________________________ > Python-checkins mailing list > Python-checkins(a)python.org > https://mail.python.org/mailman/listinfo/python-checkins >

2 1

Python 2.7 root buildbot showing errors
by Chris Angelico 06 Jan '14

06 Jan '14

The first build my new root buildbot did showed errors in the 2.7 test suite, but I thought little of it as quite a few other 2.7 buildbots are showing red, too. But it seems they're showing different errors, so there might be something wrong with the setup. http://buildbot.python.org/all/builders/AMD64%20Debian%20root%202.7/builds/… First off, it's complaining about being unable to build _curses (lacking curses.h). Is that a mandatory prereq that I should install, or should Python be compatible with not having it? Then further down, several SSL tests attempt: s.connect_ex(("svn.python.org", 444))) and get back EAGAIN when they're expecting ECONNREFUSED. Possibly my firewall's delaying things somewhat and it's timing out with a signal; when I try manually, the connection times out. Are these failures a problem? Should they be fixed? The 3.x builds are all coming up green. ChrisA

3 5

Subclasses vs. special methods
by Serhiy Storchaka 06 Jan '14

06 Jan '14

Should implicit converting an instance of int, float, complex, str, bytes, etc subclasses to call appropriate special method __int__ (or __index__), __float__, __complex__, __str__, __bytes__, etc? Currently explicit converting calls these methods, but implicit converting doesn't. >>> class I(int): ... def __int__(self): return 42 ... def __index__(self): return 43 ... >>> class F(float): ... def __float__(self): return 42.0 ... >>> class S(str): ... def __str__(self): return '*' ... >>> int(I(65)) 42 >>> float(F(65)) 42.0 >>> str(S('A')) '*' >>> chr(I(65)) 'A' >>> import cmath; cmath.rect(F(65), 0) (65+0j) >>> ord(S('A')) 65 Issue17576 [1] proposes to call special methods for implicit converting. I have doubts about this. 1. I afraid that this will adds places where arbitrary Python code is unexpectedly called. For example see changeset9a61be172c23 discussed in neighbor thread. If the "k" format code will call __int__(), Python code can modify unpacked list argument during parsing arguments in PyArg_ParseTuple(). 2. PyLong_As*() functions already is not very consistent. Some of them calls __int__() for argument which is not an instance of int subclass, other accepts only instances of int subclasses. PyLong_AsVoidPtr() calls or not calls __int__() depending on the sign of the argument. 3. We can't consistency call special methods for all types. E.g. for strings we can't call __str__() when processing the "s" code in PyArg_ParseTuple() because this will cause a leak. I think that overriding special converting method in a subclass of corresponding type should be restricted. I see two consistent and safe possibilities: 1. Forbidden. I.e. above declarations of I, F and S classes should raise exceptions. 2. Has no effect. I.e. both int(I(65)) and operator.index(I(65)) should return 65. [1] http://bugs.python.org/issue17576

2 1

2.x vs 3.x survey results
by Dan Stromberg 06 Jan '14

06 Jan '14

Is there a better place to put this than: http://stromberg.dnsalias.org/~strombrg/python-2.x-vs-3.x-survey/ Thanks.

14 20

[RELEASE] libmpdec-2.4.0 (suitable for compiling _decimal)
by Stefan Krah 05 Jan '14

05 Jan '14

Hi, I've released libmpdec-2.4.0, which can be used to compile _decimal with the "--with-system-libmpdec" configure option: http://www.bytereef.org/mpdecimal/download.html libmpdec-2.4.0 is exactly the same as the one in the CPython source tree. The API is stable and the libmpdec-2.x.y series will stay binary compatible [1]. Stefan Krah [1] Starting from 2.4.0: 2.4.0 is not binary compatible with 2.3.

1 0

Re: [Python-Dev] [Python-checkins] cpython: Issue #19976: Argument Clinic METH_NOARGS functions now always
by Stefan Krah 04 Jan '14

04 Jan '14

Probably Rietveld did not send mail, so I mention my review comments again: larry.hastings <python-checkins(a)python.org> wrote: > +#ifdef __GNUC__ > +#define Py_UNUSED(name) _unused_ ## name __attribute__((unused)) > +#else > +#define Py_UNUSED(name) _unused_ ## name > +#endif > + The Intel compiler defines __GNUC__ but chokes on the __attribute__(). This works: #if defined(__GNUC__) && !defined(__INTEL_COMPILER) > +_pickle_Pickler_clear_memo(PyObject *self, PyObject *Py_UNUSED(ignored)) I'm not a native speaker, but UNUSED(ignored) reads strange to me. I would prefer UNUSED(args). Stefan Krah

2 2

Bug? http.client assumes iso-8859-1 encoding of HTTP headers
by Hugo G. Fierro 04 Jan '14

04 Jan '14

Hi Python devs, I am trying to download an HTML document. I get an HTTP 301 (Moved Permanently) with a UTF-8 encoded Location header and http.client decodes it as iso-8859-1. When there's a non-ASCII character in the redirect URL then I can't download the document. In client.py def parse_headers() I see the call to decode('iso-8859-1'). My personal hack is to use whatever charset is defined in the Content-Type HTTP header (utf8) or fall back into iso-8859-1. At this point I am not sure where/how a fix should occur so I thought I'd run it by you in case I should file a bug. Note that I don't use http.client directly, but through the python-requests library. I include some code to reproduce the problem below. Cheers, Hugo ----- #!/usr/bin/env python3 # Trying to replicate what wget does with a 301 redirect: # wget --server-response www.starbucks.com/store/158/AT/Karntnerstrasse/K%c3%a4rntnerstrasse-49-Vien… import http.client import urllib.parse s2='/store/158/AT/Karntnerstrasse/K%c3%a4rntnerstrasse-49-Vienna-9-1010' s3=' http://www.starbucks.com/store/158/at/karntnerstrasse/k%C3%A4rntnerstrasse-… ' conn = http.client.HTTPConnection('www.starbucks.com') conn.request('GET', s2) r = conn.getresponse() print('Location', r.headers.get('Location')) print('Expected', urllib.parse.unquote(s3)) assert r.status == 301 assert r.headers.get('Location') == urllib.parse.unquote(s3), \ 'decoded as iso-8859-1 instead of utf8' conn = http.client.HTTPConnection('www.starbucks.com') conn.request('GET', s3) r = conn.getresponse() assert r.status == 200

4 3

Re: [Python-Dev] cpython: threading.RLock._acquire_restore() now raises a TypeError instead of a
by Serhiy Storchaka 04 Jan '14

04 Jan '14

02.01.14 13:54, victor.stinner написав(ла): > http://hg.python.org/cpython/rev/9a61be172c23 > changeset: 88249:9a61be172c23 > user: Victor Stinner <victor.stinner(a)gmail.com> > date: Thu Jan 02 12:47:24 2014 +0100 > summary: > threading.RLock._acquire_restore() now raises a TypeError instead of a > SystemError when it is not called with 2 arguments > - if (!PyArg_ParseTuple(arg, "kl:_acquire_restore", &count, &owner)) > + if (!PyArg_ParseTuple(args, "(kl):_acquire_restore", &count, &owner)) > return NULL; Please don't use "(...)" in PyArg_ParseTuple, it is dangerous (see issue6083 [1]). [1] http://bugs.python.org/issue6083

3 3

Summary of Python tracker Issues
by Python tracker 03 Jan '14

03 Jan '14

ACTIVITY SUMMARY (2013-12-27 - 2014-01-03) Python tracker at http://bugs.python.org/ To view or respond to any of the issues listed below, click on the issue. Do NOT respond to this message. Issues counts and deltas: open 4348 (+16) closed 27538 (+18) total 31886 (+34) Open issues with patches: 1977 Issues opened (27) ================== #18310: itertools.tee() can't accept keyword arguments http://bugs.python.org/issue18310 reopened by py.user #20081: sys.getwindowsversion does not show some fields http://bugs.python.org/issue20081 opened by giampaolo.rodola #20082: Misbehavior of BufferedRandom.write with raw file in append mo http://bugs.python.org/issue20082 opened by erik.bray #20083: smtplib: support for IDN (international domain names) http://bugs.python.org/issue20083 opened by macfreek #20085: Python2.7, wxPython and IDLE 2.7 http://bugs.python.org/issue20085 opened by stubz #20086: test_locale fails on PPC64 PowerLinux http://bugs.python.org/issue20086 opened by serhiy.storchaka #20087: Mismatch between glibc and X11 locale.alias http://bugs.python.org/issue20087 opened by serhiy.storchaka #20088: locale.getlocale() fails if locale name doesn't include encodi http://bugs.python.org/issue20088 opened by serhiy.storchaka #20089: email.message_from_string no longer working in Python 3.4 http://bugs.python.org/issue20089 opened by apollo13 #20090: slight ambiguity in README.txt instructions for building docs http://bugs.python.org/issue20090 opened by MLModel #20091: An index entry for __main__ in "30.5 runpy" is missing http://bugs.python.org/issue20091 opened by MLModel #20092: type() constructor should bind __int__ to __index__ when __ind http://bugs.python.org/issue20092 opened by ethan.furman #20093: Wrong OSError message from os.rename() when dst is a non-empty http://bugs.python.org/issue20093 opened by jderose #20094: intermitent failures with test_dbm http://bugs.python.org/issue20094 opened by ethan.furman #20096: Mention modernize and future in Python 2/3 porting HOWTO http://bugs.python.org/issue20096 opened by brett.cannon #20098: email policy needs a mangle_from setting http://bugs.python.org/issue20098 opened by r.david.murray #20100: epoll docs are not clear with regards to CLOEXEC. http://bugs.python.org/issue20100 opened by r.david.murray #20101: Determine correct behavior for time functions on Windows http://bugs.python.org/issue20101 opened by zach.ware #20102: shutil._make_zipfile possible resource leak http://bugs.python.org/issue20102 opened by peter(a)psantoro.net #20103: Documentation of itertools.accumulate is confused http://bugs.python.org/issue20103 opened by MLModel #20104: expose posix_spawn(p) http://bugs.python.org/issue20104 opened by benjamin.peterson #20105: Codec exception chaining is losing traceback details http://bugs.python.org/issue20105 opened by ncoghlan #20106: warn_dir is always true for install_data, even if an install_d http://bugs.python.org/issue20106 opened by tabrezm #20109: TestProgram is mentioned in the unittest docs but is not docum http://bugs.python.org/issue20109 opened by r.david.murray #20112: The documentation for http.server error_message_format is inad http://bugs.python.org/issue20112 opened by r.david.murray #20113: os.readv() and os.writev() don't raise an OSError on readv()/w http://bugs.python.org/issue20113 opened by haypo #20114: Sporadic failure of test_semaphore_tracker() of test_multiproc http://bugs.python.org/issue20114 opened by haypo Most recent 15 issues with no replies (15) ========================================== #20114: Sporadic failure of test_semaphore_tracker() of test_multiproc http://bugs.python.org/issue20114 #20112: The documentation for http.server error_message_format is inad http://bugs.python.org/issue20112 #20109: TestProgram is mentioned in the unittest docs but is not docum http://bugs.python.org/issue20109 #20106: warn_dir is always true for install_data, even if an install_d http://bugs.python.org/issue20106 #20105: Codec exception chaining is losing traceback details http://bugs.python.org/issue20105 #20103: Documentation of itertools.accumulate is confused http://bugs.python.org/issue20103 #20102: shutil._make_zipfile possible resource leak http://bugs.python.org/issue20102 #20096: Mention modernize and future in Python 2/3 porting HOWTO http://bugs.python.org/issue20096 #20091: An index entry for __main__ in "30.5 runpy" is missing http://bugs.python.org/issue20091 #20090: slight ambiguity in README.txt instructions for building docs http://bugs.python.org/issue20090 #20088: locale.getlocale() fails if locale name doesn't include encodi http://bugs.python.org/issue20088 #20087: Mismatch between glibc and X11 locale.alias http://bugs.python.org/issue20087 #20082: Misbehavior of BufferedRandom.write with raw file in append mo http://bugs.python.org/issue20082 #20078: zipfile - ZipExtFile.read goes into 100% CPU infinite loop on http://bugs.python.org/issue20078 #20076: Add UTF-8 locale aliases http://bugs.python.org/issue20076 Most recent 15 issues waiting for review (15) ============================================= #20113: os.readv() and os.writev() don't raise an OSError on readv()/w http://bugs.python.org/issue20113 #20102: shutil._make_zipfile possible resource leak http://bugs.python.org/issue20102 #20098: email policy needs a mangle_from setting http://bugs.python.org/issue20098 #20082: Misbehavior of BufferedRandom.write with raw file in append mo http://bugs.python.org/issue20082 #20080: Unused variable in Lib/sqlite3/test/factory.py http://bugs.python.org/issue20080 #20079: Add support for glibc supported locales http://bugs.python.org/issue20079 #20077: Format of TypeError differs between comparison and arithmetic http://bugs.python.org/issue20077 #20076: Add UTF-8 locale aliases http://bugs.python.org/issue20076 #20075: help(open) eats first line http://bugs.python.org/issue20075 #20072: Ttk tests fail when wantobjects is false http://bugs.python.org/issue20072 #20069: Add unit test for os.chown http://bugs.python.org/issue20069 #20064: PyObject_Malloc is not documented http://bugs.python.org/issue20064 #20042: Python Launcher, Windows, fails on scripts w/ non-latin names http://bugs.python.org/issue20042 #20041: TypeError when f_trace is None and tracing. http://bugs.python.org/issue20041 #20035: Suppress 'os.environ was modified' warning on Tcl/Tk tests http://bugs.python.org/issue20035 Top 10 most discussed issues (10) ================================= #19995: %c, %o, %x, %X accept non-integer values instead of raising an http://bugs.python.org/issue19995 9 msgs #20092: type() constructor should bind __int__ to __index__ when __ind http://bugs.python.org/issue20092 8 msgs #20101: Determine correct behavior for time functions on Windows http://bugs.python.org/issue20101 7 msgs #20083: smtplib: support for IDN (international domain names) http://bugs.python.org/issue20083 6 msgs #11798: Test cases not garbage collected after run http://bugs.python.org/issue11798 5 msgs #20075: help(open) eats first line http://bugs.python.org/issue20075 5 msgs #16039: imaplib: unlimited readline() from connection http://bugs.python.org/issue16039 4 msgs #16778: Logger.findCaller needs to be smarter http://bugs.python.org/issue16778 4 msgs #18310: itertools.tee() can't accept keyword arguments http://bugs.python.org/issue18310 4 msgs #19944: Make importlib.find_spec load packages as needed http://bugs.python.org/issue19944 3 msgs Issues closed (18) ================== #16113: SHA-3 (Keccak) support may need to be removed before 3.4 http://bugs.python.org/issue16113 closed by loewis #17282: document the defaultTest parameter to unittest.main() http://bugs.python.org/issue17282 closed by r.david.murray #19347: PEP 453 implementation tracking issue http://bugs.python.org/issue19347 closed by ncoghlan #19422: Neither DTLS nor error for SSLSocket.sendto() of UDP socket http://bugs.python.org/issue19422 closed by pitrou #19648: Empty tests in pickletester need to be implemented or removed http://bugs.python.org/issue19648 closed by pitrou #19728: PEP 453: enable pip by default in the Windows binary installer http://bugs.python.org/issue19728 closed by loewis #19749: test_venv failure on AIX: 'module' object has no attribute 'O_ http://bugs.python.org/issue19749 closed by loewis #19918: PureWindowsPath.relative_to() is not case insensitive http://bugs.python.org/issue19918 closed by pitrou #20031: unittest.TextTestRunner missing run() documentation. http://bugs.python.org/issue20031 closed by python-dev #20055: On Windows NT 6 with administrator account, there are two fail http://bugs.python.org/issue20055 closed by pitrou #20084: smtplib: support for UTF-8 encoded headers (SMTPUTF8) http://bugs.python.org/issue20084 closed by r.david.murray #20095: what is that result!? http://bugs.python.org/issue20095 closed by mark.dickinson #20097: Bad use of `self` in importlib http://bugs.python.org/issue20097 closed by eric.snow #20099: a new idea http://bugs.python.org/issue20099 closed by ezio.melotti #20107: Revert PEP 453 integration http://bugs.python.org/issue20107 closed by dstufft #20108: cannot pass kwarg `func` to `inspect.getcallargs` http://bugs.python.org/issue20108 closed by python-dev #20110: Misleading word used for __annotations__ http://bugs.python.org/issue20110 closed by python-dev #20111: pathlib.PurePath.with_suffix() allows creation of otherwise im http://bugs.python.org/issue20111 closed by pitrou

1 0

Re: [Python-Dev] [Python-checkins] cpython: add unicode_char() in unicodeobject.c to factorize code
by Zachary Ware 03 Jan '14

03 Jan '14

On Fri, Jan 3, 2014 at 6:01 AM, victor.stinner <python-checkins(a)python.org> wrote: > http://hg.python.org/cpython/rev/d453c95def31 > changeset: 88271:d453c95def31 > user: Victor Stinner <victor.stinner(a)gmail.com> > date: Fri Jan 03 12:53:47 2014 +0100 > summary: > add unicode_char() in unicodeobject.c to factorize code > > files: > Objects/unicodeobject.c | 86 ++++++++++------------------ > 1 files changed, 31 insertions(+), 55 deletions(-) > > > diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c > --- a/Objects/unicodeobject.c > +++ b/Objects/unicodeobject.c <snip> > @@ -2887,17 +2883,7 @@ > return NULL; > } > > - if ((Py_UCS4)ordinal < 256) > - return get_latin1_char((unsigned char)ordinal); > - > - v = PyUnicode_New(1, ordinal); > - if (v == NULL) > - return NULL; > - kind = PyUnicode_KIND(v); > - data = PyUnicode_DATA(v); > - PyUnicode_WRITE(kind, data, 0, ordinal); > - assert(_PyUnicode_CheckConsistency(v, 1)); > - return v; > + return unicode_char((Py_UCS4)ordinal); > } > > PyObject * > @@ -11354,17 +11340,7 @@ > kind = PyUnicode_KIND(self); > data = PyUnicode_DATA(self); > ch = PyUnicode_READ(kind, data, index); > - if (ch < 256) > - return get_latin1_char(ch); > - > - res = PyUnicode_New(1, ch); > - if (res == NULL) > - return NULL; > - kind = PyUnicode_KIND(res); > - data = PyUnicode_DATA(res); > - PyUnicode_WRITE(kind, data, 0, ch); > - assert(_PyUnicode_CheckConsistency(res, 1)); > - return res; > + return unicode_char(ch); > } > > /* Believe it or not, this produces the same value for ASCII strings The above-quoted parts of this changeset caused several compiler warnings due to unused variables. On 32-bit Windows: ..\Objects\unicodeobject.c(2881): warning C4101: 'kind' : unreferenced local variable [P:\ath\to\cpython\PCbuild\pythoncore.vcxproj] ..\Objects\unicodeobject.c(2879): warning C4101: 'v' : unreferenced local variable [P:\ath\to\cpython\PCbuild\pythoncore.vcxproj] ..\Objects\unicodeobject.c(2880): warning C4101: 'data' : unreferenced local variable [P:\ath\to\cpython\PCbuild\pythoncore.vcxproj] ..\Objects\unicodeobject.c(11333): warning C4101: 'res' : unreferenced local variable [P:\ath\to\cpython\PCbuild\pythoncore.vcxproj] I believe this should fix it, but I'll leave it up to you to confirm that, Victor :) diff -r 8a3718f31188 Objects/unicodeobject.c --- a/Objects/unicodeobject.c Fri Jan 03 15:53:20 2014 +0100 +++ b/Objects/unicodeobject.c Fri Jan 03 10:20:12 2014 -0600 @@ -2876,10 +2876,6 @@ PyObject * PyUnicode_FromOrdinal(int ordinal) { - PyObject *v; - void *data; - int kind; - if (ordinal < 0 || ordinal > MAX_UNICODE) { PyErr_SetString(PyExc_ValueError, "chr() arg not in range(0x110000)"); @@ -11330,7 +11326,6 @@ void *data; enum PyUnicode_Kind kind; Py_UCS4 ch; - PyObject *res; if (!PyUnicode_Check(self) || PyUnicode_READY(self) == -1) { PyErr_BadArgument(); -- Zach

2 1